XDP cloud mailing list archives
 help / color / mirror / Atom feed
* [xdp-cloud] seed code for xdp-cloud repo
@ 2021-02-09  3:37 David Ahern
  2021-02-09 14:02 ` [xdp-cloud] " Jesper Dangaard Brouer
  0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2021-02-09  3:37 UTC (permalink / raw)
  To: Jesper Dangaard Brouer, Toke Høiland-Jørgensen, cloud

Jesper,

I recall you had thoughts about initial seed code - something other than
just pulling what I have in my bpf-progs repo - e.g., the l2fwd code.
Anything I can do to help get this kickstarted?

David

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [xdp-cloud] Re: seed code for xdp-cloud repo
  2021-02-09  3:37 [xdp-cloud] seed code for xdp-cloud repo David Ahern
@ 2021-02-09 14:02 ` Jesper Dangaard Brouer
  2021-02-09 16:02   ` David Ahern
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Dangaard Brouer @ 2021-02-09 14:02 UTC (permalink / raw)
  To: David Ahern; +Cc: cloud, brouer


On Mon, 8 Feb 2021 20:37:14 -0700 David Ahern <dsahern@gmail.com> wrote:

> I recall you had thoughts about initial seed code - something other than
> just pulling what I have in my bpf-progs repo - e.g., the l2fwd code.
> Anything I can do to help get this kickstarted?

My concerns with your repo[1] is primarily how you integrate libbpf.
E.g. I don't like having libbpf.a directly part of the repo.

Toke and I have created a repo for bpf-examples[2], that we believe
have a better integration (and auto-detection) for libbpf.  I will
prefer we can create a similar build environment in our xdp-cloud[3]
git repo.  The repo[3] already exist, but without any code.

If you have time, you can look at bpf-examples[2] and see what you
think, and maybe even go ahead and create the build env if you like our
approach.

Note, I do plan to make some changes[4] to bpf-examples around
splitting the include files into two directories, to make it more clear
what comes from kernel and what belong to project itself.

[1] https://github.com/dsahern/bpf-progs/tree/master/libbpf/usr/lib64
[2] https://github.com/xdp-project/bpf-examples/
[3] https://github.com/xdp-project/xdp-cloud
[4] https://github.com/xdp-project/bpf-examples/pull/8#issuecomment-760088297
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [xdp-cloud] Re: seed code for xdp-cloud repo
  2021-02-09 14:02 ` [xdp-cloud] " Jesper Dangaard Brouer
@ 2021-02-09 16:02   ` David Ahern
  0 siblings, 0 replies; 3+ messages in thread
From: David Ahern @ 2021-02-09 16:02 UTC (permalink / raw)
  To: Jesper Dangaard Brouer; +Cc: cloud

On 2/9/21 7:02 AM, Jesper Dangaard Brouer wrote:
> 
> On Mon, 8 Feb 2021 20:37:14 -0700 David Ahern <dsahern@gmail.com> wrote:
> 
>> I recall you had thoughts about initial seed code - something other than
>> just pulling what I have in my bpf-progs repo - e.g., the l2fwd code.
>> Anything I can do to help get this kickstarted?
> 
> My concerns with your repo[1] is primarily how you integrate libbpf.
> E.g. I don't like having libbpf.a directly part of the repo.

Ease of use for a personal repo that moves across nodes, and I did not
want libbpf as a submodule. I also had changes to libbpf that just made
it easier to install a copy into the repo for rapid development.

> 
> Toke and I have created a repo for bpf-examples[2], that we believe
> have a better integration (and auto-detection) for libbpf.  I will
> prefer we can create a similar build environment in our xdp-cloud[3]
> git repo.  The repo[3] already exist, but without any code.
> 
> If you have time, you can look at bpf-examples[2] and see what you
> think, and maybe even go ahead and create the build env if you like our
> approach.

ack.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-09 16:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09  3:37 [xdp-cloud] seed code for xdp-cloud repo David Ahern
2021-02-09 14:02 ` [xdp-cloud] " Jesper Dangaard Brouer
2021-02-09 16:02   ` David Ahern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox