XDP cloud mailing list archives
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Marcus Wichelmann <marcus.wichelmann@hetzner-cloud.de>,
	xdp-newbies@vger.kernel.org, cloud@xdp-project.net
Cc: brouer@redhat.com, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	David Ahern <dsahern@kernel.org>,
	Anton Protopopov <aspsk@isovalent.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Jason Wang <jasowang@redhat.com>,
	"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: [xdp-cloud] Re: Questions about Offloads and XDP-Hints regarding a Cloud-Provider Use-Case
Date: Wed, 28 Sep 2022 20:07:41 +0200	[thread overview]
Message-ID: <b207f828-8ba2-7bdd-01e6-3354172531b5@redhat.com> (raw)
In-Reply-To: <30dd392b-ff2f-1e25-175a-6666dde200ed@hetzner-cloud.de>

On 28/09/2022 15.54, Marcus Wichelmann wrote:
> I'm working for a cloud hosting provider and we're working on a new 
> XDP-based networking stack for our VM-Hosts that uses XDP to accelerate 
> the connectivity of our qemu/KVM VMs to the outside.

Welcome to the community! Sounds like an excellent use-case and
opportunity for speeding up the RX packets from physical NIC into the
VM.  Good to hear someone (again) having this use-case. I've personally
not been focused on this use-case lately, mostly because community
members that I was interacting with changed jobs, away from cloud
hosting companies. Good to have a user back in this area!

> For this, we use XDP_REDIRECT to forward packets between the physical 
> host NIC and the VM tap devices. The main issue we have now is, that our 
> VM guests have some virtio NIC offloads enabled: rx/tx checksumming, 
> TSO/GSO, GRO and Scatter-Gather.

Supporting RX-checksumming is part of the plans for XDP-hints, although
virtio_net is not part of my initial patchset.

XDP-redirect with GRO and Scatter-Gather frames are part of the
multi-buff effort (Cc Lorenzo), but currently XDP_REDIRECT with
multi-buff is disabled (except for cpumap), because the lack of
XDP-feature bits, meaning we cannot determine (in kernel) if receiving
net_device supports multi-buff (Cc Kumar).

> Currently, these offloads (especially TSO/GSO) are incompatible with 
> XDP_REDIRECT and result in packets being dropped. Because disabling 
> these offloads in all our customer VMs is not a good option, we're 
> searching for ways to support these offloads with XDP.

To David Ahern, didn't the kernel recently loosen up on having to
disable these offloads for KVM virtio_net?

My (long term) goal is to improve the situation and allow more offloads
to get enabled for KVM/virtio_net. But my current focus is on veth.

> The XDP multi-buffer support needed for TSO/GSO seems to be mostly there 

A subtle detail is that both XDP-hints and XDP multi-buff are needed to
get GRO/GSO kernel infra working.  For the kernel to construct GRO-SKB
based packets on XDP-redirected incoming xdp_frame's, the kernel code
requires both RX-csum and RX-hash before coalescing GRO frames.

> already, but, to our understanding, the last missing part for full 
> TSO/GSO support is a way to tell the physical NIC to perform the TSO/GSO 
> offload.

The TSO/GSO side is usually the TX side.  The VM should be able to send
out normal TSO/GSO (multi-buffer) packets.  Or are you saying this also
gets disabled when enabling XDP on the virtio_net RX side?

> I've seen  the latest LPC 2022 talk from Jesper Dangaard Brouer 
> regarding the planned XDP-Hints feature. But this was mainly about 
> Checksum and VLAN offloads. Is supporting TSO/GSO also one of the goals 
> you have in mind with these XDP-Hints proposals?

As mentioned TSO/GSO is TX side. We (Cc Magnus) also want to extend
XDP-hints to TX-side, to allow asking the HW to perform different
offloads. Lets land RX-side first.

> Will the multi-buffer and hints patches be all what's needed to make 
> XDP_REDIRECT between a VM (without disabled offloads) and the host NIC 
> possible, or are there more things missing in XDP that will become an 
> issue in that use-case?

As hinted above, we also need net_device XDP-features to enable
redirecting XDP multi-buff frames.

> The "XDP Cloud-Provider" project page describes a very similar use-case 
> to what we plan to do. What's the goal of this project?

Yes, this sounds VERY similar to your use-case.

I think you are referring to this:
  [1] https://xdp-project.net/areas/xdp-cloud-provider.html
  [2] https://github.com/xdp-project/xdp-cloud

We had two Cloud Hosting companies interested in this use-case and
started a "sub" xdp-project, with the intent of working together on
code[2] that implements concrete BPF tools, that functions as building
blocks that the individual companies can integrate into their systems,
separating out customer provisioning to the companies.
(p.s. this approach have worked well for xdp-cpumap-tc[3] scaling tool)

Unfortunately the Cloud-Provider project "died", because the engineers
from the Cloud Hosting companies got better job offers.  And other
engineers at these companies were apparently not motivated to takeover.

[3] https://github.com/xdp-project/xdp-cpumap-tc

> We're very interested in the work on XDP-Hints and in the performance 
> benefits that the offloading support could bring to XDP and I would be 
> thankful if you could help us with some of our questions.

Thanks for showing interest in XDP-hints, this is very motivating for me
personally to continue this work upstream.


  reply	other threads:[~2022-09-28 18:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 13:54 [xdp-cloud] " Marcus Wichelmann
2022-09-28 18:07 ` Jesper Dangaard Brouer [this message]
2022-09-28 18:32   ` [xdp-cloud] " David Ahern
     [not found]     ` <YzTMmGuZjiO8+dVu@lore-desk>
2022-09-29  2:14       ` Jason Wang
2022-09-29  4:00         ` David Ahern
2022-09-29 13:16   ` Marcus Wichelmann
2022-10-03 10:56     ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.xdp-project.net/postorius/lists/cloud.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b207f828-8ba2-7bdd-01e6-3354172531b5@redhat.com \
    --to=jbrouer@redhat.com \
    --cc=aspsk@isovalent.com \
    --cc=brouer@redhat.com \
    --cc=cloud@xdp-project.net \
    --cc=dsahern@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=magnus.karlsson@intel.com \
    --cc=marcus.wichelmann@hetzner-cloud.de \
    --cc=memxor@gmail.com \
    --cc=xdp-newbies@vger.kernel.org \
    --subject='[xdp-cloud] Re: Questions about Offloads and XDP-Hints regarding a Cloud-Provider Use-Case' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox