From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; spf=pass (mailfrom) smtp.mailfrom=linux.dev (client-ip=188.165.223.204; helo=out2.migadu.com; envelope-from=martin.lau@linux.dev; receiver=<UNKNOWN>)
Authentication-Results: mail.toke.dk;
	dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=RTXXh5k1
Received: from out2.migadu.com (out2.migadu.com [188.165.223.204])
	by mail.toke.dk (Postfix) with ESMTPS id 44B2A9D8AFD
	for <xdp-hints@xdp-project.net>; Wed,  4 Jan 2023 03:05:42 +0100 (CET)
Message-ID: <f372a5ca-d9f1-e44e-07fb-3ec1e089e2f7@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1672797941;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=l6FK8fxQs0Li6/NLpmqWpkSek5USo3mefm4+LR8SZbw=;
	b=RTXXh5k1+OFsl/fP6roHOnjVfs9Ei2NzSFZJY1eNOwSi+VJK4h5cJNQ1jsjRbcbqXtomDs
	5SlAQSeTTsgU5XYUQenmDy5aJliiPVr/oa08ib7FyxfhJPfMjL6n3hTPR2v1JnhM11ZUKg
	UCLij+k83FITN0kcA2B/p8ZAn62cYPc=
Date: Tue, 3 Jan 2023 18:05:25 -0800
MIME-Version: 1.0
Content-Language: en-US
To: Stanislav Fomichev <sdf@google.com>
References: <20221220222043.3348718-1-sdf@google.com>
 <20221220222043.3348718-12-sdf@google.com>
 <18bed458-0128-d434-8b7a-bf676a0ea863@linux.dev>
 <CAKH8qBst6==Rw1mQohjNimf5QZrPJ05d+XLjqyyT1W8fENNz4w@mail.gmail.com>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <CAKH8qBst6==Rw1mQohjNimf5QZrPJ05d+XLjqyyT1W8fENNz4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT
Message-ID-Hash: KAV5FBIXWSAYB7FJQ6LTIHAFK5SH75V5
X-Message-ID-Hash: KAV5FBIXWSAYB7FJQ6LTIHAFK5SH75V5
X-MailFrom: martin.lau@linux.dev
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Willem de Bruijn <willemb@google.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Alexander Lobakin <alexandr.lobakin@intel.com>, Magnus Karlsson <magnus.karlsson@gmail.com>, Maryam Tahhan <mtahhan@redhat.com>, xdp-hints@xdp-project.net, netdev@vger.kernel.org, bpf@vger.kernel.org
X-Mailman-Version: 3.3.7
Precedence: list
Subject: [xdp-hints] Re: [PATCH bpf-next v5 11/17] selftests/bpf: Verify xdp_metadata xdp->af_xdp path
List-Id: XDP hardware hints design discussion <xdp-hints.xdp-project.net>
Archived-At: <https://lists.xdp-project.net/xdp-hints/f372a5ca-d9f1-e44e-07fb-3ec1e089e2f7@linux.dev/>
List-Archive: <https://lists.xdp-project.net/xdp-hints/>
List-Help: <mailto:xdp-hints-request@xdp-project.net?subject=help>
List-Owner: <mailto:xdp-hints-owner@xdp-project.net>
List-Post: <mailto:xdp-hints@xdp-project.net>
List-Subscribe: <mailto:xdp-hints-join@xdp-project.net>
List-Unsubscribe: <mailto:xdp-hints-leave@xdp-project.net>

On 12/22/22 8:06 PM, Stanislav Fomichev wrote:
>>> +     /* First half of umem is for TX. This way address matches 1-to-1
>>> +      * to the completion queue index.
>>> +      */
>>> +
>>> +     for (i = 0; i < UMEM_NUM / 2; i++) {
>>> +             addr = i * UMEM_FRAME_SIZE;
>>> +             printf("%p: tx_desc[%d] -> %lx\n", xsk, i, addr);
>> Do you still need this verbose printf which is in a loop?  Also, how about other
>> printf in this test?
> In case we'd ever need to debug this test, those printfs shouldn't
> hurt, right? Or are you concerned about this test polluting the output
> with something like 'test_progs -v -v' ?
> 

Asking just in case it was some left over from the earlier rfc that is no longer 
needed. I think only failure test get logged in CI, so I don't mind to leave 
them here if they will be useful to debug other earlier/later ASSERTs.