From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass (mailfrom) smtp.mailfrom=iogearbox.net (client-ip=2a01:4f8:d0a:276a::2; helo=www62.your-server.de; envelope-from=daniel@iogearbox.net; receiver=) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=iogearbox.net header.i=@iogearbox.net header.a=rsa-sha256 header.s=default2302 header.b=YRhhNtQV Received: from www62.your-server.de (www62.your-server.de [IPv6:2a01:4f8:d0a:276a::2]) by mail.toke.dk (Postfix) with ESMTPS id A7A019FFF92 for ; Fri, 21 Apr 2023 16:52:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=J9qyPU+PVnsNsWzTVs4DoiCRroFoofUuOFvtJinm82Q=; b=YRhhNtQVDz+1hX//XCxHP/YsIP 9aAfbEclTj5/QSEk7AnKYOgmGBgADCYIyheaW8eJemBmSlEQ/2vSW5shnHyPr40uhHjhs1Y7yPj9X eXVO44Y187UjR54YHjwaSCNXHsAIAuXvc/nnWXKdvIl/3UoERRRBRJPwwtbfm7zgOPQx762hcbPM7 UXTAamIUsT7dwHO32xHlzi6LsFKJbjB7qBtLfmeEt6ArG0mbfx6VDLPTMVKvaS4eP+BC9beqI0aDN eVF1lQCdtwgro4fzD2bBqdEuW7NcLgLmm+r9CLBW23p0KBpf5bgnj6HpICEWibmPRqyWRhzF9J/B5 /xXEvWfA==; Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pps7r-000NGA-SA; Fri, 21 Apr 2023 16:52:39 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pps7r-000VNF-7l; Fri, 21 Apr 2023 16:52:39 +0200 To: "Song, Yoong Siang" , "Brouer, Jesper" , "bpf@vger.kernel.org" , Stanislav Fomichev , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vu?= =?UTF-8?Q?sen?= References: <168182460362.616355.14591423386485175723.stgit@firesoul> From: Daniel Borkmann Message-ID: Date: Fri, 21 Apr 2023 16:52:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.8/26883/Fri Apr 21 09:25:39 2023) Message-ID-Hash: LW6XC7NPSCXNKHU2CSK7OHHZANECSX3V X-Message-ID-Hash: LW6XC7NPSCXNKHU2CSK7OHHZANECSX3V X-MailFrom: daniel@iogearbox.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "netdev@vger.kernel.org" , "martin.lau@kernel.org" , "ast@kernel.org" , "Lobakin, Aleksander" , "Zaremba, Larysa" , "xdp-hints@xdp-project.net" , "intel-wired-lan@lists.osuosl.org" , "pabeni@redhat.com" , "Brandeburg, Jesse" , "kuba@kernel.org" , "edumazet@google.com" , "john.fastabend@gmail.com" , "hawk@kernel.org" , "davem@davemloft.net" X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next V2 0/5] XDP-hints: XDP kfunc metadata for driver igc List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/18/23 4:53 PM, Song, Yoong Siang wrote: > On Tuesday, April 18, 2023 9:31 PM, Jesper Dangaard Brouer wrote: >> Implement both RX hash and RX timestamp XDP hints kfunc metadata for driver >> igc. >> >> First patch fix RX hashing for igc in general. >> >> Last patch change test program xdp_hw_metadata to track more timestamps, >> which helps us correlate the hardware RX timestamp with something. >> >> --- >> To maintainers: I'm uncertain which git tree this should be sent against. This is >> primary NIC driver code (net-next), but it's BPF/XDP related (bpf-next) via >> xdp_metadata_ops. >> >> Jesper Dangaard Brouer (5): >> igc: enable and fix RX hash usage by netstack >> igc: add igc_xdp_buff wrapper for xdp_buff in driver >> igc: add XDP hints kfuncs for RX hash >> igc: add XDP hints kfuncs for RX timestamp >> selftests/bpf: xdp_hw_metadata track more timestamps >> >> >> drivers/net/ethernet/intel/igc/igc.h | 35 ++++++ >> drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++-- >> .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +- >> tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++- >> tools/testing/selftests/bpf/xdp_metadata.h | 1 + >> 5 files changed, 186 insertions(+), 17 deletions(-) >> >> -- > > This patchset lgtm. > Thanks for the changes. Siang, can I take this into the patches as your: Acked-by: Song Yoong Siang ? Thanks, Daniel