From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Song Yoong Siang <yoong.siang.song@intel.com>,
"Bezdeka, Florian" <florian.bezdeka@siemens.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Vedang Patel <vedang.patel@intel.com>,
Jithu Joseph <jithu.joseph@intel.com>,
Andre Guedes <andre.guedes@intel.com>,
Stanislav Fomichev <sdf@google.com>,
Jacob Keller <jacob.e.keller@intel.com>,
David Laight <David.Laight@ACULAB.COM>
Cc: brouer@redhat.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, xdp-hints@xdp-project.net,
stable@vger.kernel.org
Subject: [xdp-hints] Re: [PATCH net v3 1/1] igc: read before write to SRRCTL register
Date: Mon, 17 Apr 2023 16:24:34 +0200 [thread overview]
Message-ID: <e7b9cb2c-1c18-7354-8d33-a924b5ae1d5b@redhat.com> (raw)
In-Reply-To: <934a4204-1920-f5e1-bcde-89429554d0d6@redhat.com>
On 14/04/2023 22.05, Jesper Dangaard Brouer wrote:
>
> On 14/04/2023 17.49, Song Yoong Siang wrote:
>> igc_configure_rx_ring() function will be called as part of XDP program
>> setup. If Rx hardware timestamp is enabled prio to XDP program setup,
>> this timestamp enablement will be overwritten when buffer size is
>> written into SRRCTL register.
>>
>> Thus, this commit read the register value before write to SRRCTL
>> register. This commit is tested by using xdp_hw_metadata bpf selftest
>> tool. The tool enables Rx hardware timestamp and then attach XDP program
>> to igc driver. It will display hardware timestamp of UDP packet with
>> port number 9092. Below are detail of test steps and results.
>>
[...]
>>
>> Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")
>> Cc: <stable@vger.kernel.org> # 5.14+
>> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>> Reviewed-by: Jesper Dangaard Brouer <brouer@redhat.com>
>> ---
>
> LGTM, thank for the adjustments :-)
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
Tested-by: Jesper Dangaard Brouer <brouer@redhat.com>
I can confirm that this patch fix the issue I experienced with igc.
This patch clearly fixes a bug in igc when writing the SRRCTL register.
(as bit 30 in register is "Timestamp Received Packet" which got cleared
before).
Florian might have found another bug around RX timestamps, but this
patch should be safe and sane to apply as is.
>> v2 -> v3: Refactor SRRCTL definitions to more human readable definitions
>> v1 -> v2: Fix indention
>> ---
>> drivers/net/ethernet/intel/igc/igc_base.h | 11 ++++++++---
>> drivers/net/ethernet/intel/igc/igc_main.c | 7 +++++--
>> 2 files changed, 13 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2023-04-17 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 15:49 [xdp-hints] " Song Yoong Siang
2023-04-14 20:05 ` [xdp-hints] " Jesper Dangaard Brouer
2023-04-17 14:24 ` Jesper Dangaard Brouer [this message]
2023-04-18 9:31 ` Florian Bezdeka
2023-04-15 9:19 ` Florian Bezdeka
2023-04-16 2:19 ` Song, Yoong Siang
2023-04-17 2:53 ` Zulkifli, Muhammad Husaini
2023-04-17 18:50 ` Jakub Kicinski
2023-04-30 5:05 ` [xdp-hints] Re: [Intel-wired-lan] " naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b9cb2c-1c18-7354-8d33-a924b5ae1d5b@redhat.com \
--to=jbrouer@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=andre.guedes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.bezdeka@siemens.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jithu.joseph@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=stable@vger.kernel.org \
--cc=vedang.patel@intel.com \
--cc=xdp-hints@xdp-project.net \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox