From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id 86BBBA06F5F for ; Mon, 15 May 2023 17:07:27 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ciovFYeg DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684163246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqAunJggVfMk8DVsWWYkCIQsfbXlahXMSDO8JBjiKzE=; b=ciovFYegbNemyATD9Insex34Ag3uLGl1m211RdqhGltNHcUiOysp9Stca23kZey+GXtTwD Sf8WROu1JSzGY+4CEYIbDXuifFxBWshr80/y1v6oU6RXG1jy+JmWNJinYsgkNfNnYvI6YO 6A7HnvtCXLf6ch7iSWPWq0ZTCwJAGi8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-qJ-ejLCXP_Sy1jMxTOXHZw-1; Mon, 15 May 2023 11:07:23 -0400 X-MC-Unique: qJ-ejLCXP_Sy1jMxTOXHZw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-94a341efd9aso1608439866b.0 for ; Mon, 15 May 2023 08:07:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684163242; x=1686755242; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:cc:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jqAunJggVfMk8DVsWWYkCIQsfbXlahXMSDO8JBjiKzE=; b=gvlWGw6Y7zqrQHeNrFfbYJUaitb3o69xj5fQuOFXEzZG6lzYzld62WY4QXT+eY3/xg LbOygI2bFB8a78Xi7RRh/fAtikqfgmkL/rZvSdanyMh3Y/KvBOlPeuXfNBZ68M6+dykn bwE4MnLtbUUIZ1ZN7aox9N02nrc0U1eOkCuVhEYDxsoQ0LL4r6XDQxxdvOrA9hLkuWmp D+T081Q5I8t/LwpovqhCxFMs9rRvL39cPHx/POX21wM92TPAE+aFZJ6OhqfvlHeLk7Up dzoykoxs2TV51Q7qG79opOD+WrPHqTeNHFG1k5Z5cJYWFq36jhxrLBxmgRBnDaX1BKQ1 pMRg== X-Gm-Message-State: AC+VfDz82M5gQ9YtPWhI4SuL2+hS/WAoMDKmM7778JJtZ5WXsxmjMewE 5fZNILQi/yLMASYmz4PBUdTAB9oHjJVU3DwMWeRTCxUS5IJZGqom02dUbH7cI2vbh/Rt/7oWR+c gsNkgarZH1C/m1nhUf6KL X-Received: by 2002:a17:907:d91:b0:933:4d37:82b2 with SMTP id go17-20020a1709070d9100b009334d3782b2mr31485018ejc.57.1684163242598; Mon, 15 May 2023 08:07:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4KJfmiDaL9BJh3jJxYB1OG8NuTPCjYqSvJHsOpWGNg4A0jTsW7kReLmT9LoGqXUg8hKEYa+Q== X-Received: by 2002:a17:907:d91:b0:933:4d37:82b2 with SMTP id go17-20020a1709070d9100b009334d3782b2mr31484980ejc.57.1684163242248; Mon, 15 May 2023 08:07:22 -0700 (PDT) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id l17-20020a170907915100b0095004c87676sm9682583ejs.199.2023.05.15.08.07.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 08:07:21 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Mon, 15 May 2023 17:07:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Larysa Zaremba , Stanislav Fomichev References: <20230512152607.992209-1-larysa.zaremba@intel.com> <20230512152607.992209-11-larysa.zaremba@intel.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 2BH65SR5RIDPWZCVEPENH2TLSHDOFBWK X-Message-ID-Hash: 2BH65SR5RIDPWZCVEPENH2TLSHDOFBWK X-MailFrom: jbrouer@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: brouer@redhat.com, bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Jakub Kicinski , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jiri Olsa , Jesse Brandeburg , Tony Nguyen , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH RESEND bpf-next 10/15] ice: Implement VLAN tag hint List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 15/05/2023 15.41, Larysa Zaremba wrote: >>> + *vlan_tag = ice_get_vlan_tag_from_rx_desc(xdp_ext->eop_desc); >> Should we also do the following: >> >> if (!*vlan_tag) >> return -ENODATA; >> >> ? > Oh, returning VLAN tag with zero value really made sense to me at the beginning, > but after playing with different kinds of packets, I think returning error makes > more sense. Will change. > IIRC then VLAN tag zero is also a valid id, right? --Jesper