XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Alexander Lobakin" <alexandr.lobakin@intel.com>,
	"Stanislav Fomichev" <sdf@google.com>
Cc: brouer@redhat.com, Martin KaFai Lau <martin.lau@linux.dev>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org,
	David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Magnus Karlsson <magnus.karlsson@gmail.com>,
	Maryam Tahhan <mtahhan@redhat.com>,
	xdp-hints@xdp-project.net, netdev@vger.kernel.org,
	bpf@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs
Date: Tue, 24 Jan 2023 13:23:49 +0100	[thread overview]
Message-ID: <da633a14-0d0e-0be3-6291-92313ab1550d@redhat.com> (raw)
In-Reply-To: <87lelsp2yl.fsf@toke.dk>


On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote:
> Alexander Lobakin <alexandr.lobakin@intel.com> writes:
> 
>> From: Stanislav Fomichev <sdf@google.com>
>> Date: Mon, 23 Jan 2023 10:55:52 -0800
>>
>>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>>>>
>>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote:
>>>>> Please see the first patch in the series for the overall
>>>>> design and use-cases.
>>>>>
>>>>> See the following email from Toke for the per-packet metadata overhead:
>>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
>>>>>
>>>>> Recent changes:
>>>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq)
>>>>>
>>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)
>>>>>
>>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper)
>>>>>
>>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper)
>>>>>
>>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead
>>>>>     of ifname (due to recent xsk.h refactoring)
>>>>
>>>> Applied with the minor changes in the selftests discussed in patch 11 and 17.
>>>> Thanks!
>>>
>>> Awesome, thanks! I was gonna resend around Wed, but thank you for
>>> taking care of that!
>> Great stuff, congrats! :)
> 
> Yeah! Thanks for carrying this forward, Stanislav! :)

+1000 -- great work everybody! :-)

To Alexander (Cc Jesse and Tony), do you think someone from Intel could
look at extending drivers:

  drivers/net/ethernet/intel/igb/ - chip i210
  drivers/net/ethernet/intel/igc/ - chip i225
  drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports

We have a customer that have been eager to get hardware RX-timestamping
for their AF_XDP use-case (PoC code[1] use software timestamping via
bpf_ktime_get_ns() today).  Getting driver support will qualify this
hardware as part of their HW solution.

--Jesper
[1] 
https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interaction/af_xdp_kern.c#L77


  reply	other threads:[~2023-01-24 12:23 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 22:15 [xdp-hints] " Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 01/17] bpf: Document XDP RX metadata Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 02/17] bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloaded Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 03/17] bpf: Move offload initialization into late_initcall Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 04/17] bpf: Reshuffle some parts of bpf/offload.c Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 05/17] bpf: Introduce device-bound XDP programs Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 06/17] selftests/bpf: Update expected test_offload.py messages Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 07/17] bpf: XDP metadata RX kfuncs Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 09/17] veth: Introduce veth_xdp_buff wrapper for xdp_buff Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 10/17] veth: Support RX XDP metadata Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 11/17] selftests/bpf: Verify xdp_metadata xdp->af_xdp path Stanislav Fomichev
2023-01-20 22:18   ` [xdp-hints] " Martin KaFai Lau
2023-01-20 22:48     ` Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 12/17] net/mlx4_en: Introduce wrapper for xdp_buff Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 13/17] net/mlx4_en: Support RX XDP metadata Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 14/17] xsk: Add cb area to struct xdp_buff_xsk Stanislav Fomichev
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 15/17] net/mlx5e: Introduce wrapper for xdp_buff Stanislav Fomichev
2023-01-22  7:01   ` [xdp-hints] " Tariq Toukan
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 16/17] net/mlx5e: Support RX XDP metadata Stanislav Fomichev
2023-01-20 22:37   ` [xdp-hints] " Martin KaFai Lau
2023-01-22  7:58   ` Tariq Toukan
2023-01-19 22:15 ` [xdp-hints] [PATCH bpf-next v8 17/17] selftests/bpf: Simple program to dump XDP RX metadata Stanislav Fomichev
2023-01-20 22:30   ` [xdp-hints] " Martin KaFai Lau
2023-01-20 22:48     ` Stanislav Fomichev
2023-01-24 15:25   ` Jesper Dangaard Brouer
2023-01-24 17:42     ` Stanislav Fomichev
2023-01-24 18:48       ` sdf
2023-01-25 15:10         ` Jesper Dangaard Brouer
2023-01-25 17:16           ` Stanislav Fomichev
2023-01-23 18:50 ` [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs patchwork-bot+netdevbpf
2023-01-23 18:53 ` Martin KaFai Lau
2023-01-23 18:55   ` Stanislav Fomichev
2023-01-24 11:17     ` Alexander Lobakin
2023-01-24 11:49       ` Toke Høiland-Jørgensen
2023-01-24 12:23         ` Jesper Dangaard Brouer [this message]
2023-01-24 17:35           ` Stanislav Fomichev
2023-02-02 15:08           ` Alexander Lobakin
2023-02-02 15:52             ` Song, Yoong Siang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da633a14-0d0e-0be3-6291-92313ab1550d@redhat.com \
    --to=jbrouer@redhat.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrii@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=haoluo@google.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=mtahhan@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=toke@redhat.com \
    --cc=willemb@google.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox