From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id 5798E9FABA2 for ; Sat, 1 Apr 2023 18:47:13 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cjVNKent DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680367632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBpaj6qPaiWPsqZ1uUbFmrrkbOrpiff0SRgLWvVlle4=; b=cjVNKentMqpysrTQKPjt/qNX2JtF2w9kMPAdhc4tlXnx+jDcBlxAzevVPulUuz/JMmLMWv WeN12HzEMz1PzTxsWMz3/XNGaY8L3Xy6YX/9T6f27rTD+RdC3XPWxN2Gtqfq4ZaX60pCGw eyc8NH/jmlrWYY0DQd68NfSKlp4lkIM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-9SJhj8GcOk2aL3ua8plEoQ-1; Sat, 01 Apr 2023 12:47:10 -0400 X-MC-Unique: 9SJhj8GcOk2aL3ua8plEoQ-1 Received: by mail-lf1-f70.google.com with SMTP id d23-20020a193857000000b004e9d2af9e57so9978172lfj.23 for ; Sat, 01 Apr 2023 09:47:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680367629; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LBpaj6qPaiWPsqZ1uUbFmrrkbOrpiff0SRgLWvVlle4=; b=vRV7vzreV5GJLHom7QsKeqf8MudRybBisVf6omWG+iEVEHbNNAxZsrQGjb+lIPuCY7 9qhvisRmqEI6dTrLFXEvdbQTc+CG0mvSCvq9Y8XHJEcC5tSyiG2G92rM9ImZ/5CuAUD6 33koUePX5Pw8znfMCOGyuznZ6gCpynuyxOS1Q3uR9MzIRhjdBYCIYnniholJa9WThyyt NFVn2nl0P7cYOlbfpjnmbEbKkleMh+XJeRqfiL9lENussWB9MdP4GA5kyN5sJ9IYo4YU PLJogUN4c6xzCa3CO/niyXa6teewRBBm7Gnyvh8Fn98djM/9xrrrpiQ4JCvYB+r1P5t1 zSXw== X-Gm-Message-State: AAQBX9dyzaUcnGcCUaBiao4Az4UN/IGQRKmskpzWAJ+owlzXLoJTttq6 l2JI5Jq2qNa20ZdkRikzy5DjswgfVQZhlzrgZCJRnafgzFSlatiy/KBw8zhSo8fOqOWq7lY1rgX y3zKuOGHNyCeZb9PNYXXC X-Received: by 2002:a2e:6e03:0:b0:299:aa20:22a0 with SMTP id j3-20020a2e6e03000000b00299aa2022a0mr9388793ljc.53.1680367629421; Sat, 01 Apr 2023 09:47:09 -0700 (PDT) X-Google-Smtp-Source: AKy350ZeSpF555yFlSRJ624wPZzgJmZWz4p4qwCgGBnis2x24ag2kBhUEet5FQWdzvm7DiW1qPj20Q== X-Received: by 2002:a2e:6e03:0:b0:299:aa20:22a0 with SMTP id j3-20020a2e6e03000000b00299aa2022a0mr9388764ljc.53.1680367629089; Sat, 01 Apr 2023 09:47:09 -0700 (PDT) Received: from [192.168.42.100] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id y17-20020a2eb011000000b002a5f554d263sm887063ljk.46.2023.04.01.09.47.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 09:47:08 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Sat, 1 Apr 2023 18:47:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: bpf@vger.kernel.org, Stanislav Fomichev , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <168028882260.4030852.1100965689789226162.stgit@firesoul> In-Reply-To: <168028882260.4030852.1100965689789226162.stgit@firesoul> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: NGM7YU5HWDQ4TBISNHYCW3D3EIKM37SL X-Message-ID-Hash: NGM7YU5HWDQ4TBISNHYCW3D3EIKM37SL X-MailFrom: jbrouer@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: brouer@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net, tariqt@nvidia.com X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf V5 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Why have this patchset[1] been marked "Changes Requested" ? Notice: The BPF test_progs are failing on "xdp_do_redirect", but that is not related to this patchset as it already happens on a clean bpf-tree. [1] https://patchwork.kernel.org/project/netdevbpf/list/?series=735957&state=%2A On 31/03/2023 20.54, Jesper Dangaard Brouer wrote: > Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value, > but doesn't provide information on the RSS hash type (part of 6.3-rc). > > This patchset proposal is to change the function call signature via adding > a pointer value argument for providing the RSS hash type. > > --- > V5: > - Fixes for checkpatch.pl > - Change function signature for all xmo_rx_hash calls in patch1 > > Jesper Dangaard Brouer (5): > xdp: rss hash types representation > mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type > veth: bpf_xdp_metadata_rx_hash add xdp rss hash type > mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type > selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg > > > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++- > drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +- > .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++- > drivers/net/veth.c | 10 ++- > include/linux/mlx5/device.h | 14 ++++- > include/linux/netdevice.h | 3 +- > include/net/xdp.h | 47 ++++++++++++++ > net/core/xdp.c | 10 ++- > .../selftests/bpf/prog_tests/xdp_metadata.c | 2 + > .../selftests/bpf/progs/xdp_hw_metadata.c | 14 +++-- > .../selftests/bpf/progs/xdp_metadata.c | 6 +- > .../selftests/bpf/progs/xdp_metadata2.c | 7 ++- > tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- > tools/testing/selftests/bpf/xdp_metadata.h | 1 + > 14 files changed, 180 insertions(+), 24 deletions(-) > > -- >