From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: "Alexander Lobakin" <alexandr.lobakin@intel.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: brouer@redhat.com, John Fastabend <john.fastabend@gmail.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
Ederson Desouza <ederson.desouza@intel.com>,
"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>,
Eelco Chaudron <echaudro@redhat.com>,
Andrii Nakryiko <andrii@kernel.org>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [xdp-hints] Re: XDP-hints via local BTF info
Date: Wed, 24 Nov 2021 12:54:00 +0100 [thread overview]
Message-ID: <cce1da96-1ead-8273-76d9-0afeaf269f6b@redhat.com> (raw)
In-Reply-To: <20211122125703.23829-1-alexandr.lobakin@intel.com>
On 22/11/2021 13.57, Alexander Lobakin wrote:
> From: Toke Høiland-Jørgensen <toke@redhat.com> Date: Fri, 19 Nov 2021
> 15:53:39 +0100
>
>> Just a few additional comments, as I think y'all mostly covered
>> everything:
>
> Just wanted to say that I've almost finished my iteration with cpumap
> and veth covered.
What does this mean?
Can you consume XDP-hints in cpumap and veth, and transfer that to the
SKB fields? (I'm very interested in this).
> I'll commit the current snapshot during the next three days ([0]). I
> also wanted to include GRO for cpumap into this first series, but not
> sure if it really belongs to it. WDYGT?
Everybody seems eager to hijack the thread subject :-P
When introducing/proposing kernel changes, the discussion belong on the
mailing-list bpf@vger.kernel.org.
> [ snip ]
>
> [0] https://github.com/alobakin/linux
Kernel changes are usually send as (RFC) patches in the mailing list.
If you want to share kernel changes via GitHub, please create a branch,
and please avoid rebasing once shared. I usually version my branches
via a descriptive-name plus an increasing number, so reviewers know
which branch is the latest code iteration.
It is unusual, but we can collaborate on kernel changes via GitHub. I've
only done with changes that are not ready for upstream submission yet,
and as part of a (1-to-1) review over IRC (with co-workers).
I'm not sure how you expect people to help you review[0] this?
--Jesper
next prev parent reply other threads:[~2021-11-24 11:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 17:22 [xdp-hints] " Jesper Dangaard Brouer
2021-11-17 20:07 ` [xdp-hints] " Karlsson, Magnus
2021-11-17 22:48 ` Toke Høiland-Jørgensen
2021-11-18 8:05 ` Karlsson, Magnus
2021-11-18 14:30 ` Jesper Dangaard Brouer
2021-11-18 14:57 ` Karlsson, Magnus
2021-11-18 15:18 ` John Fastabend
2021-11-19 14:53 ` Toke Høiland-Jørgensen
2021-11-22 12:45 ` [xdp-hints] Basic/Dumb question WAS(Re: " Jamal Hadi Salim
2021-11-22 13:59 ` [xdp-hints] " Toke Høiland-Jørgensen
2021-11-22 15:31 ` Tom Herbert
2021-11-22 18:25 ` Toke Høiland-Jørgensen
2021-11-22 12:57 ` [xdp-hints] " Alexander Lobakin
2021-11-24 11:54 ` Jesper Dangaard Brouer [this message]
2021-11-25 20:04 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce1da96-1ead-8273-76d9-0afeaf269f6b@redhat.com \
--to=jbrouer@redhat.com \
--cc=alexandr.lobakin@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=brouer@redhat.com \
--cc=echaudro@redhat.com \
--cc=ederson.desouza@intel.com \
--cc=john.fastabend@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=toke@redhat.com \
--cc=xdp-hints@xdp-project.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox