From: Stanislav Fomichev <stfomichev@gmail.com>
To: tianmuyang <tianmuyang@huawei.com>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"larysa.zaremba@intel.com" <larysa.zaremba@intel.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
"martin.lau@linux.dev" <martin.lau@linux.dev>,
"song@kernel.org" <song@kernel.org>, "yhs@fb.com" <yhs@fb.com>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"kpsingh@kernel.org" <kpsingh@kernel.org>,
"sdf@google.com" <sdf@google.com>,
"haoluo@google.com" <haoluo@google.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"dsahern@gmail.com" <dsahern@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"willemb@google.com" <willemb@google.com>,
"brouer@redhat.com" <brouer@redhat.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"alexandr.lobakin@intel.com" <alexandr.lobakin@intel.com>,
"magnus.karlsson@gmail.com" <magnus.karlsson@gmail.com>,
"mtahhan@redhat.com" <mtahhan@redhat.com>,
"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"Yanan (Euler)" <yanan@huawei.com>,
"Wuchangye (EulerOS)" <wuchangye@huawei.com>,
Xiesongyang <xiesongyang@huawei.com>,
"Liuxin(EulerOS)" <liuxin350@huawei.com>,
"zhangmingyi (C)" <zhangmingyi5@huawei.com>,
"liwei (H)" <liwei883@huawei.com>
Subject: [xdp-hints] Re: Questions about XDP hints
Date: Mon, 14 Oct 2024 11:09:41 -0700 [thread overview]
Message-ID: <Zw1eZQJG3EMz5ADv@mini-arch> (raw)
In-Reply-To: <90c1c6b53a654cf197eb412917fad31a@huawei.com>
On 10/12, tianmuyang wrote:
> Hi all:
> There has been some discussions about adding checksum hint in AF_XDP such as this thread[1]. Now, we also plan to add checksum hint. My questions are:
> 1. In this msg[2], is it appropriate if xdp_csum_status only includes 4 enums/macros(CHECKSUM_NONE...CHECKSUM_PARTIAL in skbuff.h)? Thus it becomes more generic. Also, in this msg[3] we can simply pass skb->ip_summed to csum_status in veth_xdp_rx_csum().
> 2. What should be taken care of if I want to add a new hint? IOW, what is acceptable to add a new hint?
There is no clear guidance on what's acceptable and what's not. Each
hint it evaluated case by case. IIRC, last time rx csum discussion
stalled due to disagreement about the level of details which should
be exposed from the generic kfuncs. Feel free to revive the discussion
with another patchset.
Regarding (1): the consensus seems to be (IIRC) is to expose tree cases
only: no-csum, csum-unnecessary, csum-complete+csum. Anything else
gets too device specific and too convoluted to handle on the xdp prog
side.
> Thanks!
>
> [1] https://lore.kernel.org/bpf/CAADnVQJPgpo7J0qVTQJYYocZ=Jnw=O5GfN2=PyAQ55+WWG_DVg@mail.gmail.com/
> [2] https://lore.kernel.org/bpf/20230728173923.1318596-13-larysa.zaremba@intel.com/
> [3] https://lore.kernel.org/bpf/20230728173923.1318596-18-larysa.zaremba@intel.com/
>
prev parent reply other threads:[~2024-10-14 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 7:12 [xdp-hints] " tianmuyang
2024-10-14 18:09 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw1eZQJG3EMz5ADv@mini-arch \
--to=stfomichev@gmail.com \
--cc=alexandr.lobakin@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=liuxin350@huawei.com \
--cc=liwei883@huawei.com \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=simon.horman@corigine.com \
--cc=song@kernel.org \
--cc=tianmuyang@huawei.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wuchangye@huawei.com \
--cc=xdp-hints@xdp-project.net \
--cc=xiesongyang@huawei.com \
--cc=yanan@huawei.com \
--cc=yhs@fb.com \
--cc=zhangmingyi5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox