From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id DA9F2A8040E for ; Sat, 10 Aug 2024 10:00:46 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JBLGu17y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723276845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cxaBsOWYXbQjl952d0wR8HU0oXx4pPetERcANE2n4pw=; b=JBLGu17y9ofecNJCfnMNBNIC/ao+cQfV/7MNBaNk8Ca9qN+pj+9ua9QEbMeLM2REQlCIL9 2J0c5xqo4ATFodZaoqCe+yTkWI6AyrRoZlL7TFW6pK+VYqA4vDjUlE0iLZvCNSE28HlJ/J w02XSAuHRQEROcyk6wSl/nJgHTtNNJI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-8dcWpzK8ML2nNWXe6VzYXQ-1; Sat, 10 Aug 2024 04:00:42 -0400 X-MC-Unique: 8dcWpzK8ML2nNWXe6VzYXQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ef31dbc770so26378121fa.1 for ; Sat, 10 Aug 2024 01:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723276841; x=1723881641; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cxaBsOWYXbQjl952d0wR8HU0oXx4pPetERcANE2n4pw=; b=AbDq1W3rV/b4prK6lONOFiCRT1+jHJIG5iQqa0MtzUT+zIJwW0LiHu3UYiJVT1/JFn AP5iwc7BWFv11gzzz9K1rsqd4Fs2F6UXSlSJFIJVLVh0ztCmo+bXONEyjX+rfqE2paiO RC9vK34w7bZDuVA/DBHwUF52YoiCDNY0+BQBsCmf7tW1XoMMOKxaROrucJ3a0dKmT0/m /STNldi4p+2Lv0t+B3hoqZmU+0gduLEgp2Iw0ZarGA11BnFHp12S6+1TISKv5gK7xBqa WPO+HpsnIfPMDbMTeTGTANFjmBbECJqtgRmuipRvE4EcN20ZVjcRuTfM7/DlK5sJR78u n17g== X-Forwarded-Encrypted: i=1; AJvYcCUsuyS/seJ0q2PmLaC0bN3CqhUJwLG4vhFv77huKTXK4pz5GJ6mKr2vbuoDwqMsKDoG6OBG5MvuScIfOxo8I8dnrCzpYeDzPXUJ X-Gm-Message-State: AOJu0YwUaHqvcXCCNtsUfgiudAtd+i36kfMh/RlIViUgaiVGA7xpVHen t0/9n3X2srccwLxnWLV7dY1zdP4907y0lFO8tkcC7+M6uMzJJxtbriuSNj2gYH5SMIDamPOZlC4 9TFEZK1PlodwrkAKpBJ+K7TrIqtZmcz/bddldnKYmxSogtx2VJ19WC/jk1w== X-Received: by 2002:a2e:be9d:0:b0:2f0:20cd:35fc with SMTP id 38308e7fff4ca-2f1a6c4cf01mr33426531fa.7.1723276840293; Sat, 10 Aug 2024 01:00:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHm7k8IUz5d3cudToCANSXgZtSllkVKwZwQhLwKqQ43m1YO/m1NdkmZJerxkfQZ0JUye0k27A== X-Received: by 2002:a2e:be9d:0:b0:2f0:20cd:35fc with SMTP id 38308e7fff4ca-2f1a6c4cf01mr33426271fa.7.1723276839630; Sat, 10 Aug 2024 01:00:39 -0700 (PDT) Received: from localhost (53.116.107.80.static.otenet.gr. [80.107.116.53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429c7736b05sm19723545e9.29.2024.08.10.01.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Aug 2024 01:00:39 -0700 (PDT) Date: Sat, 10 Aug 2024 10:00:36 +0200 From: Lorenzo Bianconi To: Alexander Lobakin Message-ID: References: <20220628194812.1453059-1-alexandr.lobakin@intel.com> <20220628194812.1453059-33-alexandr.lobakin@intel.com> <54aab7ec-80e9-44fd-8249-fe0cabda0393@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3tjfGVd/eoZK+rGd" Content-Disposition: inline In-Reply-To: <54aab7ec-80e9-44fd-8249-fe0cabda0393@intel.com> Message-ID-Hash: RPUTGXP5MHGH33H3OFKYKEBPWPHWRBAU X-Message-ID-Hash: RPUTGXP5MHGH33H3OFKYKEBPWPHWRBAU X-MailFrom: lorenzo.bianconi@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Daniel Xu , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Larysa Zaremba , Michal Swiatkowski , Jesper Dangaard Brouer , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "toke@redhat.com" , Lorenzo Bianconi , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , John Fastabend , Yajun Deng , Willem de Bruijn , "bpf@vger.kernel.org" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.9 Precedence: list Subject: [xdp-hints] Re: [PATCH RFC bpf-next 32/52] bpf, cpumap: switch to GRO from netif_receive_skb_list() List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3tjfGVd/eoZK+rGd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Aug 08, Alexander Lobakin wrote: > From: Lorenzo Bianconi > Date: Thu, 8 Aug 2024 06:54:06 +0200 >=20 > >> Hi Alexander, > >> > >> On Tue, Jun 28, 2022, at 12:47 PM, Alexander Lobakin wrote: > >>> cpumap has its own BH context based on kthread. It has a sane batch > >>> size of 8 frames per one cycle. > >>> GRO can be used on its own, adjust cpumap calls to the > >>> upper stack to use GRO API instead of netif_receive_skb_list() which > >>> processes skbs by batches, but doesn't involve GRO layer at all. > >>> It is most beneficial when a NIC which frame come from is XDP > >>> generic metadata-enabled, but in plenty of tests GRO performs better > >>> than listed receiving even given that it has to calculate full frame > >>> checksums on CPU. > >>> As GRO passes the skbs to the upper stack in the batches of > >>> @gro_normal_batch, i.e. 8 by default, and @skb->dev point to the > >>> device where the frame comes from, it is enough to disable GRO > >>> netdev feature on it to completely restore the original behaviour: > >>> untouched frames will be being bulked and passed to the upper stack > >>> by 8, as it was with netif_receive_skb_list(). > >>> > >>> Signed-off-by: Alexander Lobakin > >>> --- > >>> kernel/bpf/cpumap.c | 43 ++++++++++++++++++++++++++++++++++++++----- > >>> 1 file changed, 38 insertions(+), 5 deletions(-) > >>> > >> > >> AFAICT the cpumap + GRO is a good standalone improvement. I think > >> cpumap is still missing this. >=20 > The only concern for having GRO in cpumap without metadata from the NIC > descriptor was that when the checksum status is missing, GRO calculates > the checksum on CPU, which is not really fast. > But I remember sometimes GRO was faster despite that. For the moment we could test it with UDP traffic with checksum disabled. Regards, Lorenzo >=20 > >> > >> I have a production use case for this now. We want to do some intellig= ent > >> RX steering and I think GRO would help over list-ified receive in some= cases. > >> We would prefer steer in HW (and thus get existing GRO support) but no= t all > >> our NICs support it. So we need a software fallback. > >> > >> Are you still interested in merging the cpumap + GRO patches? >=20 > For sure I can revive this part. I was planning to get back to this > branch and pick patches which were not related to XDP hints and send > them separately. >=20 > >=20 > > Hi Daniel and Alex, > >=20 > > Recently I worked on a PoC to add GRO support to cpumap codebase: > > - https://github.com/LorenzoBianconi/bpf-next/commit/a4b8264d5000ecf016= da5a2dd9ac302deaf38b3e > > Here I added GRO support to cpumap through gro-cells. > > - https://github.com/LorenzoBianconi/bpf-next/commit/da6cb32a4674aa7240= 1c7414c9a8a0775ef41a55 > > Here I added GRO support to cpumap trough napi-threaded APIs (with a = some > > changes to them). >=20 > Hmm, when I was testing it, adding a whole NAPI to cpumap was sorta > overkill, that's why I separated GRO structure from &napi_struct. >=20 > Let me maybe find some free time, I would then test all 3 solutions > (mine, gro_cells, threaded NAPI) and pick/send the best? >=20 > >=20 > > Please note I have not run any performance tests so far, just verified = it does > > not crash (I was planning to resume this work soon). Please let me know= if it > > works for you. > >=20 > > Regards, > > Lorenzo > >=20 > >> > >> Thanks, > >> Daniel >=20 > Thanks, > Olek >=20 --3tjfGVd/eoZK+rGd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZrceIQAKCRA6cBh0uS2t rAuOAP9lAP+wUtI4DT03vstan8oVHlFYyfbFpQ5S9GXv19t6iQD+Oq31gcfUQN93 0x2SbfWudVdpE9DvTKzXi6mE/f29ZAc= =6Wya -----END PGP SIGNATURE----- --3tjfGVd/eoZK+rGd--