From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
haoluo@google.com, jolsa@kernel.org,
David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Maryam Tahhan <mtahhan@redhat.com>,
xdp-hints@xdp-project.net, netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [xdp-hints] Re: [PATCH bpf-next v7 17/18] selftests/bpf: Use AF_INET for TX in xdp_metadata
Date: Tue, 21 Nov 2023 10:02:06 +0100 [thread overview]
Message-ID: <ZVxyDhqz4mBZwIpl@lzaremba-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <170051500599.3770946.2674696540245347885@gauss.local>
On Mon, Nov 20, 2023 at 01:15:41PM -0800, Stanislav Fomichev via xdp-hints wrote:
> Date: Mon, 20 Nov 2023 13:15:41 -0800
> From: Stanislav Fomichev <sdf@google.com>
> To: Larysa Zaremba <larysa.zaremba@intel.com>
> CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
> andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
> john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com,
> jolsa@kernel.org, David Ahern <dsahern@gmail.com>, Jakub Kicinski
> <kuba@kernel.org>, Willem de Bruijn <willemb@google.com>, Jesper Dangaard
> Brouer <hawk@kernel.org>, Anatoly Burakov <anatoly.burakov@intel.com>,
> Alexander Lobakin <alexandr.lobakin@intel.com>, Magnus Karlsson
> <magnus.karlsson@gmail.com>, Maryam Tahhan <mtahhan@redhat.com>,
> xdp-hints@xdp-project.net, netdev@vger.kernel.org, Willem de Bruijn
> <willemdebruijn.kernel@gmail.com>, Alexei Starovoitov
> <alexei.starovoitov@gmail.com>, Tariq Toukan <tariqt@mellanox.com>, Saeed
> Mahameed <saeedm@mellanox.com>, Maciej Fijalkowski
> <maciej.fijalkowski@intel.com>
> Subject: [xdp-hints] Re: [PATCH bpf-next v7 17/18] selftests/bpf: Use
> AF_INET for TX in xdp_metadata
>
> On 11/15, Larysa Zaremba wrote:
> > The easiest way to simulate stripped VLAN tag in veth is to send a packet
> > from VLAN interface, attached to veth. Unfortunately, this approach is
> > incompatible with AF_XDP on TX side, because VLAN interfaces do not have
> > such feature.
> >
> > Replace AF_XDP packet generation with sending the same datagram via
> > AF_INET socket.
> >
> > This does not change the packet contents or hints values with one notable
> > exception: rx_hash_type, which previously was expected to be 0, now is
> > expected be at least XDP_RSS_TYPE_L4.
>
> Btw, I've been thinking a bit about how we can make this test work for both
> your VLANs and my upcoming af_xdp tx side. And seems like the best
> way, probably, is to have two tx paths exercised: veth and af_xdp.
> For veth, we'll verify everything+vlans, for af_xdp we'll verify
> everything except the vlans.
>
> Originally I was assuming that I'll switch this part back to af_xdp, but
> I don't think having tx vlan offload makes sense (because af_xdp
> userspace can just prepare the correct header from the start).
>
> So if you're doing a respin, maybe see if we can keep af_xdp tx part
> but make it skip the vlans verification?
>
> generate_packet_af_xdp();
> verify_xsk_metadata(/*verify_vlans=*/false);
> geenrate_packet_veth();
> verify_xsk_metadata(/*verify_vlans=*/true);
>
> ?
Sounds good to me, will do so.
next prev parent reply other threads:[~2023-11-21 9:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:52 [xdp-hints] [PATCH bpf-next v7 00/18] XDP metadata via kfuncs for ice + VLAN hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 01/18] ice: make RX hash reading code more reusable Larysa Zaremba
2023-11-16 15:04 ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 02/18] ice: make RX HW timestamp " Larysa Zaremba
2023-11-16 15:19 ` [xdp-hints] " Maciej Fijalkowski
2023-11-17 14:26 ` Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 03/18] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 04/18] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-11-16 12:52 ` [xdp-hints] " Maciej Fijalkowski
2023-11-16 2:55 ` Larysa Zaremba
2023-12-01 13:51 ` Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 05/18] ice: Support HW timestamp hint Larysa Zaremba
2023-11-16 15:21 ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 06/18] ice: Support RX hash XDP hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 07/18] xsk: add functions to fill control buffer Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 08/18] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-11-16 12:49 ` [xdp-hints] " Maciej Fijalkowski
2023-11-16 3:01 ` Larysa Zaremba
2023-11-16 15:01 ` Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 09/18] xdp: Add VLAN tag hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 10/18] ice: Implement " Larysa Zaremba
2023-11-16 15:47 ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 11/18] ice: use VLAN proto from ring packet context in skb path Larysa Zaremba
2023-11-17 8:10 ` [xdp-hints] " Maciej Fijalkowski
2023-11-17 14:07 ` Larysa Zaremba
2023-11-17 15:14 ` Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 12/18] veth: Implement VLAN tag XDP hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 13/18] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 14/18] mlx5: implement VLAN tag XDP hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 15/18] selftests/bpf: Allow VLAN packets in xdp_hw_metadata Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 16/18] selftests/bpf: Add flags and VLAN hint to xdp_hw_metadata Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 17/18] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-11-20 21:15 ` [xdp-hints] " Stanislav Fomichev
[not found] ` <170051500599.3770946.2674696540245347885@gauss.local>
2023-11-21 9:02 ` Larysa Zaremba [this message]
2023-11-15 17:53 ` [xdp-hints] [PATCH bpf-next v7 18/18] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVxyDhqz4mBZwIpl@lzaremba-mobl.ger.corp.intel.com \
--to=larysa.zaremba@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tariqt@mellanox.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xdp-hints@xdp-project.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox