From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by mail.toke.dk (Postfix) with ESMTPS id 25C38A34E56 for ; Mon, 23 Oct 2023 20:38:35 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=ewYL6QHi Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d9a581346c4so3422704276.0 for ; Mon, 23 Oct 2023 11:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698086298; x=1698691098; darn=xdp-project.net; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=psPIDexlmbx2oQKoywMWkukSVUBQPWpjMzsLgIAN/3Q=; b=ewYL6QHimvi0T8Ccoeps3jK4aZuJLXD3HjeYWT0yv1jS/o3H0rkjDdf2v3kuJNhviw j05RVcVkQ6LiP+rauawcDsYiOEbQY122vwx36CylGgJRI9HP2eG4rfVE69bYGcxvpifb rjYmGguusbNlLiGo5eGwkg3SlRgA15bZ1mRjk3hPyUm+gWW8XVsS+sxY2Zl+rkFvGAco CGwg3RsnoSy7m/+PEbs+vkYdYwLZkkEU2CiABrYGeX1EnxBdxlE0sNsvRHb4r3CL8PgD FsB01oNO3x07cv3B5ZKx00QFrdBDAWMtSHOP7fnqve52YmfiHq1YxPWVEfdYT2rYF5I2 N38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698086298; x=1698691098; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=psPIDexlmbx2oQKoywMWkukSVUBQPWpjMzsLgIAN/3Q=; b=exRJLHVvAjvC3ipj2GyN5HubMyTermWu0JIm5bpMlHh1dKdqO6JVHA13i4LsqBW7sz +LE/XS3mOE/8tBIBBhFdqTgtdSDwLNccZbuQ0CUwF+s8XVd+OxOJ8VTq1EWAbw6phwsb p2kciswK6Zq2ISZX1zrAJCz88Sryj1yCZRZ3IHbIe9ldyvTqZzIbk+TzgEz3hlEAD9LC eBADDRGVfDrOupT26ILV8IN/Hi/8+IXaYhGlkzpm54K8Adz0TfKVvXYYAGo2sQYgSuBK 0G1BArLE7Udt7DH9U8oI+k7vLYq3Ne/uxkAp9K89QQASJ41+U50O7EuBu3H0NIASN6AR UShg== X-Gm-Message-State: AOJu0YyEV3clH3JuDA6gKzt3IlwzQfwI8No6vguMN6x3liPkeFgjHVT3 kjWlltrI2LEwwfVbysn1xzhWhcw= X-Google-Smtp-Source: AGHT+IGSN2dlPUz4dYZ0sD/eg33lpIQ0p1bO+6bqKeVaG96gSQUEbAc0EauDKMZ5jFi/sXX6twYdvxM= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a25:c7d2:0:b0:c78:c530:6345 with SMTP id w201-20020a25c7d2000000b00c78c5306345mr169998ybe.7.1698086298615; Mon, 23 Oct 2023 11:38:18 -0700 (PDT) Date: Mon, 23 Oct 2023 11:38:16 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231019174944.3376335-1-sdf@google.com> Message-ID: From: Stanislav Fomichev To: Magnus Karlsson Content-Type: text/plain; charset="utf-8" Message-ID-Hash: ZYG3MEDARV5ZUKG3EZG6TUTYGZ3CJHLB X-Message-ID-Hash: ZYG3MEDARV5ZUKG3EZG6TUTYGZ3CJHLB X-MailFrom: 3mr02ZQMKCSEPACDLLDIB.9LJUAM-EFKQPUAM-MOLGB9Q.KBQ@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, kuba@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, maciej.fijalkowski@intel.com, hawk@kernel.org, yoong.siang.song@intel.com, netdev@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v4 00/11] xsk: TX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/23, Magnus Karlsson wrote: > On Thu, 19 Oct 2023 at 19:49, Stanislav Fomichev wrote: > > > > This series implements initial TX metadata (offloads) for AF_XDP. > > See patch #2 for the main implementation and mlx5/stmmac ones for the > > example on how to consume the metadata on the device side. > > > > Starting with two types of offloads: > > - request TX timestamp (and write it back into the metadata area) > > - request TX checksum offload > > > > Changes since v3: > > - fix xsk_tx_metadata_ops kdoc (Song Yoong Siang) > > - add missing xsk_tx_metadata_to_compl for XDP_SOCKETS=n (Vinicius Costa Gomes and Intel bots) > > - add reference timestamps to the selftests + refactor existing ones (Jesper) > > > > v3: https://lore.kernel.org/bpf/20231003200522.1914523-1-sdf@google.com/ > > Thanks for working on this Stanislav. I went through the patch set and > it looks good to me. You have addressed all the feedback that Maciej > and I had on a previous version. Just had some small things in two of > the patches. Apart from that, you are good to go and you can add my > ack to the next version. > > Acked-by: Magnus Karlsson > > Again, really appreciate all your work with this! Thank you! Appreciate the review and comments as well!