From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by mail.toke.dk (Postfix) with ESMTPS id 0CD8CA2E195 for ; Tue, 3 Oct 2023 18:10:31 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=KlqtvBCX Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-58530660c1bso743015a12.1 for ; Tue, 03 Oct 2023 09:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696349397; x=1696954197; darn=xdp-project.net; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=fMNd5cy+iJOW1gFpgN/QZ1aYRGnrlEzRG0+fZIEWVq4=; b=KlqtvBCXRcIigsaWG2fKMpWreniRCfrJkn4HfQHBShworcL4lZCjSkxWNaAihzJ9Pw izz9OaPFR2Z/43a9jgxoLKVEPkTl0zW3NS3VaOXWopwzHF1lLF0WM5uuzquN9mdyZmpA NQsOPPGykXC9oTWpRb25mKcinG32ISkQsgjXpFMEQRO/cq6EwcFTZ8cz68p+mwudufhE 7jd6tOzaDXkEAvblM6i/Vl6nGUlB+kxNidJAkpW7zweMFTlXZNyYtXD45mkpKzw1Z+VI O/VtQYKz5KYcvShNnancPDUBwn9D26ERQ0dTvahmiSB223obOFKPm1/gIA9l/cw7hUot +TcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696349397; x=1696954197; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fMNd5cy+iJOW1gFpgN/QZ1aYRGnrlEzRG0+fZIEWVq4=; b=W6F6TrM1uZs5EYPAjNQyz0suu2CPJxGwJy3UQQzqj+R4iEfTlWICoST+pp7FAGd9TU bwvfU1Frw+qzyDSnQ1U0SaESRi7A+LE//jloi8La6UZ8Yz1TFLPG1kyWNbqxfWEiaQAb ayohVrZuGnaN98FmQ8pE6jE5yJGhMe+f+ul6wbmckwhTy0izKfMS/Da+7Yc8QJNLikWN 8AkUa5zIEUbNiHNGOGPxVuIUyShRugA0W8Zhp09FNXni/+BiO6LZkxm1rzEXbeOr3wHO S6E5xi1I8XQRAeLAVJe88MU7hKPG9AhxfBbzebws4WlrN/UEYVhRslESfM6XtKrNZ2ZR dhLg== X-Gm-Message-State: AOJu0Yzv1VwRUmZtYEFeiGL08J1wdt//v31/nBx9cFsrY9Wmdi3MdOqy s3JC9G9AZCfSC4krdSn2wMK+hKo= X-Google-Smtp-Source: AGHT+IFUI/zSRouM2YNJLSf/d4E6lhAcKza+USPolB7JhkwY/YXDC9+n+f30QlKeQNyx/U9ERtAAlk4= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a63:294a:0:b0:57a:32e7:3240 with SMTP id bu10-20020a63294a000000b0057a32e73240mr224124pgb.5.1696349397201; Tue, 03 Oct 2023 09:09:57 -0700 (PDT) Date: Tue, 3 Oct 2023 09:09:55 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231002162653.297318-1-larysa.zaremba@intel.com> Message-ID: From: Stanislav Fomichev To: Larysa Zaremba Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CGNLWQK3G2QN5GTJ4MU6LKC2WG2EIE2Y X-Message-ID-Hash: CGNLWQK3G2QN5GTJ4MU6LKC2WG2EIE2Y X-MailFrom: 31TwcZQMKCe4iTVWeeWbU.SecnTf-XYdjinTf-fheZUSj.dUj@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next] selftests/bpf: add options and ZC mode to xdp_hw_metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/03, Larysa Zaremba wrote: > On Mon, Oct 02, 2023 at 09:46:08AM -0700, Stanislav Fomichev wrote: > > On Mon, Oct 2, 2023 at 9:35=E2=80=AFAM Larysa Zaremba wrote: > > > > > > By default, xdp_hw_metadata runs in AF_XDP copy mode. However, hints = are > > > also supposed to be supported in ZC mode, which is usually implemente= d > > > separately in driver, and so needs to be tested too. > > > > > > Add an option to run xdp_hw_metadata in ZC mode. > > > > > > As for now, xdp_hw_metadata accepts no options, so add simple option > > > parsing logic and a help message. > > > > > > For quick reference, also add an ingress packet generation command to= the > > > help message. The command comes from [0]. > > > > > > [0] https://lore.kernel.org/all/20230119221536.3349901-18-sdf@google.= com/ > >=20 > > I did similar changes in my pending [0], but I made the zerocopy, not > > the copy mode, the default. > > If you want to get this in faster (my series will probably need > > another iteration), let's maybe do the same here? > > ZC as a default feels better. > >=20 > > 0: https://lore.kernel.org/bpf/20230914210452.2588884-9-sdf@google.com/ >=20 > I do not need those changes in tree ASAP, that is just something I had lo= cally=20 > for some time and decided to send. So I think I can wait for your series.= This=20 > way it is less work for both of us. SGTM, thanks!