From: Stanislav Fomichev <sdf@google.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
haoluo@google.com, jolsa@kernel.org,
David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Maryam Tahhan <mtahhan@redhat.com>,
xdp-hints@xdp-project.net, netdev@vger.kernel.org
Subject: [xdp-hints] Re: [PATCH bpf-next] selftests/bpf: add options and ZC mode to xdp_hw_metadata
Date: Tue, 3 Oct 2023 09:09:55 -0700 [thread overview]
Message-ID: <ZRw804r4JM3vTCDH@google.com> (raw)
In-Reply-To: <ZRu4OJMAOApPsoVx@lincoln>
On 10/03, Larysa Zaremba wrote:
> On Mon, Oct 02, 2023 at 09:46:08AM -0700, Stanislav Fomichev wrote:
> > On Mon, Oct 2, 2023 at 9:35 AM Larysa Zaremba <larysa.zaremba@intel.com> wrote:
> > >
> > > By default, xdp_hw_metadata runs in AF_XDP copy mode. However, hints are
> > > also supposed to be supported in ZC mode, which is usually implemented
> > > separately in driver, and so needs to be tested too.
> > >
> > > Add an option to run xdp_hw_metadata in ZC mode.
> > >
> > > As for now, xdp_hw_metadata accepts no options, so add simple option
> > > parsing logic and a help message.
> > >
> > > For quick reference, also add an ingress packet generation command to the
> > > help message. The command comes from [0].
> > >
> > > [0] https://lore.kernel.org/all/20230119221536.3349901-18-sdf@google.com/
> >
> > I did similar changes in my pending [0], but I made the zerocopy, not
> > the copy mode, the default.
> > If you want to get this in faster (my series will probably need
> > another iteration), let's maybe do the same here?
> > ZC as a default feels better.
> >
> > 0: https://lore.kernel.org/bpf/20230914210452.2588884-9-sdf@google.com/
>
> I do not need those changes in tree ASAP, that is just something I had locally
> for some time and decided to send. So I think I can wait for your series. This
> way it is less work for both of us.
SGTM, thanks!
prev parent reply other threads:[~2023-10-03 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 16:26 [xdp-hints] " Larysa Zaremba
2023-10-02 16:46 ` [xdp-hints] " Stanislav Fomichev
2023-10-03 6:44 ` Larysa Zaremba
2023-10-03 16:09 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRw804r4JM3vTCDH@google.com \
--to=sdf@google.com \
--cc=alexandr.lobakin@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=xdp-hints@xdp-project.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox