From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by mail.toke.dk (Postfix) with ESMTPS id 739DBA1C17D for ; Wed, 26 Jul 2023 00:40:25 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=l+F6L4Y2 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-584126c65d1so23069447b3.3 for ; Tue, 25 Jul 2023 15:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690324824; x=1690929624; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NiMTN0rMxISrPavJuhLij0ZZFeIfou/gU+GcauPEaWc=; b=l+F6L4Y2jK0wqpPmXgxnATvxDjh9nYNbwPKvjTlG1sF+oQUZXxXA3StckaHdexEtLt 9bMPDGL+JExkZXt4kGyPq9ukhflar5vApaRy2PbDkAw/XQ/J4DUh5AY1KfWg3dLMk28c SRuA1yKnEohEZMH3ngQygTNW/R747mupfIkIxSjaOhOPkhrYYV7OeO6Nlp1wo46o/I6z UOVRo9YjoB2Fuwpo0Xds91ANzgXdSuUNMFVxftcW5tX0Ok2cnGKJFzIYp+zCdW1EkVOM cLX2THwSoLbFzKluchTcEwvcew5kH9PzW49NYeixr0WzPA9sR3dlmccE5FAZWS73y9NB 3f0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690324824; x=1690929624; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NiMTN0rMxISrPavJuhLij0ZZFeIfou/gU+GcauPEaWc=; b=F21a9Fn4Z/Vy6avkQq1GnIAbgfa82rEPM0ZZvXYT7d3Oji8vQdiAv5T5Tx9LR0Yy/l 3//MOOxbT3hFfAmIIIr7RZAwzbVXIjxmHfjoVNcbmeSYsicGis6hM1J3+D6BHOfQRDtX f2x1qw8YDDLE5tYBFn3cO8oiOQ/zabW0etA2emQKvRV3wudx8DS+h8LUWur3nNmQu4mD rjTo7yUsrBXN6jHAhbNfEuAAdrnDaPcVpm89Cq5RUq0U/UQixLXC+qt7ckSBcvw1k4JM /7mB7RIPfNW+40UYEpfvYRMpK0hvgDMO683FHYd96npQt7G+Tv2mc6R4ALeJyTJ9Uemw YwEA== X-Gm-Message-State: ABy/qLbrEd6OD1Cu4Hx0u0FnzsbuP9so6WKDbSmSin9rWHdbVBlT7VN7 vdAxQ/g/A1fsA183qZGzbM18vbQ= X-Google-Smtp-Source: APBJJlG73PW2XF1DZfFfJbP9BuKp+qu3Y09U3Xnul7jVcOuNxW9ZWzIO+z21TOakhR1JRQG+dwcSi88= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a81:ae4e:0:b0:583:3609:50d2 with SMTP id g14-20020a81ae4e000000b00583360950d2mr4664ywk.8.1690324824202; Tue, 25 Jul 2023 15:40:24 -0700 (PDT) Date: Tue, 25 Jul 2023 15:40:22 -0700 In-Reply-To: <20230725142811.07f4faa2@kernel.org> Mime-Version: 1.0 References: <20230724235957.1953861-1-sdf@google.com> <20230724235957.1953861-3-sdf@google.com> <20230725142811.07f4faa2@kernel.org> Message-ID: From: Stanislav Fomichev To: Jakub Kicinski Content-Type: text/plain; charset="utf-8" Message-ID-Hash: 6XR3F6F5MOAPRHXXJD7PKVAFUD2FPVXT X-Message-ID-Hash: 6XR3F6F5MOAPRHXXJD7PKVAFUD2FPVXT X-MailFrom: 3WE_AZAMKCSUTEGHPPHMF.DPNYEQ-IJOUTYEQ-QSPKFDU.OFU@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Horman , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, maciej.fijalkowski@intel.com, hawk@kernel.org, netdev@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [RFC net-next v4 2/8] xsk: add TX timestamp and TX checksum offload support List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 07/25, Jakub Kicinski wrote: > On Tue, 25 Jul 2023 13:30:58 -0700 Stanislav Fomichev wrote: > > > I know that it isn't the practice in this file. > > > but adding the following makes kernel-doc happier > > > about NETDEV_XSK_FLAGS_MASK not being documented. > > > > > > /* private: */ > > > > This is autogenerated file :-( But I guess I can try to extend ynl > > scripts to put this comment before the mask. Let me look into that... > > Yes, please! I think I even wrote a patch for it at some point... > but then we realized that enums didn't support /* private: */. > Commit e27cb89a22ada4 has added the support, so we can get back > to getting the YNL changes in place. Let me actually route these separately to you. I'll fix mxdp_zc_max_seg thing as well..