From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by mail.toke.dk (Postfix) with ESMTPS id D2FEF9FA3C5 for ; Thu, 30 Mar 2023 20:38:29 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=tFwe1yaH Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5416d3a321eso197467987b3.12 for ; Thu, 30 Mar 2023 11:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680201508; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5GkwAWkFeGOoqs9hRwF96vtUzcfuETanmtHhAqfhjYY=; b=tFwe1yaHBDRUAQZeC2CyOVnO1GFnmf/+FwndqdvRzobvAL2/m1XwhS37YkNmRK/CiF XEk2LQpML633tC9qr9hkLZBnDe4W6Az0r772FRUXkiH+OapgCsWD2snqlNOarsBKRyU3 ffpS0HAH7nEKpXNj1iv4jhCC2LJIioUmj2yna7Ji4tIFmj96gHEvCoOD5ASvdUS8eQ5U KuRCtF1dbEivxLJUOL+oEKkez5lEVQUTe72P5Xx3SBPwYGj21AffgYXkMZQDGtAb7vLF wcM3oUgMiWZhsuLsEVyLEH2QiRLm8cO3RTSfqkcKI9gg9e1+6Q+BN0vAcJTIu1xT7akZ Vn3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680201508; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GkwAWkFeGOoqs9hRwF96vtUzcfuETanmtHhAqfhjYY=; b=2PlLOmJWMG0HnZNAa6yk0ktizZnTMeomP+GnxnHqbg1zvQX7upM7/q6RpqeUw69d0H cRxrlesdK83OMF8W6S7yFuFSu0YqJZE7EcDHruxqZNm3H9OWULcIN2UEvHFBaNMp4hVe qkZeaxDrEY32UjKtIRc+rysF4ODf+GfH6rP+LrC2h4bLn/QJdz21NBL5gY1YgajoCNnU o8+HGNZKM1wCk5S4Lrk1sYy1BA7W0XUxhIaEyFXi+mlDipiduhQNiMitiQVr140ctsL7 v6W/oVu5hDQtVLLOh2iiaFgvStsKLgADsKWH17psu2GCM7nMk47OHEzCX1TtRYphQAF2 QCYg== X-Gm-Message-State: AAQBX9docjFtT6q98vRgDgHzzIue+Oi7NpK8SiaNagZ/xY5iWrc6H74M XuTyKh6ZhXKLu2XAPK38KJ9NCdU= X-Google-Smtp-Source: AKy350YtshKMp46RHnx3xTtU6bgWkHllXfaEC32Tne8v1zqOX5qgfnkZuLdugYZ2+srYbQSUQtgl+mA= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a05:6902:1586:b0:b76:ae61:b68c with SMTP id k6-20020a056902158600b00b76ae61b68cmr12753744ybu.10.1680201507899; Thu, 30 Mar 2023 11:38:27 -0700 (PDT) Date: Thu, 30 Mar 2023 11:38:26 -0700 In-Reply-To: <168019602958.3557870.9960387532660882277.stgit@firesoul> Mime-Version: 1.0 References: <168019602958.3557870.9960387532660882277.stgit@firesoul> Message-ID: From: Stanislav Fomichev To: Jesper Dangaard Brouer Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Message-ID-Hash: SWDUJLB3FUD2HB3GMMODKNQ75ELDH7F6 X-Message-ID-Hash: SWDUJLB3FUD2HB3GMMODKNQ75ELDH7F6 X-MailFrom: 3I9clZAMKCZACxz08805y.w86Hx9-127DCHx9-9B83ywD.7yD@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 03/30, Jesper Dangaard Brouer wrote: > Notice targeted 6.3-rc kernel via bpf git tree. > Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value, > but doesn't provide information on the RSS hash type (part of 6.3-rc). > This patchset proposal is to change the function call signature via adding > a pointer value argument for provide the RSS hash type. > Alternatively we disable bpf_xdp_metadata_rx_hash() in 6.3-rc, and have > more time to nitpick the RSS hash-type bits. LGTM with one nit about EMIT_BTF. > --- > Jesper Dangaard Brouer (5): > xdp: rss hash types representation > mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type > veth: bpf_xdp_metadata_rx_hash add xdp rss hash type > mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type > selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 22 ++++++- > drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +- > .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 63 ++++++++++++++++++- > drivers/net/veth.c | 11 +++- > include/linux/mlx5/device.h | 14 ++++- > include/linux/netdevice.h | 3 +- > include/net/xdp.h | 49 +++++++++++++++ > net/core/xdp.c | 10 ++- > .../selftests/bpf/prog_tests/xdp_metadata.c | 2 + > .../selftests/bpf/progs/xdp_hw_metadata.c | 14 +++-- > .../selftests/bpf/progs/xdp_metadata.c | 6 +- > .../selftests/bpf/progs/xdp_metadata2.c | 7 ++- > tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- > tools/testing/selftests/bpf/xdp_metadata.h | 1 + > 14 files changed, 183 insertions(+), 24 deletions(-) > --