XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Song Yoong Siang <yoong.siang.song@intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Florian Bezdeka <florian.bezdeka@siemens.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>, Bjorn Topel <bjorn@kernel.org>,
	Magnus Karlsson <magnus.karlsson@intel.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Joe Damato <jdamato@fastly.com>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Mina Almasry <almasrymina@google.com>,
	Daniel Jurgens <danielj@nvidia.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
	Choong Yong Liang <yong.liang.choong@linux.intel.com>,
	Bouska Zdenek <zdenek.bouska@siemens.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, bpf@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	intel-wired-lan@lists.osuosl.org, xdp-hints@xdp-project.net
Subject: [xdp-hints] Re: [PATCH bpf-next v9 3/5] net: stmmac: Add launch time support to XDP ZC
Date: Thu, 6 Feb 2025 20:08:24 +0100	[thread overview]
Message-ID: <Z6UIqPt+Rkpo5E+M@boxer> (raw)
In-Reply-To: <20250206060408.808325-4-yoong.siang.song@intel.com>

On Thu, Feb 06, 2025 at 02:04:06PM +0800, Song Yoong Siang wrote:
> Enable launch time (Time-Based Scheduling) support for XDP zero copy via
> the XDP Tx metadata framework.
> 
> This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata
> on Intel Tiger Lake platform. Below are the test steps and result.
> 
> Test 1: Send a single packet with the launch time set to 1 s in the future.
> 
> Test steps:
> 1. On the DUT, start the xdp_hw_metadata selftest application:
>    $ sudo ./xdp_hw_metadata enp0s30f4 -l 1000000000 -L 1
> 
> 2. On the Link Partner, send a UDP packet with VLAN priority 1 to port 9091
>    of the DUT.
> 
> Result:
> When the launch time is set to 1 s in the future, the delta between the
> launch time and the transmit hardware timestamp is 16.963 us, as shown in
> printout of the xdp_hw_metadata application below.
>   0x55b5864717a8: rx_desc[4]->addr=88100 addr=88100 comp_addr=88100 EoP
>   No rx_hash, err=-95
>   HW RX-time:   1734579065767717328 (sec:1734579065.7677)
>                 delta to User RX-time sec:0.0004 (375.624 usec)
>   XDP RX-time:   1734579065768004454 (sec:1734579065.7680)
>                  delta to User RX-time sec:0.0001 (88.498 usec)
>   No rx_vlan_tci or rx_vlan_proto, err=-95
>   0x55b5864717a8: ping-pong with csum=5619 (want 0000)
>                   csum_start=34 csum_offset=6
>   HW RX-time:   1734579065767717328 (sec:1734579065.7677)
>                 delta to HW Launch-time sec:1.0000 (1000000.000 usec)
>   0x55b5864717a8: complete tx idx=4 addr=4018
>   HW Launch-time:   1734579066767717328 (sec:1734579066.7677)
>                     delta to HW TX-complete-time sec:0.0000 (16.963 usec)
>   HW TX-complete-time:   1734579066767734291 (sec:1734579066.7677)
>                          delta to User TX-complete-time sec:0.0001
>                          (130.408 usec)
>   XDP RX-time:   1734579065768004454 (sec:1734579065.7680)
>                  delta to User TX-complete-time sec:0.9999
>                 (999860.245 usec)
>   HW RX-time:   1734579065767717328 (sec:1734579065.7677)
>                 delta to HW TX-complete-time sec:1.0000 (1000016.963 usec)
>   0x55b5864717a8: complete rx idx=132 addr=88100
> 
> Test 2: Send 1000 packets with a 10 ms interval and the launch time set to
>         500 us in the future.
> 
> Test steps:
> 1. On the DUT, start the xdp_hw_metadata selftest application:
>    $ sudo chrt -f 99 ./xdp_hw_metadata enp0s30f4 -l 500000 -L 1 > \
>      /dev/shm/result.log
> 
> 2. On the Link Partner, send 1000 UDP packets with a 10 ms interval and
>    VLAN priority 1 to port 9091 of the DUT.
> 
> Result:
> When the launch time is set to 500 us in the future, the average delta
> between the launch time and the transmit hardware timestamp is 13.854 us,
> as shown in the analysis of /dev/shm/result.log below. The XDP launch time
> works correctly in sending 1000 packets continuously.
>   Min delta: 08.410 us
>   Avr delta: 13.854 us
>   Max delta: 17.076 us
>   Total packets forwarded: 1000
> 
> Reviewed-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>

Sorry haven't looked here in previous review approaches :/

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h      |  2 ++
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +++++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> index f05cae103d83..925d8b97a42b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> @@ -106,6 +106,8 @@ struct stmmac_metadata_request {
>  	struct stmmac_priv *priv;
>  	struct dma_desc *tx_desc;
>  	bool *set_ic;
> +	struct dma_edesc *edesc;
> +	int tbs;

wanted to comment you're introducing holes here but set_ic is a ptr:)

>  };
>  
>  struct stmmac_xsk_tx_complete {
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index d04543e5697b..5e5d24924ce7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2514,9 +2514,20 @@ static u64 stmmac_xsk_fill_timestamp(void *_priv)
>  	return 0;
>  }
>  
> +static void stmmac_xsk_request_launch_time(u64 launch_time, void *_priv)
> +{
> +	struct stmmac_metadata_request *meta_req = _priv;
> +	struct timespec64 ts = ns_to_timespec64(launch_time);

nit: Apply reverse christmas tree rule here (order the variable
definitions from longest to shortest), but it's not a showstopper I
guess...

> +
> +	if (meta_req->tbs & STMMAC_TBS_EN)
> +		stmmac_set_desc_tbs(meta_req->priv, meta_req->edesc, ts.tv_sec,
> +				    ts.tv_nsec);
> +}
> +
>  static const struct xsk_tx_metadata_ops stmmac_xsk_tx_metadata_ops = {
>  	.tmo_request_timestamp		= stmmac_xsk_request_timestamp,
>  	.tmo_fill_timestamp		= stmmac_xsk_fill_timestamp,
> +	.tmo_request_launch_time	= stmmac_xsk_request_launch_time,
>  };
>  
>  static bool stmmac_xdp_xmit_zc(struct stmmac_priv *priv, u32 queue, u32 budget)
> @@ -2600,6 +2611,8 @@ static bool stmmac_xdp_xmit_zc(struct stmmac_priv *priv, u32 queue, u32 budget)
>  		meta_req.priv = priv;
>  		meta_req.tx_desc = tx_desc;
>  		meta_req.set_ic = &set_ic;
> +		meta_req.tbs = tx_q->tbs;
> +		meta_req.edesc = &tx_q->dma_entx[entry];
>  		xsk_tx_metadata_request(meta, &stmmac_xsk_tx_metadata_ops,
>  					&meta_req);
>  		if (set_ic) {
> -- 
> 2.34.1
> 

  reply	other threads:[~2025-02-06 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  6:04 [xdp-hints] [PATCH bpf-next v9 0/5] xsk: TX metadata Launch Time support Song Yoong Siang
2025-02-06  6:04 ` [xdp-hints] [PATCH bpf-next v9 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata Song Yoong Siang
2025-02-06  6:04 ` [xdp-hints] [PATCH bpf-next v9 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata Song Yoong Siang
2025-02-06  6:04 ` [xdp-hints] [PATCH bpf-next v9 3/5] net: stmmac: Add launch time support to XDP ZC Song Yoong Siang
2025-02-06 19:08   ` Maciej Fijalkowski [this message]
2025-02-06  6:04 ` [xdp-hints] [PATCH bpf-next v9 4/5] igc: Refactor empty frame insertion for launch time support Song Yoong Siang
2025-02-06 19:23   ` [xdp-hints] " Maciej Fijalkowski
2025-02-06  6:04 ` [xdp-hints] [PATCH bpf-next v9 5/5] igc: Add launch time support to XDP ZC Song Yoong Siang
2025-02-06 19:29   ` [xdp-hints] " Maciej Fijalkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6UIqPt+Rkpo5E+M@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=danielj@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=faizal.abdul.rahim@linux.intel.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jdamato@fastly.com \
    --cc=joabreu@synopsys.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jonathan.lemon@gmail.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=magnus.karlsson@intel.com \
    --cc=martin.lau@linux.dev \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=willemb@google.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yong.liang.choong@linux.intel.com \
    --cc=yonghong.song@linux.dev \
    --cc=yoong.siang.song@intel.com \
    --cc=zdenek.bouska@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox