From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by mail.toke.dk (Postfix) with ESMTPS id C33D6ADFAF5 for ; Thu, 23 Jan 2025 20:49:32 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Whn6fliC Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-215770613dbso16981815ad.2 for ; Thu, 23 Jan 2025 11:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737661771; x=1738266571; darn=xdp-project.net; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/qLickY1e0ujLI7bpuAPKBg3ra7SxF8sIpaNTGdpk/E=; b=Whn6fliCd/FGM7MpNIdW3r4BkzLi2WQVf95k9qVTDL0PaYd9m9Sw4udkwqw4t5kQ1z 6+dj4XVV+UuNg9x7SmgBs9x5k45evUrhxGqjQxACZV+v3JrhdlvlnncF82RtZlseYk7T /gJU7BObFh+HTDk8QJfKH6QXLclOioF2iFakP00WrP30SGG89+3yizAANkyInlzCIdXZ U/TQsew84zV94+ppFrNLUWrHBUF2zepFs+BMWBOYebeY9AFRRtRNLe45/opqOZLvbx48 5R/1SmjBtT4Q3G/kIG45r+hQqGO1dZo96PxfsAZvID27EVhMQYTt8Mv2bBvM8cUv1KCy OwVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737661771; x=1738266571; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/qLickY1e0ujLI7bpuAPKBg3ra7SxF8sIpaNTGdpk/E=; b=aRnM9DRAImpqLtPpIAnmXv6vR6jiTnu5S6bw0WJBUfklqWtFx44M9AzrIYaCVjRyRH 5jcQgUCJT0MDwjt5mKcJkJWnCguFpfiE75QixK6ZoLhS718BUwhM607QJ8X9iv1zk75V 1wCagoYP9H3x1OFRiCV6OqnN31Vthq2jE0LrHzFbzPLGXAeYRh9cgMrq4sFygHCid1KZ V1KxA2iKsxSroTYnVx0B6c+XDqas1ygPHzdSci6IIv3S1vmXaZ3Xt4P9MJiHFDv5BFaX 5ptUYUvBiXqIvxqWPxO+UkAjt2W9vOW0XsAzATxwzLzKrg+X5oSxrL+jWKOLDqIUnexb 2i+A== X-Forwarded-Encrypted: i=1; AJvYcCXQvmWr4qvp/3kJXFrkij7hISi9+ZXXm9FhbyzqqI1jrdTR7cEKiKitPqvwJW0QNgI/zGrMEDoZats=@xdp-project.net X-Gm-Message-State: AOJu0Yxp9gu8h9Tpc5p6iFzPhbBJ1rrf+mX3eBDcW0aPK6yVul321gUS MXTR01aN0GEkdl+ht5gb1hixZJWIt9Tp8JDnKeD+SUVKX1dZGIg= X-Gm-Gg: ASbGncv27EE8Z0vUCPl4MnS/Q9JEBb8SOYyIIRA+nP/EZWr+MYtbErosB6OZ2DfTJ9E DimnXuhoYmNIwMudGMMRePRCP+lmLWSDEi5nxj0cZFPpulFTPkgzqk2b7DKhh5kzwgV8Q9M6h+b OEqlIGRqY4uHl0+MmNscMc89RcKy7CnaBYWhGPjy2JUQlnqrVg9M+zbOWPL3ANbGKZ6Sm3iseVf 7/7yb/dnP1BiUxFsjooygG6dD7ky27S3Vd4umzXz96xJ+who66hvLSoSwsYYCHMNeqhRGQIcWcS exeB X-Google-Smtp-Source: AGHT+IESeNKwX2zcipFaXoMlvYsxaD0Oto3RCfSnVHPTxJyo13u3XHbde1U83PRnjPUOPMjYL0fFMw== X-Received: by 2002:a17:903:988:b0:216:7ee9:220b with SMTP id d9443c01a7336-21c35530048mr461405425ad.22.1737661771206; Thu, 23 Jan 2025 11:49:31 -0800 (PST) Received: from localhost ([2601:646:9e00:f56e:123b:cea3:439a:b3e3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da4141436sm2728275ad.134.2025.01.23.11.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 11:49:30 -0800 (PST) Date: Thu, 23 Jan 2025 11:49:30 -0800 From: Stanislav Fomichev To: Florian Bezdeka Message-ID: References: <20250116155350.555374-1-yoong.siang.song@intel.com> <20250116155350.555374-5-yoong.siang.song@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Message-ID-Hash: KD3SLDL6YJZ5O3R7VUKOZI4TR6ILIBZV X-Message-ID-Hash: KD3SLDL6YJZ5O3R7VUKOZI4TR6ILIBZV X-MailFrom: stfomichev@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "Song, Yoong Siang" , "Bouska, Zdenek" , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Willem de Bruijn , Donald Hunter , Jonathan Corbet , Bjorn Topel , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Jonathan Lemon , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , "Damato, Joe" , Stanislav Fomichev , Xuan Zhuo , Mina Almasry , Daniel Jurgens , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , "Nguyen, Anthony L" , "Kitszel, Przemyslaw" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "intel-wired-lan@lists.osuosl.org" , "xdp-hints@xdp-project.net" X-Mailman-Version: 3.3.10 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 01/23, Florian Bezdeka wrote: > Hi all, > > On Thu, 2025-01-23 at 16:41 +0000, Song, Yoong Siang wrote: > > On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek wrote: > > > > > > Hi Siang, > > > > > > I tested this patch series on 6.13 with Intel I226-LM (rev 04). > > > > > > I also applied patch "selftests/bpf: Actuate tx_metadata_len in xdp_hw_metadata" [1] > > > and "selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata" [2] so that TX timestamps > > > work. > > > > > > HW RX-timestamp was small (0.5956 instead of 1737373125.5956): > > > > > > HW RX-time: 595572448 (sec:0.5956) delta to User RX-time sec:1737373124.9873 (1737373124987318.750 usec) > > > XDP RX-time: 1737373125582798388 (sec:1737373125.5828) delta to User RX-time sec:0.0001 (92.733 usec) > > > > > > Igc's raw HW RX-timestamp in front of frame data was overwritten by BPF program on > > > line 90 in tools/testing/selftests/bpf: meta->hint_valid = 0; > > > > > > "HW timestamp has been copied into local variable" comment is outdated on > > > line 2813 in drivers/net/ethernet/intel/igc/igc_main.c after > > > commit 069b142f5819 igc: Add support for PTP .getcyclesx64() [3]. > > > > > > Workaround is to add unused data to xdp_meta struct: > > > > > > --- a/tools/testing/selftests/bpf/xdp_metadata.h > > > +++ b/tools/testing/selftests/bpf/xdp_metadata.h > > > @@ -49,4 +49,5 @@ struct xdp_meta { > > > __s32 rx_vlan_tag_err; > > > }; > > > enum xdp_meta_field hint_valid; > > > + __u8 avoid_IGC_TS_HDR_LEN[16]; > > > }; > > > > > > > Hi Zdenek Bouska, > > > > Thanks for your help on testing this patch set. > > You are right, there is some issue with the Rx hw timestamp, > > I will submit the bug fix patch when the solution is finalized, > > but the fix will not be part of this launch time patch set. > > Until then, you can continue to use your WA. > > I think there is no simple fix for that. That needs some discussion > around the "expectations" to the headroom / meta data area in front of > the actual packet data. By 'simple' you mean without some new UAPI to signal the size of that 'reserved area' by the driver? I don't see any other easy way out as well :-/