XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: "Song, Yoong Siang" <yoong.siang.song@intel.com>
To: "Bezdeka, Florian" <florian.bezdeka@siemens.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
	Vedang Patel <vedang.patel@intel.com>,
	"Joseph, Jithu" <jithu.joseph@intel.com>,
	Andre Guedes <andre.guedes@intel.com>,
	"Brouer, Jesper" <brouer@redhat.com>,
	"Stanislav Fomichev" <sdf@google.com>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>,
	David Laight <David.Laight@ACULAB.COM>
Cc: "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: [xdp-hints] Re: [PATCH net v3 1/1] igc: read before write to SRRCTL register
Date: Sun, 16 Apr 2023 02:19:26 +0000	[thread overview]
Message-ID: <PH0PR11MB58306BDB63286338EABAF61AD89F9@PH0PR11MB5830.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ffa2551d-ca04-3fe9-944a-0383e1d079e3@siemens.com>

On Saturday, April 15, 2023 5:20 PM, Florian Bezdeka <florian.bezdeka@siemens.com> wrote:
>On 14.04.23 17:49, Song Yoong Siang wrote:
>> igc_configure_rx_ring() function will be called as part of XDP program
>> setup. If Rx hardware timestamp is enabled prio to XDP program setup,
>> this timestamp enablement will be overwritten when buffer size is
>> written into SRRCTL register.
>>
>
>Hi all,
>
>I'm actually searching for the root cause of a similar problem (RX timestamp lost)
>that I can reproduce here, but the setup is slightly different. The setup:
>
>- igc driver
>- i225/226 network card
>- When starting to transmit frames using XDP with zero copy enabled
>  another application (ptp4l) complains about missing RX timestamps
>- Loading the XDP program has already been removed (not needed for
>  TX only)
>- ptp4l is using the traditional socket API
>- The RX timestamps seem to come back once we stop sending frames
>  using XDP
>
>The "zero copy support" enabled part is important. If ZC support is not requested
>everything works fine.
>
>Any ideas?
>
>Best regards,
>Florian
>

Hi Florian,

You means this patch does not help on your issue?
Need to understand more on the setup and behavior to tell.
Are ptp4l and XDP ZC Tx apps running on same queue or separate queue?
I suggest you to run " sudo hwstamp_ctl -i eth0 -r 1 " multiple times in the middle
to check the behavior.

Thanks & Regards
Siang

  reply	other threads:[~2023-04-16  2:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 15:49 [xdp-hints] " Song Yoong Siang
2023-04-14 20:05 ` [xdp-hints] " Jesper Dangaard Brouer
2023-04-17 14:24   ` Jesper Dangaard Brouer
2023-04-18  9:31     ` Florian Bezdeka
2023-04-15  9:19 ` Florian Bezdeka
2023-04-16  2:19   ` Song, Yoong Siang [this message]
2023-04-17  2:53     ` Zulkifli, Muhammad Husaini
2023-04-17 18:50       ` Jakub Kicinski
2023-04-30  5:05 ` [xdp-hints] Re: [Intel-wired-lan] " naamax.meir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB58306BDB63286338EABAF61AD89F9@PH0PR11MB5830.namprd11.prod.outlook.com \
    --to=yoong.siang.song@intel.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=andre.guedes@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jithu.joseph@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    --cc=stable@vger.kernel.org \
    --cc=vedang.patel@intel.com \
    --cc=xdp-hints@xdp-project.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox