From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by mail.toke.dk (Postfix) with ESMTPS id 051909E0E8D for ; Fri, 20 Jan 2023 23:48:48 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=pxXQriX7 Received: by mail-pj1-x1036.google.com with SMTP id h5-20020a17090a9c0500b0022bb85eb35dso1881007pjp.3 for ; Fri, 20 Jan 2023 14:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eObadKArSgHkepFrKBedeZ5xyeKR3KRJqKeEFPEYgXw=; b=pxXQriX7a1w5N5lVDMxWBmB2cm0i/lDxSVo1MNqVC5EnzDZbXdFjDSk5ehcuSArsFL YeCxPwZrHhckOqadcBQvADP3FPaE/2YEEZiXiBTTFTOPgp6nBI1fyeiLShNxweaHqpVb rPFWs4lLa+p4Fxvqh22RdOrBpvqRw1HGrd294gLX6HNe6yZHjtEyuWPudPe3MtrR0h1P Tw2HccuMtZh2qzxHRTchSZH6FFw1vuCfErVrIMyfvLNnfWm8dCcxtGpxafZS0DHtQ6F+ TrTsaROGlcOP4PX9I9X9nH/6a0jgDIx7Gno2VsufuuEEYgmpQw6ZaR7teoABICaDXtNG me5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eObadKArSgHkepFrKBedeZ5xyeKR3KRJqKeEFPEYgXw=; b=bezVXlI7F/9xzBw5Tf0LnKofTO5ICVd0bxMoeaUviKx7RNX1+hCjgW5pZCnm4T6A3C o2U3jvJPPfd1JPGz8rDzMQlcA636OA0n93TClc8pZfEr9XI9qzGm3F3fml2A/YvNvVS9 oFkBuZSBu9dZTygTxxiNBpfF/YJcS3uE2rNAwK60TOiOr4WpQdio0Yw/yXx48PJw8oRT ilRzrlvTHyToLSVYw3M19fktZCHfLKXrE1HvM+5oly1mmEr9C6J+dvtVb2+hj6KerWfW AKEHcTmQShLPi6WHUjDjKtnbAk/LBzYjvuaXqNd4KLfozjHPHQvZB1c5bQMYejnhtjgF 4ePw== X-Gm-Message-State: AFqh2koSrxXVowy+DT08jqpOzCGiBtDya/IUV0AY1Bq+5gJxkHx7oh2V Mp2NPk9NZH9rMvd9mpMZj7a+DZBA+34R0dE2NBLXnA== X-Google-Smtp-Source: AMrXdXtao8z/kHlIVvd0cymJJDtEe0u2uVNNtlff2acD17VdLohukAXmnkI3YBg5bmyZqBXdzzfKawd4u6xMfGYPIqo= X-Received: by 2002:a17:90b:3741:b0:219:fbc:a088 with SMTP id ne1-20020a17090b374100b002190fbca088mr2184826pjb.162.1674254926970; Fri, 20 Jan 2023 14:48:46 -0800 (PST) MIME-Version: 1.0 References: <20230119221536.3349901-1-sdf@google.com> <20230119221536.3349901-18-sdf@google.com> In-Reply-To: From: Stanislav Fomichev Date: Fri, 20 Jan 2023 14:48:35 -0800 Message-ID: To: Martin KaFai Lau Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: EZOLGV3A6P5XJNQTL72MAZOVAUC2TN5S X-Message-ID-Hash: EZOLGV3A6P5XJNQTL72MAZOVAUC2TN5S X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, bpf@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v8 17/17] selftests/bpf: Simple program to dump XDP RX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Jan 20, 2023 at 2:30 PM Martin KaFai Lau wrote: > > On 1/19/23 2:15 PM, Stanislav Fomichev wrote: > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > > index e09bef2b7502..9c961d2d868e 100644 > > --- a/tools/testing/selftests/bpf/Makefile > > +++ b/tools/testing/selftests/bpf/Makefile > > @@ -83,7 +83,7 @@ TEST_PROGS_EXTENDED := with_addr.sh \ > > TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \ > > flow_dissector_load test_flow_dissector test_tcp_check_syncookie_user \ > > test_lirc_mode2_user xdping test_cpp runqslower bench bpf_testmod.ko \ > > - xskxceiver xdp_redirect_multi xdp_synproxy veristat > > + xskxceiver xdp_redirect_multi xdp_synproxy veristat xdp_hw_metadata > > > > TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read $(OUTPUT)/sign-file > > TEST_GEN_FILES += liburandom_read.so > > @@ -383,6 +383,7 @@ test_subskeleton.skel.h-deps := test_subskeleton_lib2.bpf.o test_subskeleton_lib > > test_subskeleton_lib.skel.h-deps := test_subskeleton_lib2.bpf.o test_subskeleton_lib.bpf.o > > test_usdt.skel.h-deps := test_usdt.bpf.o test_usdt_multispec.bpf.o > > xsk_xdp_progs.skel.h-deps := xsk_xdp_progs.bpf.o > > +xdp_hw_metadata.skel.h-deps := xdp_hw_metadata.bpf.o > > > > LINKED_BPF_SRCS := $(patsubst %.bpf.o,%.c,$(foreach skel,$(LINKED_SKELS),$($(skel)-deps))) > > > > @@ -580,6 +581,10 @@ $(OUTPUT)/xskxceiver: xskxceiver.c $(OUTPUT)/xsk.o $(OUTPUT)/xsk_xdp_progs.skel. > > $(call msg,BINARY,,$@) > > $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@ > > > > +$(OUTPUT)/xdp_hw_metadata: xdp_hw_metadata.c $(OUTPUT)/network_helpers.o $(OUTPUT)/xsk.o $(OUTPUT)/xdp_hw_metadata.skel.h | $(OUTPUT) > > + $(call msg,BINARY,,$@) > > + $(Q)$(CC) $(CFLAGS) -static $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@ > > My dev machine fails on '-static' :(. A few machines that I got also don't have > those static libraries, so likely the default environment that I got here. > > It seems to be the only binary using '-static' in this Makefile. Can it be > removed or at least not the default? Sure, I can leave it out. It's mostly here due to G's environment where it is easier to work with static binaries.