From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by mail.toke.dk (Postfix) with ESMTPS id 234079E34B1 for ; Tue, 24 Jan 2023 18:43:08 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=Ri/8pJDv Received: by mail-pj1-x1029.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso19395393pjg.2 for ; Tue, 24 Jan 2023 09:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kVpn5SMLD9pIiP0+8Xm3dHvf5ZmENfuH2Pxsjs07rZM=; b=Ri/8pJDvge0Awmaf5DNXwCqG+o70l5xFTNqs4AFQo1KC32MlZFz/pV8vYHoM6uKR+j qhBXLXJwffqEN/YZedW4481g+haZdvtdVYHEZnNHvgPoM8qITPUdlHTy1segQg5UnlnV dJUm2cHCSEZ54SGGPcVHPjbQwli1dtjJlXpYNykQ2G9mUivTaKUWZ4q33Wn1DxmyCMch DPrJGTZaA0oEtRgVzdkiBus2MrIPe0VwH0GFu/MSVyADY8Ggd6FM/8DC22itey77m0O5 1/Dy6oE3d4IX8cvnMKArYgb+/8Ap27LdjqyLa0oejvqFffoAVKkdaPXOuuFqV1y3wzl6 4E9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kVpn5SMLD9pIiP0+8Xm3dHvf5ZmENfuH2Pxsjs07rZM=; b=1LpK6VEbyMMwVWTWii7nqZP25NvrG6AALtkiceFGGIVnUKHjBv1ehfmLgch+f3xEQZ 03dzbUX7WZvwIfha3BZZ05995Z+u8I1O8NuAj3xfRJiOsgiABgjO0Ujrv+TaTjCI9Vld ZwNlj5Lsa6c+IAEY0kqnWS2QNtzi0yxoIa2J5sVbqglB+zD/EVFeJK6pE2BsKEguXNjl tsB0bfE7AvKJV1tAcqXtlHHPBf74WM26sMttaQWbqXi8o+riTgRqEhztcfMAb759nnTn Eg/6A7KrATsgUp76muchYOxvHhZsMsdGYqUzCHn6EzvBYGJy3K/9Fb+wrV+RV/7tWVpO p43Q== X-Gm-Message-State: AFqh2kpZHIPRYGejMmCITRsijqj7cXfWn5d80mFTjt/JYp4APRg8yr79 C/1Yc1WJuLglYuMw9/XSSHHqoxmjQJFhSGvhFb8sKQ== X-Google-Smtp-Source: AMrXdXu84A7RJILwgoKpk8B12punuj2R/JnqdpZOPgedaESUceXYwyUtZtIMeIQMeIEsAhgseHygWwjNvsCc5jsCxno= X-Received: by 2002:a17:90a:2c4d:b0:229:2410:ef30 with SMTP id p13-20020a17090a2c4d00b002292410ef30mr3250936pjm.66.1674582185932; Tue, 24 Jan 2023 09:43:05 -0800 (PST) MIME-Version: 1.0 References: <20230119221536.3349901-1-sdf@google.com> <20230119221536.3349901-18-sdf@google.com> <71be95ee-b522-b3db-105a-0f25d8dc52cb@redhat.com> In-Reply-To: <71be95ee-b522-b3db-105a-0f25d8dc52cb@redhat.com> From: Stanislav Fomichev Date: Tue, 24 Jan 2023 09:42:53 -0800 Message-ID: To: Jesper Dangaard Brouer Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: ITLLGJQ7SNJGV3O7FSQUJZSWN3T4AA47 X-Message-ID-Hash: ITLLGJQ7SNJGV3O7FSQUJZSWN3T4AA47 X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, brouer@redhat.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v8 17/17] selftests/bpf: Simple program to dump XDP RX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jan 24, 2023 at 7:26 AM Jesper Dangaard Brouer wrote: > > > Testing this on mlx5 and I'm not getting the RX-timestamp. > See command details below. CC'ed Toke since I've never tested mlx5 myself. I was pretty close to getting the setup late last week, let me try to see whether it's ready or not. > On 19/01/2023 23.15, Stanislav Fomichev wrote: > > To be used for verification of driver implementations. Note that > > the skb path is gone from the series, but I'm still keeping the > > implementation for any possible future work. > > > > $ xdp_hw_metadata > > sudo ./xdp_hw_metadata mlx5p1 > > Output: > [...cut ...] > open bpf program... > load bpf program... > prepare skb endpoint... > XXX timestamping_enable(): setsockopt(SO_TIMESTAMPING) ret:0 > prepare xsk map... > map[0] = 3 > map[1] = 4 > map[2] = 5 > map[3] = 6 > map[4] = 7 > map[5] = 8 > attach bpf program... > poll: 0 (0) > poll: 0 (0) > poll: 0 (0) > poll: 1 (0) > xsk_ring_cons__peek: 1 > 0x1821788: rx_desc[0]->addr=100000000008000 addr=8100 comp_addr=8000 > rx_timestamp: 0 > rx_hash: 2773355807 > 0x1821788: complete idx=8 addr=8000 > poll: 0 (0) > > The trace_pipe: > > $ sudo cat /sys/kernel/debug/tracing/trace_pipe > -0 [005] ..s2. 2722.884762: bpf_trace_printk: > forwarding UDP:9091 to AF_XDP > -0 [005] ..s2. 2722.884771: bpf_trace_printk: > populated rx_hash with 2773355807 > > > > On the other machine: > > > > $ echo -n xdp | nc -u -q1 9091 # for AF_XDP > > Fixing the source-port to see if RX-hash remains the same. > > $ echo xdp | nc --source-port=2000 --udp 198.18.1.1 9091 > > > $ echo -n skb | nc -u -q1 9092 # for skb > > > > Sample output: > > > > # xdp > > xsk_ring_cons__peek: 1 > > 0x19f9090: rx_desc[0]->addr=100000000008000 addr=8100 comp_addr=8000 > > rx_timestamp_supported: 1 > > rx_timestamp: 1667850075063948829 > > 0x19f9090: complete idx=8 addr=8000 > > xsk_ring_cons__peek: 1 > 0x1821788: rx_desc[0]->addr=100000000008000 addr=8100 comp_addr=8000 > rx_timestamp: 0 > rx_hash: 2773355807 > 0x1821788: complete idx=8 addr=8000 > > It doesn't look like hardware RX-timestamps are getting enabled. > > [... cut to relevant code ...] > > > diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c > > new file mode 100644 > > index 000000000000..0008f0f239e8 > > --- /dev/null > > +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c > > @@ -0,0 +1,403 @@ > [...] > > > +static void timestamping_enable(int fd, int val) > > +{ > > + int ret; > > + > > + ret = setsockopt(fd, SOL_SOCKET, SO_TIMESTAMPING, &val, sizeof(val)); > > + if (ret < 0) > > + error(-1, errno, "setsockopt(SO_TIMESTAMPING)"); > > +} > > + > > +int main(int argc, char *argv[]) > > +{ > [...] > > > + printf("prepare skb endpoint...\n"); > > + server_fd = start_server(AF_INET6, SOCK_DGRAM, NULL, 9092, 1000); > > + if (server_fd < 0) > > + error(-1, errno, "start_server"); > > + timestamping_enable(server_fd, > > + SOF_TIMESTAMPING_SOFTWARE | > > + SOF_TIMESTAMPING_RAW_HARDWARE); > > + > > I don't think this timestamping_enable() with these flags are enough to > enable hardware timestamping. > > --Jesper >