XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf@google.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: brouer@redhat.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, martin.lau@kernel.org,
	ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com,
	larysa.zaremba@intel.com, xdp-hints@xdp-project.net,
	anthony.l.nguyen@intel.com, yoong.siang.song@intel.com,
	boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org,
	pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org,
	edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org,
	davem@davemloft.net
Subject: [xdp-hints] Re: [PATCH bpf RFC-V3 1/5] xdp: rss hash types representation
Date: Thu, 30 Mar 2023 12:02:43 -0700	[thread overview]
Message-ID: <CAKH8qBv9QngYcMjcL=sZR8wVCufPSAv-ZW72OJB-LhZF5a_DrQ@mail.gmail.com> (raw)
In-Reply-To: <04256caf-aa28-7e0a-59b1-ecf2b237c96f@redhat.com>

On Thu, Mar 30, 2023 at 11:56 AM Jesper Dangaard Brouer
<jbrouer@redhat.com> wrote:
>
>
> On 30/03/2023 20.35, Stanislav Fomichev wrote:
> > On 03/30, Jesper Dangaard Brouer wrote:
> >> The RSS hash type specifies what portion of packet data NIC hardware used
> >> when calculating RSS hash value. The RSS types are focused on Internet
> >> traffic protocols at OSI layers L3 and L4. L2 (e.g. ARP) often get hash
> >> value zero and no RSS type. For L3 focused on IPv4 vs. IPv6, and L4
> >> primarily TCP vs UDP, but some hardware supports SCTP.
> >
> >> Hardware RSS types are differently encoded for each hardware NIC. Most
> >> hardware represent RSS hash type as a number. Determining L3 vs L4 often
> >> requires a mapping table as there often isn't a pattern or sorting
> >> according to ISO layer.
> >
> >> The patch introduce a XDP RSS hash type (enum xdp_rss_hash_type) that
> >> contain combinations to be used by drivers, which gets build up with bits
> >> from enum xdp_rss_type_bits. Both enum xdp_rss_type_bits and
> >> xdp_rss_hash_type get exposed to BPF via BTF, and it is up to the
> >> BPF-programmer to match using these defines.
> >
> >> This proposal change the kfunc API bpf_xdp_metadata_rx_hash() adding
> >> a pointer value argument for provide the RSS hash type.
> >
> >> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> >> ---
> >>   include/linux/netdevice.h |    3 ++-
> >>   include/net/xdp.h         |   46 +++++++++++++++++++++++++++++++++++++++++++++
> >>   net/core/xdp.c            |   10 +++++++++-
> >>   3 files changed, 57 insertions(+), 2 deletions(-)
> >
>
> [...]
> >> diff --git a/net/core/xdp.c b/net/core/xdp.c
> >> index 528d4b37983d..38d2dee16b47 100644
> >> --- a/net/core/xdp.c
> >> +++ b/net/core/xdp.c
> >> @@ -734,14 +734,22 @@ __bpf_kfunc int
> >> bpf_xdp_metadata_rx_timestamp(const struct xdp_md *ctx, u64 *tim
> >>    * bpf_xdp_metadata_rx_hash - Read XDP frame RX hash.
> >>    * @ctx: XDP context pointer.
> >>    * @hash: Return value pointer.
> >> + * @rss_type: Return value pointer for RSS type.
> >> + *
> >> + * The RSS hash type (@rss_type) specifies what portion of packet headers NIC
> >> + * hardware were used when calculating RSS hash value.  The type combinations
> >> + * are defined via &enum xdp_rss_hash_type and individual bits can be decoded
> >> + * via &enum xdp_rss_type_bits.
> >>    *
> >>    * Return:
> >>    * * Returns 0 on success or ``-errno`` on error.
> >>    * * ``-EOPNOTSUPP`` : means device driver doesn't implement kfunc
> >>    * * ``-ENODATA``    : means no RX-hash available for this frame
> >>    */
> >> -__bpf_kfunc int bpf_xdp_metadata_rx_hash(const struct xdp_md *ctx,
> >> u32 *hash)
> >> +__bpf_kfunc int bpf_xdp_metadata_rx_hash(const struct xdp_md *ctx,
> >> u32 *hash,
> >> +                     enum xdp_rss_hash_type *rss_type)
> >>   {
> >
> > [..]
> >
> >> +    BTF_TYPE_EMIT(enum xdp_rss_type_bits);
> >
> > nit: Do we still need this with an extra argument?
> >
>
> Yes, unfortunately (compiler optimizes out enum xdp_rss_type_bits).
> Do notice the difference xdp_rss_type_bits vs xdp_rss_hash_type.
> We don't need it for "xdp_rss_hash_type" but need it for
> "xdp_rss_type_bits".

Ah, I missed that. Then why not expose xdp_rss_type_bits?
Keep xdp_rss_hash_type for internal drivers' tables, and export the
enum with the bits?

> --Jesper
>

  reply	other threads:[~2023-03-30 19:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 17:07 [xdp-hints] [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
2023-03-30 17:07 ` [xdp-hints] [PATCH bpf RFC-V3 1/5] xdp: rss hash types representation Jesper Dangaard Brouer
2023-03-30 18:35   ` [xdp-hints] " Stanislav Fomichev
2023-03-30 18:56     ` Jesper Dangaard Brouer
2023-03-30 19:02       ` Stanislav Fomichev [this message]
2023-03-30 19:08         ` Jesper Dangaard Brouer
2023-03-31 11:49           ` Jesper Dangaard Brouer
2023-03-30 17:07 ` [xdp-hints] [PATCH bpf RFC-V3 2/5] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer
2023-03-30 17:07 ` [xdp-hints] [PATCH bpf RFC-V3 3/5] veth: " Jesper Dangaard Brouer
2023-03-30 17:08 ` [xdp-hints] [PATCH bpf RFC-V3 4/5] mlx4: " Jesper Dangaard Brouer
2023-03-30 17:08 ` [xdp-hints] [PATCH bpf RFC-V3 5/5] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer
2023-03-30 18:38 ` [xdp-hints] Re: [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Stanislav Fomichev
2023-03-30 19:04   ` Jesper Dangaard Brouer
2023-03-30 19:24 ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKH8qBv9QngYcMjcL=sZR8wVCufPSAv-ZW72OJB-LhZF5a_DrQ@mail.gmail.com' \
    --to=sdf@google.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=boon.leong.ong@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jbrouer@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=larysa.zaremba@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=yoong.siang.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox