From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by mail.toke.dk (Postfix) with ESMTPS id 9FE659C533B for ; Wed, 23 Nov 2022 20:54:30 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=SAyowW6E Received: by mail-oi1-x22e.google.com with SMTP id v81so20150107oie.5 for ; Wed, 23 Nov 2022 11:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gSrw9jy1DdzW54uya3GLAzT+2OzZzkDqg6d87pvhaPs=; b=SAyowW6EeaGJkplgTyVYsNTgVZAj3MA2J302awudfKDjd5fS8bB3p1TBBDmTvaWmg0 32OEuu1INff6VrcU9+xzLOtQEs7mbMft4spDWOxBlGx8ap7TbVuPHDRUxaPmRhVLyQMo L1+uFh8dK9K4YCABZ1L+GBC3932cxmZ8w1jVgYUR2u0iXOO69FPUdpZL+gV6j8vLzZhV ugxFbRuiOo4mBno+r83w1ZgP5cIDQKPhKgJpbGX8NUds2D7x18naTjdiPnU4288Lr7H8 NYbZFr4ITE0I5AGGPF4oj26+HkbXCcNHTLE1sb5+guYANDen7ZHoDUK3caH0aXFnOaGK tbYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gSrw9jy1DdzW54uya3GLAzT+2OzZzkDqg6d87pvhaPs=; b=Qj3piSUpmJ+O3pQ1KslA8h+Tq7biGFdgteUVeMmn6CvKsAHkVHjcUqMfwzT965R74a oP9PjfjkgCOivkJcdrL7Fx2N5hxOJ1bif7Tswv+0sjOfu/qgVuZGC4Ivvo+fir9DxT7g Yg0FhurDP6OFZcbMtT9XruoDnkOSDp7F+2vr7s0pFf+UNrpbOoNaZ9/2ElFvWT0zn7Hm DeVWZmiLUiCP2g2JPQbi1g2GriA+B55W0H5cTowV62W6IWzRHufz8xP+ZkmauwULhP7f F+/xyCJC5ntjKkIMgd++Q/tOPe9XMtrLrk2vcHwgU7W0vMeGnCA3h9k7cizOGmqvzhWK X7oQ== X-Gm-Message-State: ANoB5pn3G3v3lYAefmUqkF8QL3uXq1xieYBwIM2B1m9+t/3xi6XWgviZ gg03BAMkXFYvelnuV8zCoHNI0fjoM6ZK900VTkRn6Q== X-Google-Smtp-Source: AA0mqf58BXp5+AhLwQziFGPiG4v1/XH+Cf8sshn7xXTcS5qy+Lwx5aKIXOwJyLY2Av5mDzybwp0vDHSZz4knu12MJt8= X-Received: by 2002:aca:674c:0:b0:35b:79ca:2990 with SMTP id b12-20020aca674c000000b0035b79ca2990mr1938077oiy.125.1669233268889; Wed, 23 Nov 2022 11:54:28 -0800 (PST) MIME-Version: 1.0 References: <20221121182552.2152891-1-sdf@google.com> <20221121182552.2152891-9-sdf@google.com> <877czlvj9x.fsf@toke.dk> <20221123111712.1da24f54@kernel.org> In-Reply-To: <20221123111712.1da24f54@kernel.org> From: Stanislav Fomichev Date: Wed, 23 Nov 2022 11:54:18 -0800 Message-ID: To: Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: WG6OANFTMVJJ3WLCLNDF5JCMVNZP54DK X-Message-ID-Hash: WG6OANFTMVJJ3WLCLNDF5JCMVNZP54DK X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v2 8/8] selftests/bpf: Simple program to dump XDP RX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Nov 23, 2022 at 11:17 AM Jakub Kicinski wrote: > > On Wed, 23 Nov 2022 10:29:23 -0800 Stanislav Fomichev wrote: > > > return ch.rx_count ?: ch.combined_count; > > > > > > works though :) > > > > Perfect, will do the same :-) Thank you for running and testing! > > The correct value is ch.rx_count + ch.combined_count > > We've been over this many times, I thought it was coded up in libbpf > but I don't see it now :S Yeah, can't find it. Also doesn't exist on libxdp/libxsk. Will apply your fix, thank you!