From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by mail.toke.dk (Postfix) with ESMTPS id 36794A2B696 for ; Thu, 21 Sep 2023 06:35:50 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=agA0OTjC Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-490cd6db592so217284e0c.1 for ; Wed, 20 Sep 2023 21:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695270946; x=1695875746; darn=xdp-project.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+XOWCR9KFhMn8+2HIiXvxelBlhmHeyj33dGAiBogAcY=; b=agA0OTjC1bJPylcYlsBsBiljMbAxIbYkyHZEQD0ZJgi98kIBr+Z4TBDYxsOFOwiKbg mG56cs8Xt9ptb5JcB3tE/kF3xNiv8vUVQMcZxPo8CPmxv4I7Mjak5MXFsQpJp2NBjP4C 3/6iKLCSfA1K3gOpYtvb9cjjGl+s3S8ZjxAoIQ4ZTd7HRGamOwgzOjrceYrEs4qs8xKw DxV/XDMGZ71pn/wPlT0FK1YjtxVpkBo6QeWwDZSE+++47CxaIoQMckNIUtuxWp3tagTJ 9cIFPI8Zje5VHd8OC2kTWBpUY26tysISGNGH9oycJOPCp6FV4OUfTo1E3UDyxjbpS8L7 OK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695270946; x=1695875746; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+XOWCR9KFhMn8+2HIiXvxelBlhmHeyj33dGAiBogAcY=; b=VdtDAO96LJ98nWqIiee6dDkWF1W03ZUIiSd+HV0NV3QuHoluMkSO8ySmoIMza5RYH7 mhjLPZxR+XsBXBWQltOhk74EVDs/Rj/KvgMu10L3suGdpW6gu82i8OvHGT11zMcm+9pH hsC1BeRflK5rePNo4gXSruLDfrG9j2LJGi40vg0jfezPxi9gnVv05lsTJpx5iTTHXK3p JkAzHKRQju/5qizURRREXVLHaRFSUAnerc05d+VvHvQB5s5MtPtHo1AHbii7qfLwvJqs uF/5xy1H8H/eluLtuGlg17REy53orMM/JutCacfifk4+wGC100t7pxGirnY1+LUbH/QR u5CA== X-Gm-Message-State: AOJu0YzQmPB7uyxaANXJ0yv5We1ZW31KagIA6JFJtZRC3bQ+SV+qm80h oVXoWUDbQL6i+vctemI1bMvis6gbtNfLXa1CtUMfJQ== X-Google-Smtp-Source: AGHT+IEFSRHKBif1+HP9GrYM6+neB/CcEtnQDjQ8cSHyukdalwNAuQikvVA9WNLlKgbZXr1NPKWtlgJXRZJogTdQErE= X-Received: by 2002:a1f:c386:0:b0:496:ca46:f0c8 with SMTP id t128-20020a1fc386000000b00496ca46f0c8mr3795119vkf.16.1695270945594; Wed, 20 Sep 2023 21:35:45 -0700 (PDT) MIME-Version: 1.0 References: <52272237-a3cd-23a4-cbc7-e6a53cbf2c85@kernel.org> In-Reply-To: From: Stanislav Fomichev Date: Wed, 20 Sep 2023 21:35:34 -0700 Message-ID: To: "Song, Yoong Siang" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UNZPKESDQNRI5ULXGIJDIBGAOVP422KE X-Message-ID-Hash: UNZPKESDQNRI5ULXGIJDIBGAOVP422KE X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jesper Dangaard Brouer , "t, Thomas" , "Abdul Rahim, Faizal" , "Dupont, Fabien" , "Chavez, Robert" , "Zaremba, Larysa" , Alexei Starovoitov , Daniel Borkmann , "Gament, Costin" , Jakub Kicinski , Daniel Bristot de Oliveira , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Felix Maurer , "Desouza, Ederson" , "Maloor, Kishen" , "xdp-hints@xdp-project.net" X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: Interest in TX-side XDP metadata hints from Intel (+ Red Hat) List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Sep 20, 2023 at 7:10=E2=80=AFPM Song, Yoong Siang wrote: > > On Friday, September 15, 2023 5:06 AM, Stanislav Fomichev wrote: > >On Wed, Sep 13, 2023 at 6:22=E2=80=AFPM Song, Yoong Siang > > wrote: > >> > >> On Saturday, September 9, 2023 12:38 AM Stanislav Fomichev > > wrote: > >> >On Fri, Sep 8, 2023 at 7:18=E2=80=AFAM Jesper Dangaard Brouer > >> > > >> >wrote: > >> >> > >> >> Hi Stanislav, > >> >> > >> >> Sharing that Intel (+Red Hat) have an interest in getting XDP > >> >> metadata hints working on smaller devices used for "Edge Controls f= or > >Industrial" > >> >> (ECI)[1]. > >> >> > >> >> What are your plans for your patchset[2] ? > >> > > >> >Sorry, I was OOO for two weeks and then got distracted by some > >> >internal work :- ( I'll probably post another respin next week. I > >> >think I've addressed most of the Maciej's feedback, but the only > >> >thing that we need to move this forward is to support another device > >> >besides mlx5. Maciej was suggesting ice, but I don't have the hw :-( > >> >I have some idfp-capable devices, so I'll probably try to play with i= t instead (but > >the idpf driver is still not pulled). > >> > > >> >So if you want to help speed it up, we should probably focus first on > >> >getting some of the intel nics support tx metadata. > >> >To proceed, maybe I should post my next iteration and we can > >> >collaborate on the ice driver changes? > >> >Who should I CC explicitly? > >> > > >> Hi Stanislav, > >> > >> I can help to speed it up. I don't have ice HW on my hand as well, so > >> maybe we can start with igc drivers, followed by stmmac drivers. > >> > >> Please post your next iteration, then we can collaborate based on that= . > > > >Awesome, thanks! The v2 is out, you're on the CC. Feel free to reach out= directly > >if you have any questions or suggestions. > > Hi Stanislav, > > Thanks for the v2. I do have one question. What is the code base which yo= u are using? > When I try to apply your v2 patch set on top of latest net-next, there ar= e few merge conflicts, > and it seem like Rx Metadata is not included in your base. Anything prior to my recent commit "bpf: make it easier to add new metadata kfunc" should work. That's most likely the reason it conflicts. So try to cherry pick it on top of the following and let me know if you still have an issue; I can rebase and repost: 5c04433daf9e - bpf: Charge modmem for struct_ops trampoline (6 days ago) Regarding rx metadata: it's separate from af_xdp and it's more generically implemented in the xdp layer, see: Documentation/networking/xdp-rx-metadata.rst Also see tools/testing/selftests/bpf/prog_tests/xdp_metadata.c for an example on how to use both rx and tx sides. > Thanks & Regards > Siang > > > > >I also have to abaon my idea of playing with idpf since the driver that'= s posted on > >the list doesn't have af_xdp support :-( > > > > > >> Thanks & Regards > >> Siang > >> > >> >> My suggestion (to Intel) is that we implement the TX-timestamp > >> >> (plus > >> >> LaunchTime) on top of Stanslav's patches[2]. For drivers > >> >> igc+igb+stmmac which I think will cover the tests[3] need by > >> >> Arun/Costin (?). And then post it upstream for review. > >> >> > >> >> The Intel test tool[3] isn't open, but it is an AF_XDP based > >> >> Real-Time Compute Performance (RTCP) application that show-case a > >> >> real-time control loop application. The current code uses out-of-t= ree[4] > >"TXTIME" > >> >> LaunchTime feature, that want not upstreamed. > >> >> > >> >> Lets us instead implement a proper TX LaunchTime feature on top of = [2]. > >> >> > >> >> --Jesper > >> >> cc. XDP-hints ML as anyone is free to code this up, code help > >> >> here[5] > >> >> > >> >> > >> >> [1] https://eci.intel.com/ > >> >> [2] > >> >> https://lore.kernel.org/all/20230809165418.2831456-1-sdf@google.com > >> >> / [3] https://github.com/OTCShare2/rtcp-xdp > >> >> [4] https://lore.kernel.org/all/20210621230635.3a83851c@carbon/ > >> >> [5] > >> >> https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/co > >> >> de0 1_follow_qdisc_TSN_offload.org#tx-time-to-hardware-driver-igc