From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by mail.toke.dk (Postfix) with ESMTPS id 2A3CDA2B94D for ; Thu, 21 Sep 2023 18:24:17 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=HTDFm5bw Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-495ea3299b0so466958e0c.2 for ; Thu, 21 Sep 2023 09:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695313453; x=1695918253; darn=xdp-project.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vzSle6jzRy4ZvyLMLatHFkDlFBoQvkk+K2SWuK1TMoI=; b=HTDFm5bwVnBCCXHIcuVjKwidi9dlRdF9Lm4u9Q71/vgsI5+sMDnmQN3o94iSOPHwt3 sMOxWoczFMSE3YfXWzC40h8NrfoM2dVXfB3eo2gDTITwjI0hvrg2eQl5UgQ4JayAI+gC oOsODfe8XiF0bUDlWO/plRvY+JnbCfrquY24czyY2sh5wHjZMDNqcwVlXT/tnRE2E4+e ypCyv+9wWlADFNNOh/GEEuq31Fz+VHxbHQ6zTsBiE2pEv3vCdnvprhN3jIRcJPRv2PI5 ZMjnlasgcswo3covYRRYG+WoeWs3kBr26WH+adMmkVuNhI5jkhI9WrTN05quDcMpdbnm dqag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695313453; x=1695918253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vzSle6jzRy4ZvyLMLatHFkDlFBoQvkk+K2SWuK1TMoI=; b=n3djl+Vlb8nn+wnAkgtglDJ0oDgwFa2o9NLWgDHRQM5Vvi1Dc0XHHfGiv8+OD1r6bw DdPQUmq+FTj53ugtRJ9qTVVHyon6Edwc/iC+8M1K7Q3oT8XurqBB0aaT0zJwwrHqO41P 8fVPU6QIQJ2V73NvUtj76tDmHrvG+h+dm3fjxtUu8ijE36M52cLPGFQpN9FiiJJRw+58 PYa67lCkMR79GX4ty//CcjRhV1Kk1tR2h+9qB0a4Jk+IR428ML8NjUFLu7tK+Duc5e6x t0DKDo1BJX3HMqveBjdq7PLwsexVGiW6ShiQ3wZ53zcNPLSw/6MqRcxP6l1GRZV93ZSs 0dTg== X-Gm-Message-State: AOJu0YyhvnCSQChnhhysI5+ZgFw3vaqz8ltVo7yeS8CxpGYI80v6Uq8c BOvU0pFoh36LMQbEzWuo6MhcdvdvlffUi4jgHeBsnw== X-Google-Smtp-Source: AGHT+IF+lfE4aOKQsodDepJdxtFxYCtk8LqXuZSBGJO7NZuyZa/KYe2yJtKyzgxpiwSjM5MQMDi1ahDGTrUOmgppPu4= X-Received: by 2002:a1f:c684:0:b0:495:c929:a121 with SMTP id w126-20020a1fc684000000b00495c929a121mr5100692vkf.3.1695313452919; Thu, 21 Sep 2023 09:24:12 -0700 (PDT) MIME-Version: 1.0 References: <52272237-a3cd-23a4-cbc7-e6a53cbf2c85@kernel.org> In-Reply-To: From: Stanislav Fomichev Date: Thu, 21 Sep 2023 09:24:01 -0700 Message-ID: To: "Song, Yoong Siang" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VQPG6D5BL3FTGLSVGJ62BG3VFRGTVIGA X-Message-ID-Hash: VQPG6D5BL3FTGLSVGJ62BG3VFRGTVIGA X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jesper Dangaard Brouer , "t, Thomas" , "Abdul Rahim, Faizal" , "Dupont, Fabien" , "Chavez, Robert" , "Zaremba, Larysa" , Alexei Starovoitov , Daniel Borkmann , "Gament, Costin" , Jakub Kicinski , Daniel Bristot de Oliveira , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Felix Maurer , "Desouza, Ederson" , "Maloor, Kishen" , "xdp-hints@xdp-project.net" X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: Interest in TX-side XDP metadata hints from Intel (+ Red Hat) List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Sep 21, 2023 at 1:17=E2=80=AFAM Song, Yoong Siang wrote: > > On Thursday, September 21, 2023 12:36 PM, Stanislav Fomichev wrote: > >On Wed, Sep 20, 2023 at 7:10=E2=80=AFPM Song, Yoong Siang > > wrote: > >> > >> On Friday, September 15, 2023 5:06 AM, Stanislav Fomichev > >wrote: > >> >On Wed, Sep 13, 2023 at 6:22=E2=80=AFPM Song, Yoong Siang > >> > wrote: > >> >> > >> >> On Saturday, September 9, 2023 12:38 AM Stanislav Fomichev > >> > wrote: > >> >> >On Fri, Sep 8, 2023 at 7:18=E2=80=AFAM Jesper Dangaard Brouer > >> >> > > >> >> >wrote: > >> >> >> > >> >> >> Hi Stanislav, > >> >> >> > >> >> >> Sharing that Intel (+Red Hat) have an interest in getting XDP > >> >> >> metadata hints working on smaller devices used for "Edge > >> >> >> Controls for > >> >Industrial" > >> >> >> (ECI)[1]. > >> >> >> > >> >> >> What are your plans for your patchset[2] ? > >> >> > > >> >> >Sorry, I was OOO for two weeks and then got distracted by some > >> >> >internal work :- ( I'll probably post another respin next week. I > >> >> >think I've addressed most of the Maciej's feedback, but the only > >> >> >thing that we need to move this forward is to support another > >> >> >device besides mlx5. Maciej was suggesting ice, but I don't have > >> >> >the hw :-( I have some idfp-capable devices, so I'll probably try > >> >> >to play with it instead (but > >> >the idpf driver is still not pulled). > >> >> > > >> >> >So if you want to help speed it up, we should probably focus first > >> >> >on getting some of the intel nics support tx metadata. > >> >> >To proceed, maybe I should post my next iteration and we can > >> >> >collaborate on the ice driver changes? > >> >> >Who should I CC explicitly? > >> >> > > >> >> Hi Stanislav, > >> >> > >> >> I can help to speed it up. I don't have ice HW on my hand as well, > >> >> so maybe we can start with igc drivers, followed by stmmac drivers. > >> >> > >> >> Please post your next iteration, then we can collaborate based on t= hat. > >> > > >> >Awesome, thanks! The v2 is out, you're on the CC. Feel free to reach > >> >out directly if you have any questions or suggestions. > >> > >> Hi Stanislav, > >> > >> Thanks for the v2. I do have one question. What is the code base which= you are > >using? > >> When I try to apply your v2 patch set on top of latest net-next, there > >> are few merge conflicts, and it seem like Rx Metadata is not included = in your > >base. > > > >Anything prior to my recent commit "bpf: make it easier to add new metad= ata > >kfunc" should work. That's most likely the reason it conflicts. > >So try to cherry pick it on top of the following and let me know if you = still have an > >issue; I can rebase and repost: > >5c04433daf9e - bpf: Charge modmem for struct_ops trampoline (6 days > >ago) > > This base work for me. Thanks. > Btw, how we should collaborate? > After done coding and testing on my side, I send you my patches, > then you will include them into your patchset v3? Yeah, that works for me. Unless you have better ideas :-) > >Regarding rx metadata: it's separate from af_xdp and it's more generical= ly > >implemented in the xdp layer, see: > >Documentation/networking/xdp-rx-metadata.rst > > > >Also see tools/testing/selftests/bpf/prog_tests/xdp_metadata.c for an ex= ample > >on how to use both rx and tx sides. > > > >> Thanks & Regards > >> Siang > >> > >> > > >> >I also have to abaon my idea of playing with idpf since the driver > >> >that's posted on the list doesn't have af_xdp support :-( > >> > > >> > > >> >> Thanks & Regards > >> >> Siang > >> >> > >> >> >> My suggestion (to Intel) is that we implement the TX-timestamp > >> >> >> (plus > >> >> >> LaunchTime) on top of Stanslav's patches[2]. For drivers > >> >> >> igc+igb+stmmac which I think will cover the tests[3] need by > >> >> >> Arun/Costin (?). And then post it upstream for review. > >> >> >> > >> >> >> The Intel test tool[3] isn't open, but it is an AF_XDP based > >> >> >> Real-Time Compute Performance (RTCP) application that show-case > >> >> >> a real-time control loop application. The current code uses > >> >> >> out-of-tree[4] > >> >"TXTIME" > >> >> >> LaunchTime feature, that want not upstreamed. > >> >> >> > >> >> >> Lets us instead implement a proper TX LaunchTime feature on top = of [2]. > >> >> >> > >> >> >> --Jesper > >> >> >> cc. XDP-hints ML as anyone is free to code this up, code help > >> >> >> here[5] > >> >> >> > >> >> >> > >> >> >> [1] https://eci.intel.com/ > >> >> >> [2] > >> >> >> https://lore.kernel.org/all/20230809165418.2831456-1-sdf@google. > >> >> >> com / [3] https://github.com/OTCShare2/rtcp-xdp > >> >> >> [4] https://lore.kernel.org/all/20210621230635.3a83851c@carbon/ > >> >> >> [5] > >> >> >> https://github.com/xdp-project/xdp-project/blob/master/areas/tsn > >> >> >> /co > >> >> >> de0 > >> >> >> 1_follow_qdisc_TSN_offload.org#tx-time-to-hardware-driver-igc