From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by mail.toke.dk (Postfix) with ESMTPS id 10E6D9DCFAF for ; Thu, 12 Jan 2023 19:09:37 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=EGNwY0DC Received: by mail-pf1-x433.google.com with SMTP id 20so8975871pfu.13 for ; Thu, 12 Jan 2023 10:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t5QBMr0sFk9XRgwIjiMT2tjfg7T94fJD5dd8LZESWzw=; b=EGNwY0DCO8idBlmOgRTnbr2+2Hi3QRuLGLlFONP3uXnMFbSk4B0glkItsDkVlXxxcV asXL/RZQH1qXcWTYGYX5xdr1iBYmkVazXCdDTU7/iLkKjFjS67AWxZvNxlRY4BS7ZzBQ fLoLmrA2Mf9RE9lnrzsKY72wBej3ezlhdJQQrlkXzQzaytdEJxlZ1thtevCgJknHGnU6 5SU0jDstU66bKFYHex6iIVEfFuL41CySCsyWi8U/tWhGHRAu30WgBInWTUNUuWWdftri 4UMjPfsJNnRjijb/jSmDTq5Lzi1Fe4gmM6rhZnWqf6GeFTwKgKwdk03+Ufc/lfY+if2w aRsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t5QBMr0sFk9XRgwIjiMT2tjfg7T94fJD5dd8LZESWzw=; b=O/NZwt9t+j3Uo2pOjIRkRsMEQ6JNYQM/AVWxiukAOcLsJ8xCtpA9ZnfXWzp8RFBWhH Z9mAVUFpHmnWB2ltaxN5C4nL56MgYiO/yFrSIUeQ0qdZKYkDE1ZgR0tC5Kho6HMsoGeP xJgIusZZNV+nzqdSFl9lU1AGG0a4aK7QsaTsnYJ8UVJDSFnuIl+E/QW5CsDi/wPo0Onl eimTddic5OiYXeZ7s+imXWy6dhQ7wcwJ7LhOjrpH8KQxtGFttNvSIkwr+zMmlth568mZ Oj6wb2mQgHXbGRQbuttaB+ULDN4ddJ9PFDTKGytd6gwpjxZlc6mivk2JmDE8kLA7AJP1 kF6Q== X-Gm-Message-State: AFqh2kqEcLmGQXxGQf9w09sYBWU5KVvKMZ4Rov2aplHKLppFNL8V85OX vuulKNxDV0aK9ND9GQjVFwhMuRErmjG1IEFQ2NZhwQ== X-Google-Smtp-Source: AMrXdXu++3Jmlz5p16BLzI03q73YycsK1MGuj3lkgQ3wo57iGRPaENAIwmYCqwFP5/VC2KYMqzQsRQ8WgCRYKCO4mJo= X-Received: by 2002:a63:9d0a:0:b0:49f:478d:a72c with SMTP id i10-20020a639d0a000000b0049f478da72cmr3327579pgd.250.1673546975069; Thu, 12 Jan 2023 10:09:35 -0800 (PST) MIME-Version: 1.0 References: <20230112003230.3779451-1-sdf@google.com> <2f76e7d6-1771-a8f5-4bd1-6f7cd0b59173@gmail.com> In-Reply-To: <2f76e7d6-1771-a8f5-4bd1-6f7cd0b59173@gmail.com> From: Stanislav Fomichev Date: Thu, 12 Jan 2023 10:09:23 -0800 Message-ID: To: Tariq Toukan Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: 2VHD6IB5BVMZRF5BSK2T2AEIGT5HMPOS X-Message-ID-Hash: 2VHD6IB5BVMZRF5BSK2T2AEIGT5HMPOS X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , Tariq Toukan , Saeed Mahameed , bpf@vger.kernel.org, xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v7 00/17] xdp: hints via kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Jan 12, 2023 at 12:19 AM Tariq Toukan wrote: > > > > On 12/01/2023 9:29, Martin KaFai Lau wrote: > > On 1/11/23 4:32 PM, Stanislav Fomichev wrote: > >> Please see the first patch in the series for the overall > >> design and use-cases. > >> > >> See the following email from Toke for the per-packet metadata overhead: > >> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > >> > >> Recent changes: > >> > >> - Bring back parts that were removed during patch reshuffling from "bpf: > >> Introduce device-bound XDP programs" patch (Martin) > >> > >> - Remove netdev NULL check from __bpf_prog_dev_bound_init (Martin) > >> > >> - Remove netdev NULL check from bpf_dev_bound_resolve_kfunc (Martin) > >> > >> - Move target bound device verification from bpf_tracing_prog_attach into > >> bpf_check_attach_target (Martin) > >> > >> - Move mlx5e_free_rx_in_progress_descs into txrx.h (Tariq) > >> > >> - mlx5e_fill_xdp_buff -> mlx5e_fill_mxbuf (Tariq) > > > > Thanks for the patches. The set lgtm. > > > > The selftest patch 11 and 17 have conflicts with the recent changes in > > selftests/bpf/xsk.{h,c} and selftests/bpf/Makefile. eg. it no longer > > needs XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD, so please respin. From a > > quick look, it should be some minor changes. > > > > Not sure if Tariq has a chance to look at the mlx5 changes shortly. The > > set is getting pretty long and the core part is ready with veth and mlx4 > > support. I think it is better to get the ready parts landed first such > > that other drivers can also start adding support for it. One option is > > to post the two mlx5 patches as another patchset and they can be > > reviewed separately. > > > > Hi, > I posted new comments. > I think they can be handled quickly, and still be part of the next respin. > > I'm fine with both options though. You can keep the mlx5e patches or > defer them to a followup series. Whatever works best for you. Either way is fine with me also. I can find some time today to address Tariq's comments and respin if that works for everybody. > Tariq