From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by mail.toke.dk (Postfix) with ESMTPS id 5D8649E3497 for ; Tue, 24 Jan 2023 18:35:58 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=FWddA1QM Received: by mail-pj1-x1032.google.com with SMTP id z9-20020a17090a468900b00226b6e7aeeaso14725618pjf.1 for ; Tue, 24 Jan 2023 09:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3Xdvi7fIlYYO+f7EySJG/JTcc0Pmw2obhupOEULGvoM=; b=FWddA1QM2tSZl3bk6p8veEjjy+nIv282XwDrC4a72f1F1DbSvsofCGGY+Q9+ZIbcAo QzXs/ug7zKW5kEDStV6Hy2EfXks+nwn/a5t2lHc1Ds06qzXIrmAb1yYa/Pzlj7y3cZk/ J521plLn8oh6VREwqCOHqX9q92I4LA7kTMJUgnwHGsJS2MLGVC8vWy57X2f6tINr+N+E tG3WNTmrXx3WDDptWXxAtbnIF4Pkt6ZITJ65E/cCXY620PwSyejDwHZSo63dKtwpnUDj E/VDG4s56h9BDSwQKdzPaUdNoxWLYP49ryGmd1r2eaVXfi5yvcSJMo33tZnLkLqqN7nz eshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Xdvi7fIlYYO+f7EySJG/JTcc0Pmw2obhupOEULGvoM=; b=DnpRfNpACPEgVvo2BDtHVmUlT7eQbYMmCQE+wIRr0uPn6PSt+jJ+nU6rIlk6LcXJNh lULaHX6IZDHLtuLCis9rTPLHcY9hKHduvTnceM9adv1i99rdvBmtge+Sk33JIYnyMl8P +fPrpMr388F16/foo1u91JS4Xa5jP9jJulGvbp4BUFaGQwjgI4gKga0O0+9a1gOsbd4F f5oRDRMrr0dIoTOEsxCcATualZojDLEQe1PsrQ/QK7HBLl0QWA1ukmFktW0nihlcO55g IUuYSohiI/sfWnOjIo+jv30kGeK1mPDUG+BlVsrAB6u31BvYGxnGVb0m3Nd0MzVQwquz tLDg== X-Gm-Message-State: AFqh2krHj0I3YukUJXejNrWzP3N48QOIyBz/RuQmL6KyR8Ld4MUVnftH Kx4/0L5r2jyJOUDnKgwb+J/kzTQKhagrIVW3n2zYtA== X-Google-Smtp-Source: AMrXdXsevx4h6ZcmBSNEUhpYybXYrpwt4VnRJPSPjl6wWgpUFF5obP1UAhJ0j2Qd5E0Ab3ihQWJJqoZ8/uJYeLh0WmU= X-Received: by 2002:a17:90b:3741:b0:219:fbc:a088 with SMTP id ne1-20020a17090b374100b002190fbca088mr4176615pjb.162.1674581755350; Tue, 24 Jan 2023 09:35:55 -0800 (PST) MIME-Version: 1.0 References: <20230119221536.3349901-1-sdf@google.com> <901e1a7a-bb86-8d62-4bd7-512a1257d3b0@linux.dev> <5b757a2a-86a7-346c-4493-9ab903de19e4@intel.com> <87lelsp2yl.fsf@toke.dk> In-Reply-To: From: Stanislav Fomichev Date: Tue, 24 Jan 2023 09:35:42 -0800 Message-ID: To: Jesper Dangaard Brouer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VTSXJXEOXMACLC27M4YJNSDKGV2ICGUI X-Message-ID-Hash: VTSXJXEOXMACLC27M4YJNSDKGV2ICGUI X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Alexander Lobakin , brouer@redhat.com, Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Anatoly Burakov , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, bpf@vger.kernel.org, Jesse Brandeburg , Tony Nguyen X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jan 24, 2023 at 4:23 AM Jesper Dangaard Brouer wrote: > > > On 24/01/2023 12.49, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Alexander Lobakin writes: > > > >> From: Stanislav Fomichev > >> Date: Mon, 23 Jan 2023 10:55:52 -0800 > >> > >>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau wrote: > >>>> > >>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote: > >>>>> Please see the first patch in the series for the overall > >>>>> design and use-cases. > >>>>> > >>>>> See the following email from Toke for the per-packet metadata overh= ead: > >>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com= /T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798 > >>>>> > >>>>> Recent changes: > >>>>> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops'= (Tariq) > >>>>> > >>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq) > >>>>> > >>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper) > >>>>> > >>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata size = (Jesper) > >>>>> > >>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instea= d > >>>>> of ifname (due to recent xsk.h refactoring) > >>>> > >>>> Applied with the minor changes in the selftests discussed in patch 1= 1 and 17. > >>>> Thanks! > >>> > >>> Awesome, thanks! I was gonna resend around Wed, but thank you for > >>> taking care of that! > >> Great stuff, congrats! :) > > > > Yeah! Thanks for carrying this forward, Stanislav! :) Thank you all as well for the valuable feedback and reviews! > +1000 -- great work everybody! :-) > > To Alexander (Cc Jesse and Tony), do you think someone from Intel could > look at extending drivers: > > drivers/net/ethernet/intel/igb/ - chip i210 > drivers/net/ethernet/intel/igc/ - chip i225 > drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports > > We have a customer that have been eager to get hardware RX-timestamping > for their AF_XDP use-case (PoC code[1] use software timestamping via > bpf_ktime_get_ns() today). Getting driver support will qualify this > hardware as part of their HW solution. > > --Jesper > [1] > https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interactio= n/af_xdp_kern.c#L77 >