From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by mail.toke.dk (Postfix) with ESMTPS id 5D18D9D315F for ; Wed, 21 Dec 2022 18:50:02 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=r4lH5LeY Received: by mail-pj1-x1034.google.com with SMTP id u4-20020a17090a518400b00223f7eba2c4so2787361pjh.5 for ; Wed, 21 Dec 2022 09:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0okM7NEH56GTLxrsjv/YOjxBUK47FbcHwJd4q/7wuwc=; b=r4lH5LeYghxEzkjEKOKSPOpc0vK/et2vfbW3dmlbnk1REJkKOzQCA7hZrEHp6jCUqQ uMJHyNonZmLJWeOsaPh8IiXXI6tLhq7z8kSNqDJ+oQZRQGJX0cyNX0IaHBCW+DYp3t93 Gxlk5v/1xidZpNvOumnvx+saJ+5LfMkfrLGqhgvMymffdrOpbTxOE3Ecf6f7b0F8h4RZ GXlB0T0uHmd6e9ako0won5PJYZ1goLhR0GXU2L5bRMcAN8f1sMRFGX7KdYYaqqrxesQX GJutFsZ6/FN9ThNzO/TwSunRd983i4FVpU2pOmyyeq/OWFNJxHtp2TA0OzDLy1zRB+f4 J/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0okM7NEH56GTLxrsjv/YOjxBUK47FbcHwJd4q/7wuwc=; b=q1LmgraxiqMfTKW0fpha1U410I12RGSzqtrrerVMPsWrHi3KCNytvcDLgRnxeHgl/5 IzA7gOMfu5ZgkSXt1cIh8WAap/C+W1EYuDSr10twDKd1SxDor1qZoRjQOMueR/iKCPmb fkZlSYQRTezjT6VdbxzdSGFTRqEFhdqmuCx6HV5b8BlBF5/ZVrPhSM7iPv0fsIpJwovF kIsBszteQm1qxnD7rqFJIqCIZc5wTWwOtdtJPadNHEO+R9aA/Jyc8NnJJUEqz8uaaJrz LFcFYS9w280K4z3NRutG9+nYBYDrr+XivgLDC1PVMtXwIW9eOcEFsPR4JWhwpqdEMK06 uKcA== X-Gm-Message-State: AFqh2kqaEiE6nJzW5J6ZoSr0SmJTBxNPQlZJCmsHarC+BIKSTem1X2Or EuI93AFF6w79MW4ajgKbJpTpnMcMY5sNrARtv5NLow== X-Google-Smtp-Source: AMrXdXt4va1LWYg05e9TZvMFRB9O6tjGCTg8ZU2ZeuInrCz0REtR64vqnk18LhwpYQQR7Wx7cI12zyqbtLeerbbvgIo= X-Received: by 2002:a17:903:2696:b0:189:e426:463e with SMTP id jf22-20020a170903269600b00189e426463emr121651plb.134.1671645000756; Wed, 21 Dec 2022 09:50:00 -0800 (PST) MIME-Version: 1.0 References: <20221220222043.3348718-8-sdf@google.com> <202212211311.e2ZWQLue-lkp@intel.com> In-Reply-To: <202212211311.e2ZWQLue-lkp@intel.com> From: Stanislav Fomichev Date: Wed, 21 Dec 2022 09:49:49 -0800 Message-ID: To: kernel test robot Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: NDA3374GB7SHKAARL2P5PADP2W5MGKQQ X-Message-ID-Hash: NDA3374GB7SHKAARL2P5PADP2W5MGKQQ X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, oe-kbuild-all@lists.linux.dev, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v5 07/17] bpf: XDP metadata RX kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Dec 20, 2022 at 9:44 PM kernel test robot wrote: > > Hi Stanislav, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/xdp-hints-via-kfuncs/20221221-110542 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > patch link: https://lore.kernel.org/r/20221220222043.3348718-8-sdf%40google.com > patch subject: [PATCH bpf-next v5 07/17] bpf: XDP metadata RX kfuncs > config: ia64-allyesconfig > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/f0946bf20669262734baef03ae12ef189c9c9292 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Stanislav-Fomichev/xdp-hints-via-kfuncs/20221221-110542 > git checkout f0946bf20669262734baef03ae12ef189c9c9292 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash kernel/bpf/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> kernel/bpf/verifier.c:2084:5: warning: no previous prototype for 'bpf_dev_bound_kfunc_check' [-Wmissing-prototypes] > 2084 | int bpf_dev_bound_kfunc_check(struct bpf_verifier_env *env, > | ^~~~~~~~~~~~~~~~~~~~~~~~~ Oops, this should be "static int bpf_dev_bound_kfunc_check" :-( > vim +/bpf_dev_bound_kfunc_check +2084 kernel/bpf/verifier.c > > 2083 > > 2084 int bpf_dev_bound_kfunc_check(struct bpf_verifier_env *env, > 2085 struct bpf_prog_aux *prog_aux) > 2086 { > 2087 if (!bpf_prog_is_dev_bound(prog_aux)) { > 2088 verbose(env, "metadata kfuncs require device-bound program\n"); > 2089 return -EINVAL; > 2090 } > 2091 > 2092 if (bpf_prog_is_offloaded(prog_aux)) { > 2093 verbose(env, "metadata kfuncs can't be offloaded\n"); > 2094 return -EINVAL; > 2095 } > 2096 > 2097 return 0; > 2098 } > 2099 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp