From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by mail.toke.dk (Postfix) with ESMTPS id 4F7EE9CD0EE for ; Thu, 8 Dec 2022 20:07:13 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=l+5tyS5B Received: by mail-pj1-x1034.google.com with SMTP id t17so2461489pjo.3 for ; Thu, 08 Dec 2022 11:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XCQxkSX68wqC+xYZ6HcQAhvyVD70BBTOb/sZXInwVAc=; b=l+5tyS5BrFG6cf5CmXiStrreFA3TGHQ36+ParPAf3rG87vze/JHPDMtR7EeTQeNR94 yguiOl7brDY/rJc5yv5m2NledHuTzRUTXwpT+ORLysWopKGEwDQovasRrU7iGqzYBBpY YKOtN+ifQPRa4bj4DjVNCA+WlZkxACeBckdHvlmdgmxTRSrVNbUe+G/FvopjcvWL8Llh iPm3428sT5eSj5S1GLBTuq1azMha4EP3hQKvitB4+dRpHw8dXSA/zoMWf+6yZycKQ2Qn ATEwbWyIlXNWS1+w4Y2MRJh/DniR1bUjRLvuzKXCtmuMxWY6qcWlrpo1YEmdt1lTm3T5 5J2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XCQxkSX68wqC+xYZ6HcQAhvyVD70BBTOb/sZXInwVAc=; b=gBTklo1if5mKvE8kWkq40XZ8cgRzb94rA2wE+uzmKCHkhmW/nvnUz4inVWfzGsyFyY qcsJR0umguiYjV8eS2NObWtnCUYf9aqOgakWFu9ieLsj6dt4Lr3gXn/+e9ZP+tNMjMB4 ggVYUKbCOBg7y/Ck/2jjk1ijIuN0x1xDBb3TPBGrSGTENkAk8CbSD94t+yOf4jV2/SqA 2sKgmEaPYmbZHSMQJ3mJm1Z4E0MjbzPkpdz/BOhPDuz02h5eSz6FhIKkV00t5JctQoIo XPFeRcW9iGp74rTh+m3zFNvLC9DXFTZMVPwCAVA1uFZHVp2EyOXm/B5Z8nNh4EZJ1ubR 6O+g== X-Gm-Message-State: ANoB5pmAfBVVmftlK/TWayNyEMGn1r0Su5nNE4Cxtc3JiilLQ3ixdsTG dIgtp+OCRBzAnZdo9B3b6D0v3mC0gkXP8OAfJyfv3g== X-Google-Smtp-Source: AA0mqf7GaWTmzlI1QGFsZj/CjVKeCEsobuxFLQxykjospoKh+9QAVnRypOnNrGnI2H6/m62ad0FEPf3+7rh6Jigf0gM= X-Received: by 2002:a17:902:d711:b0:188:c7b2:2dd with SMTP id w17-20020a170902d71100b00188c7b202ddmr79046589ply.88.1670526431719; Thu, 08 Dec 2022 11:07:11 -0800 (PST) MIME-Version: 1.0 References: <20221206024554.3826186-1-sdf@google.com> <20221206024554.3826186-2-sdf@google.com> <20221207202559.4d507ccf@kernel.org> In-Reply-To: <20221207202559.4d507ccf@kernel.org> From: Stanislav Fomichev Date: Thu, 8 Dec 2022 11:06:59 -0800 Message-ID: To: Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: D5YEFIERHRZXVLWPS5VMAYEEWJ6CLGTR X-Message-ID-Hash: D5YEFIERHRZXVLWPS5VMAYEEWJ6CLGTR X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v3 01/12] bpf: Document XDP RX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Dec 7, 2022 at 8:26 PM Jakub Kicinski wrote: > > On Mon, 5 Dec 2022 18:45:43 -0800 Stanislav Fomichev wrote: > > +- ``bpf_xdp_metadata_rx_timestamp_supported`` returns true/false to > > + indicate whether the device supports RX timestamps > > +- ``bpf_xdp_metadata_rx_timestamp`` returns packet RX timestamp > > +- ``bpf_xdp_metadata_rx_hash_supported`` returns true/false to > > + indicate whether the device supports RX hash > > +- ``bpf_xdp_metadata_rx_hash`` returns packet RX hash > > Would you mind pointing to the discussion about the separate > _supported() kfuncs? I recall folks had concerns about the function > call overhead, and now we have 2 calls per field? :S Take a look at [0] and [1]. I'm still assuming that we might support some restricted set of kfuncs that can be unrolled so keeping this simple/separate apis. 0: https://lore.kernel.org/bpf/CAADnVQJMvPjXCtKNH+WCryPmukgbWTrJyHqxrnO=2YraZEukPg@mail.gmail.com 1: https://lore.kernel.org/bpf/Y4XZkZJHVvLgTIk9@lavr/