From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by mail.toke.dk (Postfix) with ESMTPS id 97267A3B5C2 for ; Thu, 9 Nov 2023 19:07:29 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=0rGMP6jB Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-4ac89e8e964so494399e0c.3 for ; Thu, 09 Nov 2023 10:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699553248; x=1700158048; darn=xdp-project.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q5jof2dMXbvUyv/2d3eh8cYmtslz7u0wbU9sqNUptZw=; b=0rGMP6jBfZjokp6drxdYf2MUftvD0qKotC8FCQGdgICyh5bplNobVujAnjSgO2Y8FJ OAekYN7uRONR1OrPlx9aG89+qv1MDmTHi02w2rI/xT2j+juFeU+yWBMDTzziazo6KNYb ABxOB2GmujnCf8/AjfEaycIYqkpcQFA4a94UFHinrukqYJtitnm0WdTgwDZCwKxc41uL kCxVX1/ZWE2PVBIoXFgE0lrXdEH77hxiKG4KrHu6atgq/ttChwE8iyr8mJ7U1Hsa93iI lTx285kkCqvMJG3YDgxzWRKXXi+C4n5GNK+1zmW8Guxe5SZRhyJDqYPj1nODu9kig59j lUKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699553248; x=1700158048; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q5jof2dMXbvUyv/2d3eh8cYmtslz7u0wbU9sqNUptZw=; b=aSXQvZx6ngizUNhJtX2GErWgTQ792NGfQAh0re4bSnXEc/ejRUk61VCp4+cl/ankcs a0AkE3YAu5d+IFKKheHZDQ+k9of+rcP+gusWWIFpjw613Gm6csaw29wk5O0MyK6gtDSm sdPjz0OAVnWrdGBP9JGUTcB5bV+WNOYohf/Zj6GXZUFMetZU/KpwD/Q2ktW6S8lV1Sop /5Yt8M0iiPsogfYwPmnWxGcuIy8OicM7AClIhnjQ8yNsozvZ8xR5OvVWnMVu+gf+fpZb ovUpI6MXTYkl7OLhJPjMGzpTk6HW0cECcsZ4qJQLfZO3ZIfAoUjUI2zpNXdm2BUwvAOB Xm3Q== X-Gm-Message-State: AOJu0YwYmN8PshkEaEEXOomlIhY3OJzR/NYOr1SyQFOFCeuwdpEjHNg0 S/MwfQSo4W+X/hiySEH/l+4FQctZIYkU5yo2Zacugg== X-Google-Smtp-Source: AGHT+IEnm0GQvFTNs/hpK2AqwHKtIdbux6hL2chbJDT/1nnPxaXSEMiQmybsy0eZF4F5OgkJ1E0jEiVEkvhvNTuTRrY= X-Received: by 2002:a05:6122:1799:b0:49c:79f3:27a4 with SMTP id o25-20020a056122179900b0049c79f327a4mr2654001vkf.3.1699553247892; Thu, 09 Nov 2023 10:07:27 -0800 (PST) MIME-Version: 1.0 References: <20231102225837.1141915-1-sdf@google.com> In-Reply-To: From: Stanislav Fomichev Date: Thu, 9 Nov 2023 10:07:14 -0800 Message-ID: To: Alexei Starovoitov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NUCA42HFV6ORQCE2ALPKWKTAUEHIYW3N X-Message-ID-Hash: NUCA42HFV6ORQCE2ALPKWKTAUEHIYW3N X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , Jakub Kicinski , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Willem de Bruijn , David Ahern , "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "Fijalkowski, Maciej" , Jesper Dangaard Brouer , "Song, Yoong Siang" , Network Development , xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v5 00/13] xsk: TX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Nov 9, 2023 at 10:03=E2=80=AFAM Alexei Starovoitov wrote: > > On Thu, Nov 2, 2023 at 3:58=E2=80=AFPM Stanislav Fomichev wrote: > > > > This series implements initial TX metadata (offloads) for AF_XDP. > > See patch #2 for the main implementation and mlx5/stmmac ones for the > > example on how to consume the metadata on the device side. > > > > Starting with two types of offloads: > > - request TX timestamp (and write it back into the metadata area) > > - request TX checksum offload > > > > Changes since v4: > > - remove 'render-max: true' from spec (Jakub) > > - move xsk_tx_metadata_ops into include/net/xdp_sock.h (Jakub) > > - christmas tree in netdev_nl_dev_fill (Jakub) > > - fix > vs >=3D when dumping masks in samples (Jakub) > > - switch to 8-byte alignment for tx metadata length (Jakub) > > - spelling fixes in the doc (Magnus) > > - deny metadata length >=3D 256 (Magnus) > > - validate metadata flags and deny unknown ones (Jakub) > > - move XDP_TX_METADATA_CHECKSUM_SW into umem config flag (Jakub) > > - don't print timestamps twice in xdp_hw_metadata (Song) > > - rename anonymous xsk_tx_metadata member into request (Alexei) > > - add comment to xsk_tx_metadata (Alexei) > > > > I've separated new bits that need a closer review into separate patches= : > > - xsk_tx_metadata flags validation: > > - xsk: Validate xsk_tx_metadata flags > > - new umem flag for sw tx csum calculation (instead of per-packet flag) > > - xsk: Add option to calculate TX checksum in SW > > Stan, > > new xdp_metadata is failing on s390. See BPF CI: > > verify_xsk_metadata:FAIL:csum unexpected csum: actual 29212 !=3D expected= 7282 > > Other than this I think the patchset is good to go. > Pls fix and respin. Oh, thanks for catching this, probably some endianness issues? Will take a = look!