[xdp-hints] Re: [PATCH bpf-next v5 00/13] xsk: TX metadata

[Stanislav Fomichev <sdf@google.com>]

On Thu, Nov 9, 2023 at 10:03 AM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Thu, Nov 2, 2023 at 3:58 PM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > This series implements initial TX metadata (offloads) for AF_XDP.
> > See patch #2 for the main implementation and mlx5/stmmac ones for the
> > example on how to consume the metadata on the device side.
> >
> > Starting with two types of offloads:
> > - request TX timestamp (and write it back into the metadata area)
> > - request TX checksum offload
> >
> > Changes since v4:
> > - remove 'render-max: true' from spec (Jakub)
> > - move xsk_tx_metadata_ops into include/net/xdp_sock.h (Jakub)
> > - christmas tree in netdev_nl_dev_fill (Jakub)
> > - fix > vs >= when dumping masks in samples (Jakub)
> > - switch to 8-byte alignment for tx metadata length (Jakub)
> > - spelling fixes in the doc (Magnus)
> > - deny metadata length >= 256 (Magnus)
> > - validate metadata flags and deny unknown ones (Jakub)
> > - move XDP_TX_METADATA_CHECKSUM_SW into umem config flag (Jakub)
> > - don't print timestamps twice in xdp_hw_metadata (Song)
> > - rename anonymous xsk_tx_metadata member into request (Alexei)
> > - add comment to xsk_tx_metadata (Alexei)
> >
> > I've separated new bits that need a closer review into separate patches:
> > - xsk_tx_metadata flags validation:
> >   - xsk: Validate xsk_tx_metadata flags
> > - new umem flag for sw tx csum calculation (instead of per-packet flag)
> >   - xsk: Add option to calculate TX checksum in SW
>
> Stan,
>
> new xdp_metadata is failing on s390. See BPF CI:
>
> verify_xsk_metadata:FAIL:csum unexpected csum: actual 29212 != expected 7282
>
> Other than this I think the patchset is good to go.
> Pls fix and respin.

Oh, thanks for catching this, probably some endianness issues? Will take a look!