From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by mail.toke.dk (Postfix) with ESMTPS id 8E2D79D89AB for ; Tue, 3 Jan 2023 23:24:12 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=l6737WId Received: by mail-pj1-x1035.google.com with SMTP id cp9-20020a17090afb8900b00226a934e0e5so811678pjb.1 for ; Tue, 03 Jan 2023 14:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bAbM53LNtbuBpzdcSH7t+85XAJK+yI8Er92lPi4rqp8=; b=l6737WId1PWVXlNkiVbGXzlggzeFv/u6k2sKSGbbAh393OeuqkfFYwe92dbku7ocqV /BHUYYvrYHii56WYoLF2pQdK9KgmsUg6Tp0eq0ulNYOfWrbMqeIp2VCAM1BE33LekOMs pf7kXamUa9KUY91CAQ/5JDyn3Lj0TpcYtQr3yIaP7etkpLKvV9LuGEs/mkWNgXPTY6Cy 9aLPzzt2Y65jxZMhWXmGB4ra11wTh/EGbZPYLROqyR5DpvDMWMttMMyWBFWTwLL/kPVV wXOkFH2kZ7Uu7R9XLl/i7jrbaNW3z5Fj9Mpj2i6gXO/IesRlAmxT/wzOFmJSz5YUJCcz Kq/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bAbM53LNtbuBpzdcSH7t+85XAJK+yI8Er92lPi4rqp8=; b=HHN1xW1I0/PLI20z+5KsOWUDdpzZuI1nQG5FLUJjyBUGvBUG/KyF2nXtMqdY6j46bP Xi/XnZnVVV/UzxJbfDWNk4Fc7hFxylTD5EGmdgRyqus0IfXqEF+nnIGFNw+mhECe6xfi EnwJeovj9KJF1xQNB/ASUUTJHrw4j0h+OGAEBOQhTkOc1e1HOCJ20JoKeIaHHEyzAw15 9J+PaAk/dHyrjtIj8Y2oE0GOOTJj1ZZ6sZBckBoNPQ5e2zG5gQwlyXcrI3aJXdHEZ53Y hE0bpsFI46tr6PWuPABiUFZmM+aNErH1izAcfB6UOC//ySwDxTnbZKmnmRQbpuflx6Ay YgJA== X-Gm-Message-State: AFqh2kqsaJQh4yeXWV4mQSg7w9gyEDgApAYGx67wXpAOViM8ajpA9fFM ef6WWhp/RaW/Q08QSNxk1V889tMYgpPIsgbf4zxWHw== X-Google-Smtp-Source: AMrXdXtg7m2W/dxg/F5rD1x5L5XTSt6raEoUW0DUarorcyprjvNPBarxEkpgok1K/u9DYAm9nqBZIfMzvNxmtDg6kW4= X-Received: by 2002:a17:903:2696:b0:189:e426:463e with SMTP id jf22-20020a170903269600b00189e426463emr2064365plb.134.1672784650435; Tue, 03 Jan 2023 14:24:10 -0800 (PST) MIME-Version: 1.0 References: <20221220222043.3348718-1-sdf@google.com> <20221220222043.3348718-8-sdf@google.com> In-Reply-To: From: Stanislav Fomichev Date: Tue, 3 Jan 2023 14:23:59 -0800 Message-ID: To: David Vernet Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: 42TA3432LQ63LQL3W7BSUIQNFWHVGCQW X-Message-ID-Hash: 42TA3432LQ63LQL3W7BSUIQNFWHVGCQW X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v5 07/17] bpf: XDP metadata RX kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Dec 27, 2022 at 12:33 PM David Vernet wrote: > > On Tue, Dec 20, 2022 at 02:20:33PM -0800, Stanislav Fomichev wrote: > > Hey Stanislav, > > [...] > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index aad12a179e54..b41d18490595 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -74,6 +74,7 @@ struct udp_tunnel_nic_info; > > struct udp_tunnel_nic; > > struct bpf_prog; > > struct xdp_buff; > > +struct xdp_md; > > > > void synchronize_net(void); > > void netdev_set_default_ethtool_ops(struct net_device *dev, > > @@ -1618,6 +1619,11 @@ struct net_device_ops { > > bool cycles); > > }; > > > > +struct xdp_metadata_ops { > > + int (*xmo_rx_timestamp)(const struct xdp_md *ctx, u64 *timestamp); > > + int (*xmo_rx_hash)(const struct xdp_md *ctx, u32 *hash); > > +}; > > + > > /** > > * enum netdev_priv_flags - &struct net_device priv_flags > > * > > @@ -2050,6 +2056,7 @@ struct net_device { > > unsigned int flags; > > unsigned long long priv_flags; > > const struct net_device_ops *netdev_ops; > > + const struct xdp_metadata_ops *xdp_metadata_ops; > > You need to document this field above the struct, or the docs build will > complain: > > SPHINX htmldocs --> > > make[2]: Nothing to be done for 'html'. > Using sphinx_rtd_theme theme > source directory: networking > ./include/linux/netdevice.h:2371: warning: Function parameter or > member 'xdp_metadata_ops' not described in 'net_device' > > > int ifindex; > > unsigned short gflags; > > unsigned short hard_header_len; Thanks, I will try to actually build the doc. Last time I tried it took too long and I gave up :-) > Thanks, > David