From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by mail.toke.dk (Postfix) with ESMTPS id A0A2EA2136D for ; Mon, 14 Aug 2023 20:05:04 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=6pHKTGWV Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-26b0b4a7ccbso2426544a91.2 for ; Mon, 14 Aug 2023 11:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692036301; x=1692641101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1wBdc2OtGKv5OJ2TPNg6Z3QRlAwIqqbuA4CQ/AEohC0=; b=6pHKTGWVGdOmP1EyGI1E/GeT78Zugn6Pa1gf3JF9qKC8hmo4ojoU1l8Bz7La+SwNc6 iiqHzasde50XbQJSnQcXO4x7aOhDEES9bD1iZ+Zx+uhkPL8fslQA6jCEt7ANZYO/Sjzd bNV0Bt7Req8Gt4/HHQVA+TxqZ5kEzKOmucdE0tjOy9BCGeaXAFCkdxD3WB5BiWA7zPT1 UiLcDT1esR/uKDC5nL0c/dEd+OxlS+LCCRnQCZEcugDtLIpuTSEf7fI8ito91JLMxj69 godM/ulAVfKPf/5kKW1F3RkTifPGIeVzwf0N7JvByZxtU5Fl6GPOd3oUBH1Wjjw4mJJm dURg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692036301; x=1692641101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1wBdc2OtGKv5OJ2TPNg6Z3QRlAwIqqbuA4CQ/AEohC0=; b=Z0KOjUbs7WPcCj5TjFdYfYwKaL/D5anSK2dCeGsAJv//Qqm2mpcMZN8OxKVdDu/07P DNTxGcq7lVHf/V89ObIRSQ5LR15dmW0qhBFNrQ+MR8FkZ/fu6D3KYcfj1aE6RpAfJsg2 g3WN+h/821DfjqR4gln66EorUzU3nTxOVUZjzFoONPdSo7nfGb4GMqo6rMbUQ/u93rnE 9khvNseibAKsuqddS3T+RXz1V6XxqQwouDOOpWunUrKXwmDWTLSegSJSAS7cPvNlB38n 1TkpDd3SsUKm7WnEaVql3mvSQyC3SXfg/jlBatpUE3w8tD0QhJMN/778Xnap1daBBvM6 q4CA== X-Gm-Message-State: AOJu0YxxvZLB7dkMefIHPZPbQ4IyHzlSyBKHJfQvIV+YW4s7jLMDCwQq 6Wd6iJKDDC2vmAXdCbIoI6jRUfriONY+vQVil0r6Hg== X-Google-Smtp-Source: AGHT+IGPfPTWC2xmtl+CVOZ1y6flMKk+BrLnhIW5whlJyHKWDVa+ttYaTiJe6gSKHXzMh8xVBYfbFjIthl98axlH/YE= X-Received: by 2002:a17:90a:6686:b0:268:8e93:644f with SMTP id m6-20020a17090a668600b002688e93644fmr7865412pjj.45.1692036300901; Mon, 14 Aug 2023 11:05:00 -0700 (PDT) MIME-Version: 1.0 References: <20230809165418.2831456-1-sdf@google.com> In-Reply-To: From: Stanislav Fomichev Date: Mon, 14 Aug 2023 11:04:49 -0700 Message-ID: To: Maciej Fijalkowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RMJ5UXESDEAKNDUAFR52VVNYLB4V2PDG X-Message-ID-Hash: RMJ5UXESDEAKNDUAFR52VVNYLB4V2PDG X-MailFrom: sdf@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, kuba@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, hawk@kernel.org, netdev@vger.kernel.org, xdp-hints@xdp-project.net, Saeed Mahameed X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next 0/9] xsk: TX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 14, 2023 at 4:16=E2=80=AFAM Maciej Fijalkowski wrote: > > On Wed, Aug 09, 2023 at 09:54:09AM -0700, Stanislav Fomichev wrote: > > This series implements initial TX metadata (offloads) for AF_XDP. > > See patch #2 for the main implementation and mlx5-one for the > > example on how to consume the metadata on the device side. > > > > Starting with two types of offloads: > > - request TX timestamp (and write it back into the metadata area) > > - request TX checksum offload > > > > Changes since last RFC: > > - add /* private: */ comments to headers (Simon) > > - handle metadata only in the first frag (Simon) > > - rename xdp_hw_metadata flags (Willem) > > - s/tmo_request_checksum/tmo_request_timestamp/ in xdp_metadata_ops > > comment (Willem) > > - Documentation/networking/xsk-tx-metadata.rst > > Stan, > > thanks for working on it - we reviewed the patchset with Magnus and we > have some questions (responded inline to patches). Overall we think it > would be worth implementing this work against another ZC driver > (preferably ice :P) to check that proposed API is generic enough. Awesome, thanks for the review! I can try to see if I have some ice-capable hw around, but if you want to help with the ice implementation I'd gladly accept the offer :-p