From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by mail.toke.dk (Postfix) with ESMTPS id 0E26786F17A for ; Sat, 7 Aug 2021 00:59:21 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hG1o1N1D Received: by mail-yb1-xb33.google.com with SMTP id p145so17879857ybg.6 for ; Fri, 06 Aug 2021 15:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P6vtbFX4wGAYcAVXo4s5Id8RQxVNBIV7qh2rr7RPZdE=; b=hG1o1N1DKIB63r3tPiyBkWe5BceXAUlGLQ1buqPZC9VWajk/Jm+DUy14kqbLwbrqCu oZ83igbLcmEkuVf0nehm0ex7lKPtEJ+18hNLKkwSsQDUFg2p/2rYC3y5Xg8MaX7rIiQN GymlFv1ubbRNqNFxbdRmgQgwx48ZecL/bOAHtUjCvOZQ9CzdXwfNzjTBESbT5snbvcmP TYutK8Fhuh331lpiHLLRsCUf5mEBUONaUgovywsRFh+/eZLay7Ei7VzVejciQhHSaYFQ kDXx7JkDIf4H1EFvy/vWcuRa+wXayGRcU5GdSRcJQc9Kn6uzQeOIXQ3pmVNG+YQRc2CQ JydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P6vtbFX4wGAYcAVXo4s5Id8RQxVNBIV7qh2rr7RPZdE=; b=Qs+0ykRpGkDu7QrirJuzzYaT81Y3mrIq+LQ9tQk4GbR3nfMj2cOeeGvoQf82PWo3X3 V8M7hxIrKJMUCwEbFyMiov/wATHkJvtuciF0CuSFSiQu7S0HKp3MYqQgLDCqTgUuqjBZ r4Tlzx+/klwdq+ooNvgE3c6/+YsXu8tZFZbiiTzG5ulMOb4uTnCCnlMRSTaOk9eS79L7 Xad8JZXmcvEkWitNlAqGCwA3diutr7Gw3X+GGEgiqYbgznRwJ7QlsVN5/Glitz1EphAh 5PclTnEatWGwouxagQunwCk86IvweO6kXPzJFopcvZqK8kHf0qjkhG7U4QC3L0M5d9XP FrGA== X-Gm-Message-State: AOAM532fPqqvwrYX1llEVdmt/LQvPqZcPbyQV0g5kpESGmsWiXjD4pPW RQUZ9oQ30E+etQn4SsZUYNU+4dgGZ4KIbOTD638= X-Google-Smtp-Source: ABdhPJwKU7z/iEs1jRfmRYmd3JTLJj/dyQJkOUzpB1pNmiAM+iN8XOgHgXCfDpcb5PpFi4X4xpLEQLnmqEGzXidjNVs= X-Received: by 2002:a25:9942:: with SMTP id n2mr16327661ybo.230.1628290759497; Fri, 06 Aug 2021 15:59:19 -0700 (PDT) MIME-Version: 1.0 References: <20210803010331.39453-1-ederson.desouza@intel.com> <20210803010331.39453-14-ederson.desouza@intel.com> In-Reply-To: <20210803010331.39453-14-ederson.desouza@intel.com> From: Andrii Nakryiko Date: Fri, 6 Aug 2021 15:59:08 -0700 Message-ID: Subject: Re: [[RFC xdp-hints] 13/16] libbpf: Helpers to access XDP frame metadata To: Ederson de Souza Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: EQ2G6SJEMUNFL7CIDRYSQU3O2M2PH7GC X-Message-ID-Hash: EQ2G6SJEMUNFL7CIDRYSQU3O2M2PH7GC X-MailFrom: andrii.nakryiko@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: xdp-hints@xdp-project.net, bpf , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Magnus Karlsson X-Mailman-Version: 3.3.4 Precedence: list List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 2, 2021 at 6:04 PM Ederson de Souza wrote: > > Two new pairs of helpers: `xsk_umem__adjust_prod_data` and > `xsk_umem__adjust_prod_data_meta` for data that is being produced by the > application - such as data that will be sent; and > `xsk_umem__adjust_cons_data` and `xsk_umem__adjust_cons_data_meta`, > for data being consumed - such as data obtained from the completion > queue. > > Those function should usually be used on data obtained via > `xsk_umem__get_data`. Didn't change this function to avoid API breaks. > > Signed-off-by: Ederson de Souza > --- AF_XDP parts of libbpf are being moved into libxdp ([0]). We shouldn't keep adding new APIs if we are actively working on deprecating and removing existing functionality already. CC'ing Toke and Magnus for the state of libxsk to libxdp migration. [0] https://github.com/xdp-project/xdp-tools/tree/master/lib/libxdp#using-af_xdp-sockets > tools/lib/bpf/libbpf.map | 4 ++++ > tools/lib/bpf/xsk.c | 26 ++++++++++++++++++++++++++ > tools/lib/bpf/xsk.h | 7 +++++++ > 3 files changed, 37 insertions(+) > [...]