From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by mail.toke.dk (Postfix) with ESMTPS id 4B0F7A3B5AA for ; Thu, 9 Nov 2023 19:04:12 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=B3TGsFLp Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-32d9effe314so671530f8f.3 for ; Thu, 09 Nov 2023 10:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699552992; x=1700157792; darn=xdp-project.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LQPmLdLHjp0U6fK2jzOSwK3vCgpMh0fu5pXh4aGJZPs=; b=B3TGsFLpTH2I1lPBFW5h0c9Q2inP7KTtLs6wIgpQegAZDHpoBmnJkzirpXZO13y/rb jK8A0Wc+tC9lgNGddYYjZ5mSrS9t1L5rETSlSOutU/rubSPD60pCXSYZrk8avo2S1rwg hA7ThL8VvCvhuacHE4VCkWwz8fm3YsxPWYfrItAqMVb4/hgBC0pFV32Lx2Yw5TV+6I/j 1jFKQ63Mqi5lmAT0k6ZxfHgthEwpejv3RYO2ha8gBr9CpfrlpMjehyViWbg0oOiHsxPo zCoUknhdndgLTI3IQ88aKgPXYRvSOUGHxPvkkjkh7MTuOb62MTJ4kTfQ6jpNHjEG6tWd JFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699552992; x=1700157792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LQPmLdLHjp0U6fK2jzOSwK3vCgpMh0fu5pXh4aGJZPs=; b=eu4WFdgjBOCYISJUWerxmMsedjxCPZMii/upNb9vPtm0EAA0FfKkz2C4hulVuLWysf lNaM1Qu3Mv8NxEZw8R7R1OP/ypEwXOdYxf4ai6UQlRXPtfg8uJj1MuSNUYuObBUYCDdo 2lPUQ3N1URP4DVjYIOOKmKzRGfF68+R9Q0H0y03yyZIxxFPds8I+/cQNicWk68psiXtw Q2p/eJmL/kMjrq0b5pj2NviOLpWtR0DxRW2z+D9kZz7q+LbD9l2i2nCOWO/h2VUGxxu+ GU820lvoWIrRttUjv23S9hniBcel/xM4yT9WALkwEGhjPtHv50Jg/ZPwobPaYG4mBUux pWxg== X-Gm-Message-State: AOJu0YzACLBJOY6XwjR0dSMnNCXON9sNdZ4khbQhhlB3EndgyGg025yL B1QuNfFeGpZe/7Gu3R5GTtV8KOzxFB33sZytT7A= X-Google-Smtp-Source: AGHT+IEtBGQCplXPDboMTEzY5ylJDE3ujo/RzqX5g36yXyxvh6/i4hJM4W65YBtHs15I5nles1xOP7AekjF3o+gUbRY= X-Received: by 2002:adf:f506:0:b0:32d:9ed0:c31a with SMTP id q6-20020adff506000000b0032d9ed0c31amr4501338wro.64.1699552991462; Thu, 09 Nov 2023 10:03:11 -0800 (PST) MIME-Version: 1.0 References: <20231102225837.1141915-1-sdf@google.com> In-Reply-To: <20231102225837.1141915-1-sdf@google.com> From: Alexei Starovoitov Date: Thu, 9 Nov 2023 10:03:00 -0800 Message-ID: To: Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6M6L7KOJVRLZB7AAIMFEIWRWB3ATO7HJ X-Message-ID-Hash: 6M6L7KOJVRLZB7AAIMFEIWRWB3ATO7HJ X-MailFrom: alexei.starovoitov@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , Jakub Kicinski , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Willem de Bruijn , David Ahern , "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "Fijalkowski, Maciej" , Jesper Dangaard Brouer , "Song, Yoong Siang" , Network Development , xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v5 00/13] xsk: TX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Nov 2, 2023 at 3:58=E2=80=AFPM Stanislav Fomichev = wrote: > > This series implements initial TX metadata (offloads) for AF_XDP. > See patch #2 for the main implementation and mlx5/stmmac ones for the > example on how to consume the metadata on the device side. > > Starting with two types of offloads: > - request TX timestamp (and write it back into the metadata area) > - request TX checksum offload > > Changes since v4: > - remove 'render-max: true' from spec (Jakub) > - move xsk_tx_metadata_ops into include/net/xdp_sock.h (Jakub) > - christmas tree in netdev_nl_dev_fill (Jakub) > - fix > vs >=3D when dumping masks in samples (Jakub) > - switch to 8-byte alignment for tx metadata length (Jakub) > - spelling fixes in the doc (Magnus) > - deny metadata length >=3D 256 (Magnus) > - validate metadata flags and deny unknown ones (Jakub) > - move XDP_TX_METADATA_CHECKSUM_SW into umem config flag (Jakub) > - don't print timestamps twice in xdp_hw_metadata (Song) > - rename anonymous xsk_tx_metadata member into request (Alexei) > - add comment to xsk_tx_metadata (Alexei) > > I've separated new bits that need a closer review into separate patches: > - xsk_tx_metadata flags validation: > - xsk: Validate xsk_tx_metadata flags > - new umem flag for sw tx csum calculation (instead of per-packet flag) > - xsk: Add option to calculate TX checksum in SW Stan, new xdp_metadata is failing on s390. See BPF CI: verify_xsk_metadata:FAIL:csum unexpected csum: actual 29212 !=3D expected 7= 282 Other than this I think the patchset is good to go. Pls fix and respin.