From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by mail.toke.dk (Postfix) with ESMTPS id E64539C3335 for ; Thu, 17 Nov 2022 21:17:21 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nCp04v7s Received: by mail-ej1-x631.google.com with SMTP id k2so8006501ejr.2 for ; Thu, 17 Nov 2022 12:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=55YgtW2dMJrW7AwFItwqgAI16CPRs4yKm+bUdhCtkUQ=; b=nCp04v7sWKLKn615/jPd8VEMBxuFVEWvTogyYWLkiSNBFp05G2vvuKELsYtP8x1v1O g1zzw43ziLoWLElgZkQ4NSGFaIbjRfIN53astbdHu0L5uIEvqVZ2wYqZ9nxwv0qRnPr1 9CuMjwEMj5zhfO2sDxTDulWKMXPKvzRXjNh6eGU3RaoaFybwGT468W3gA6sn1KjEP/2M mnoF7YmNxaJyrJfFup+QNMn8cw+CAdOyMP+zyDHekLqD+ZXK9bowlZMRyFNBIUlBWu7N 5hXGfXbcNC9DNUrJFhWmfhHsbf5EI2v1S5CmJ/P2gA/wn+pESMJBs5F6jXUYQorRwa7m uqLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=55YgtW2dMJrW7AwFItwqgAI16CPRs4yKm+bUdhCtkUQ=; b=fBDenG0lWI/6iD0R3k4FUlqqKuLaZ9aDnhrAJscKb9seO50U2+WdBPJ53p476Vzmdm JCsx07gxmnqaAKZL4bDEHQUsCK2H09MWb2xUhvqJx2A+uQXuAz0ltlBBFAhuQP6UwrYR 44yrCO0tVEGesGNNi4dkvkpitIQruFCiiHBuEpt91mknJlZxi50lQNcR2PX2caAXcF1b 2mQ82gMvOsvt1PErae+lU+pa5GlU0V4SbwppSypgXLZN3RDstCX9nNtj+7qNoXg+gH2G XYKirEZqprGOWq51wW8AASm7bIFeuf5F8MOWu2VEyOm5RFHVPgA8Ixy5O+gM9XLa55zd vQmw== X-Gm-Message-State: ANoB5pk2IoQnXhO7LQEXedqnBAnLp6qY5npscfgznKRKFwAZY2HcoOry lsyy6IkKn4EA+cAJOxZJ5lim3EYCXhjpgQVMWmw= X-Google-Smtp-Source: AA0mqf7DcM9g4bmq4StqwLg72HjwbQzsNljXj78/PgIZDmdK47iiwkm0j+r1NBwLrOXB/fG2UEqHhGGXdVBH3bITGQ4= X-Received: by 2002:a17:906:1495:b0:7ad:d250:b904 with SMTP id x21-20020a170906149500b007add250b904mr3464534ejc.633.1668716239384; Thu, 17 Nov 2022 12:17:19 -0800 (PST) MIME-Version: 1.0 References: <20221115030210.3159213-1-sdf@google.com> <20221115030210.3159213-6-sdf@google.com> <87h6z0i449.fsf@toke.dk> <8735ajet05.fsf@toke.dk> <6374854883b22_5d64b208e3@john.notmuch> <34f89a95-a79e-751c-fdd2-93889420bf96@linux.dev> <878rkbjjnp.fsf@toke.dk> <6375340a6c284_66f16208aa@john.notmuch> <637576962dada_8cd03208b0@john.notmuch> <6375dad15f11f_9c882208b5@john.notmuch> <63768feaf1324_4101208cf@john.notmuch> In-Reply-To: <63768feaf1324_4101208cf@john.notmuch> From: Alexei Starovoitov Date: Thu, 17 Nov 2022 12:17:07 -0800 Message-ID: To: John Fastabend Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: JNWZDFIJG3MHFOQUUAAJFBQNR3NYCFO7 X-Message-ID-Hash: JNWZDFIJG3MHFOQUUAAJFBQNR3NYCFO7 X-MailFrom: alexei.starovoitov@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stanislav Fomichev , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Martin KaFai Lau , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, Network Development X-Mailman-Version: 3.3.6 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next 05/11] veth: Support rx timestamp metadata for xdp List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Nov 17, 2022 at 11:47 AM John Fastabend wrote: > > Yeah for timestamps I think a kfunc to either get the timestamp or could > also be done with a kfunc to read hw clock. But either way seems hard > to do that in BPF code directly so kfunc feels right to me here. > > By the way I think if you have the completion queue (rx descriptor) in > the xdp_buff and we use Yonghong's patch to cast the ctx as a BTF type > then we should be able to also directly read all the fields. I see > you noted this in the response to Alexei so lets see what he thinks. Fine with me. Let's land something that is not uapi and then iterate on top.