From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by mail.toke.dk (Postfix) with ESMTPS id 66937A1924A for ; Wed, 12 Jul 2023 21:42:48 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=ragut39q Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b701dee4bfso122639231fa.0 for ; Wed, 12 Jul 2023 12:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689190967; x=1691782967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oHdrflWK2ViXkxBQZTcWjz3hRepn7lalY6kLivWlhf0=; b=ragut39qw6oOSPIEbhyKis3llf3ddQSZ84MOmn0h54RlvEbZY0OMgXKqSHnxVYDVca aF10TIJ3yfLWdFJ7mz8+MJmUzJ/a49/9Xrc26sVRc6VNcswCQZirmX3XmovP7NWHnSa5 zsSv7siAFYjMhP7yb5mLPPgAWtjbJQriNG3IWsxJkvM9oR1MGHaaj8a+d4faPLV30RiA RcKdsoa+uKtvFOtwt+xQ+xdbqw2PGgO4SCxTrF08aINzAPlcJ5FXc4sQCrWOdyGO5YEg jV67Newb2M9UQL+F1Pyztrbei1KYqDCEfjYT/WL1YBNvRuntWUnE2paIaiDg2Qukl0YW wLow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689190967; x=1691782967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oHdrflWK2ViXkxBQZTcWjz3hRepn7lalY6kLivWlhf0=; b=Cg+e6YugodOaWfPfpLUmyRU94RW83md/rBEYsyFwxvGOR0WjNI1nPOZpBDeVgRZtIF a0p7ahxMCNpqh+nU4NdQZ5Ue2X+YQ4FZ3zVmoow3yNqz+EGyRbYcX5hZLUi9ocxKTYRg LhYtKF346Ih+YFdfcxULqbnWXaN0SCO5pOx0zkynotZ0n1lU4abmnyncxiPs/PNUVjPR tB+1oQnPpXBwQ8KJNBnMWKv32RqQICPHaiZ8gF6eIdOPlVmqw8jH8VNVSXxmCaUH3o8n FiYx6H9eR26g6NSx+V2h2TOkuL4MCg12rBlO6gtI1USuGfj7y1/waaieaQ/8QmdcM2Io pDew== X-Gm-Message-State: ABy/qLZCvGNHOjo3D5s406MTFu7RU/ecMgaBJMq9CsRWyVG1kE2328sh NTulp6w2wul8lm/Zz6mFT/DNeV/nhnju61g/23k= X-Google-Smtp-Source: APBJJlHBsdL88UhEBrzhUY2LRdZ/z9Sp80L6LqZ/eNhoDr584c+w5B+uhdq4EcYu6pH1C4jAH+jNWE7yiS/UtZThFIw= X-Received: by 2002:a2e:7d0d:0:b0:2b6:ea3b:f082 with SMTP id y13-20020a2e7d0d000000b002b6ea3bf082mr16118660ljc.38.1689190966586; Wed, 12 Jul 2023 12:42:46 -0700 (PDT) MIME-Version: 1.0 References: <20230707193006.1309662-10-sdf@google.com> <20230711225657.kuvkil776fajonl5@MacBook-Pro-8.local> <20230712190342.dlgwh6uka5bcjfkl@macbook-pro-8.dhcp.thefacebook.com> In-Reply-To: From: Alexei Starovoitov Date: Wed, 12 Jul 2023 12:42:35 -0700 Message-ID: To: Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5IPPIYZCWIHDJMP45Q25QJ4O6EWRKQLC X-Message-ID-Hash: 5IPPIYZCWIHDJMP45Q25QJ4O6EWRKQLC X-MailFrom: alexei.starovoitov@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stanislav Fomichev , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , Jakub Kicinski , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Willem de Bruijn , David Ahern , "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "Fijalkowski, Maciej" , Jesper Dangaard Brouer , Network Development , xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [RFC bpf-next v3 09/14] net/mlx5e: Implement devtx kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Jul 12, 2023 at 12:12=E2=80=AFPM Willem de Bruijn wrote: > > Basically, add to AF_XDP what we already have for its predecessor > AF_PACKET: setsockopt PACKET_VNET_HDR? > > Possibly with a separate new struct, rather than virtio_net_hdr. As > that has dependencies on other drivers, notably virtio and its > specification process. yeah. Forgot about this one. That's a perfect fit. I would reuse virtio_net_hdr as-is. Why reinvent the wheel? It would force uapi, but some might argue it's a good thing.