From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mail.toke.dk (Postfix) with ESMTPS id 3A8C6A91160 for ; Sat, 12 Oct 2024 11:12:17 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XQd5x1ymLzQrbl; Sat, 12 Oct 2024 17:11:33 +0800 (CST) Received: from dggpemf100014.china.huawei.com (unknown [7.185.36.231]) by mail.maildlp.com (Postfix) with ESMTPS id 3915D140157; Sat, 12 Oct 2024 17:12:13 +0800 (CST) Received: from dggpemf500014.china.huawei.com (7.185.36.43) by dggpemf100014.china.huawei.com (7.185.36.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 12 Oct 2024 17:12:12 +0800 Received: from dggpemf500014.china.huawei.com ([7.185.36.43]) by dggpemf500014.china.huawei.com ([7.185.36.43]) with mapi id 15.02.1544.011; Sat, 12 Oct 2024 17:12:12 +0800 From: tianmuyang To: "bpf@vger.kernel.org" Thread-Topic: Questions about XDP hints Thread-Index: Adschr1DOKSSRg+zQgOfeFDtypgqTg== Message-ID: <90c1c6b53a654cf197eb412917fad31a@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.136.114.109] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MailFrom: tianmuyang@huawei.com X-Mailman-Rule-Hits: implicit-dest X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: K6IPU6ORXCOJT76ZTAUO3PEPD4EQHPFP X-Message-ID-Hash: K6IPU6ORXCOJT76ZTAUO3PEPD4EQHPFP X-Mailman-Approved-At: Mon, 14 Oct 2024 15:05:37 +0200 CC: "larysa.zaremba@intel.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "song@kernel.org" , "yhs@fb.com" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@google.com" , "haoluo@google.com" , "jolsa@kernel.org" , "dsahern@gmail.com" , "kuba@kernel.org" , "willemb@google.com" , "brouer@redhat.com" , "anatoly.burakov@intel.com" , "alexandr.lobakin@intel.com" , "magnus.karlsson@gmail.com" , "mtahhan@redhat.com" , "xdp-hints@xdp-project.net" , "netdev@vger.kernel.org" , "willemdebruijn.kernel@gmail.com" , "alexei.starovoitov@gmail.com" , "simon.horman@corigine.com" , "Yanan (Euler)" , "Wuchangye (EulerOS)" , Xiesongyang , "Liuxin(EulerOS)" , "zhangmingyi (C)" , "liwei (H)" , tianmuyang X-Mailman-Version: 3.3.10 Precedence: list Subject: [xdp-hints] Questions about XDP hints List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Date: Sat, 12 Oct 2024 09:12:21 X-Original-Date: Sat, 12 Oct 2024 09:12:12 +0000 Hi all: There has been some discussions about adding checksum hint in AF_XDP such = as this thread[1]. Now, we also plan to add checksum hint. My questions are= : 1. In this msg[2], is it appropriate if xdp_csum_status only includes 4 en= ums/macros(CHECKSUM_NONE...CHECKSUM_PARTIAL in skbuff.h)? Thus it becomes m= ore generic. Also, in this msg[3] we can simply pass skb->ip_summed to csum= _status in veth_xdp_rx_csum(). 2. What should be taken care of if I want to add a new hint? IOW, what is = acceptable to add a new hint? Thanks! [1] https://lore.kernel.org/bpf/CAADnVQJPgpo7J0qVTQJYYocZ=3DJnw=3DO5GfN2=3D= PyAQ55+WWG_DVg@mail.gmail.com/ [2] https://lore.kernel.org/bpf/20230728173923.1318596-13-larysa.zaremba@in= tel.com/ [3] https://lore.kernel.org/bpf/20230728173923.1318596-18-larysa.zaremba@in= tel.com/