From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::])
	by mail.toke.dk (Postfix) with ESMTPS id 9BFD69E2BD9
	for <xdp-hints@xdp-project.net>; Mon, 23 Jan 2023 19:53:15 +0100 (CET)
Authentication-Results: mail.toke.dk;
	dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=coBxZVNd
Message-ID: <901e1a7a-bb86-8d62-4bd7-512a1257d3b0@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1674499992;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9r8HNuiL5kCXCflLv3H0u4cF6+EvDEa21DtFDXkmT94=;
	b=coBxZVNdTQksXS1xVfoqhRhNqEdh/GCxcmQkN74+81Bi191qhrIUfxQUV3WeyCw6h0tW9L
	0+a0JWhkbVJHGiP4IrUV5fGpGEVLhNSURIFFaipYEEcUgARPhHm9dOEu4rCnnQwXJD6oRR
	sV7HTh4b3wjU2qTy2IZmp6bZq9ZB6j8=
Date: Mon, 23 Jan 2023 10:53:06 -0800
MIME-Version: 1.0
Content-Language: en-US
To: Stanislav Fomichev <sdf@google.com>
References: <20230119221536.3349901-1-sdf@google.com>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20230119221536.3349901-1-sdf@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT
Message-ID-Hash: B2N3FI3R24U3TKB5FV6B2LY4SCQBXCID
X-Message-ID-Hash: B2N3FI3R24U3TKB5FV6B2LY4SCQBXCID
X-MailFrom: martin.lau@linux.dev
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Willem de Bruijn <willemb@google.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Alexander Lobakin <alexandr.lobakin@intel.com>, Magnus Karlsson <magnus.karlsson@gmail.com>, Maryam Tahhan <mtahhan@redhat.com>, xdp-hints@xdp-project.net, netdev@vger.kernel.org, bpf@vger.kernel.org
X-Mailman-Version: 3.3.8
Precedence: list
Subject: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs
List-Id: XDP hardware hints design discussion <xdp-hints.xdp-project.net>
Archived-At: <https://lists.xdp-project.net/xdp-hints/901e1a7a-bb86-8d62-4bd7-512a1257d3b0@linux.dev/>
List-Archive: <https://lists.xdp-project.net/xdp-hints/>
List-Help: <mailto:xdp-hints-request@xdp-project.net?subject=help>
List-Owner: <mailto:xdp-hints-owner@xdp-project.net>
List-Post: <mailto:xdp-hints@xdp-project.net>
List-Subscribe: <mailto:xdp-hints-join@xdp-project.net>
List-Unsubscribe: <mailto:xdp-hints-leave@xdp-project.net>

On 1/19/23 2:15 PM, Stanislav Fomichev wrote:
> Please see the first patch in the series for the overall
> design and use-cases.
> 
> See the following email from Toke for the per-packet metadata overhead:
> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
> 
> Recent changes:
> - Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq)
> 
> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)
> 
> - Clarify xdp_buff vs 'XDP frame' (Jesper)
> 
> - Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper)
> 
> - Drop libbpf_flags/xdp_flags from selftests and use ifindex instead
>    of ifname (due to recent xsk.h refactoring)

Applied with the minor changes in the selftests discussed in patch 11 and 17. 
Thanks!