From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail.toke.dk (Postfix) with ESMTPS id 8326C9C28CC for ; Wed, 16 Nov 2022 00:20:33 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G/YtmS1O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668554432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HB6zekTxMq+hKIhJy2TlN2K0Ppt1J67WxSLXwQ7+MSo=; b=G/YtmS1OU+19gPNFFLzCsU03C4FL2/2pSK82ioBLl4u6315TshDtb9RO4VHcv8n3ReCp9W JoA/thgMi0f2om4RzySGy3ubROAL8Y/ZDSjZq3xungGpJg0CSiNHXQAE5dsNZPGZ+nMN+V HrX0+VhC9jyAv6fIVciNAJcoVMrhrvg= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-471-Hlh5aiWuMournF0rTJWLUQ-1; Tue, 15 Nov 2022 18:20:30 -0500 X-MC-Unique: Hlh5aiWuMournF0rTJWLUQ-1 Received: by mail-ed1-f70.google.com with SMTP id f17-20020a056402355100b00466481256f6so10991376edd.19 for ; Tue, 15 Nov 2022 15:20:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HB6zekTxMq+hKIhJy2TlN2K0Ppt1J67WxSLXwQ7+MSo=; b=dN6HKuHdHusZ5NWR24/sRyFCGexozpSBM7JZgj4a1fsowsr36krQgAr984xhDjKJrR iVvVUDDEQx6CVs2fXKGNfO1cMj++Xgm3eqwTzwB1NMsYBnL7LQrk6DvYMTTgG0K8hMOV KjJ9DJSNVnAnK3x0+COpk8Xxj7oShshBqQAvWi86b6UFulD+fcaq7GicEh7quQqPSe9p Hffno7PJeVWx13Ti734AQUQdmSoGk3LXl2l9NISctvuY1URj4CBF2pTPBwL6rtjsUDE4 bh5pv3ufTk7un8FeVbwk3RBHg99Mu2RicrJQRxoVV/LmYNmhWIM2yJm5Ja7sbC9cMjUQ dWGw== X-Gm-Message-State: ANoB5pnJqRN8JuUkwr3I8RRLbxOZYkZ5bSKOMbOBIk+fnF3+p+6nNHZa ZrDLbSYA5e0vzExy31Y3iNArLllrF8rEgBSP5O103UClVbhRkjA/3G+2Z1mu1qZbyAHtgpg/+uz Z1Zbyo923Zcd9klgrUHyA X-Received: by 2002:a17:907:20c2:b0:7ae:967a:50bb with SMTP id qq2-20020a17090720c200b007ae967a50bbmr15745800ejb.383.1668554428719; Tue, 15 Nov 2022 15:20:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf5trZODpBQ09vRtNhMWv8QUfUjuwKz3UoAgxjob/GtLbJSfb4HKBIn/zGAtCHtmuzYW+aASyw== X-Received: by 2002:a17:907:20c2:b0:7ae:967a:50bb with SMTP id qq2-20020a17090720c200b007ae967a50bbmr15745759ejb.383.1668554427864; Tue, 15 Nov 2022 15:20:27 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id n5-20020a05640204c500b00457c85bd890sm6741473edw.55.2022.11.15.15.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 15:20:27 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3718C7A6D70; Wed, 16 Nov 2022 00:20:26 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Stanislav Fomichev , bpf@vger.kernel.org In-Reply-To: <20221115030210.3159213-7-sdf@google.com> References: <20221115030210.3159213-1-sdf@google.com> <20221115030210.3159213-7-sdf@google.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 16 Nov 2022 00:20:26 +0100 Message-ID: <87wn7vdcud.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Message-ID-Hash: L5GKMDTGU4WOGULHQCT2ILDSI34AVG2L X-Message-ID-Hash: L5GKMDTGU4WOGULHQCT2ILDSI34AVG2L X-MailFrom: toke@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.6 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next 06/11] xdp: Carry over xdp metadata into skb context List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index b444b1118c4f..71e3bc7ad839 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -6116,6 +6116,12 @@ enum xdp_action { > XDP_REDIRECT, > }; > > +/* Subset of XDP metadata exported to skb context. > + */ > +struct xdp_skb_metadata { > + __u64 rx_timestamp; > +}; Okay, so given Alexei's comment about __randomize_struct not actually working, I think we need to come up with something else for this. Just sticking this in a regular UAPI header seems like a bad idea; we'd just be inviting people to use it as-is. Do we actually need the full definition here? It's just a pointer declaration below, so is an opaque forward-definition enough? Then we could have the full definition in an internal header, moving the full definition back to being in vmlinux.h only? -Toke