From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail.toke.dk (Postfix) with ESMTPS id 8DE91880110 for ; Thu, 19 Aug 2021 13:47:58 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=imnDE8/H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629373676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3zQcMqwa53jnwixjh8Le0hk8Ov2voDGT6ZkF7r4VIlY=; b=imnDE8/HAFiJg6PyxQkY98IzYS4w4ViT3nFxGSEplrAiiDC49MFDRu6pVQlx5RL5aBTLaE 72HS8Gsk2O1VM86PrU51B9/eyg++qKPCUYk8AIpzer9w4rKZ7H5969aDwM+r6LN+Jb/sul Viwyjy9W+bHsE10d8u0Oiup3ye8R4ig= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-wSCaepQbO_ajqFcqvHhY6w-1; Thu, 19 Aug 2021 07:47:54 -0400 X-MC-Unique: wSCaepQbO_ajqFcqvHhY6w-1 Received: by mail-ed1-f69.google.com with SMTP id v20-20020aa7d9d40000b02903be68450bf3so2684918eds.23 for ; Thu, 19 Aug 2021 04:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3zQcMqwa53jnwixjh8Le0hk8Ov2voDGT6ZkF7r4VIlY=; b=Mo68whDJuLt+b1rdwbQC785JzwWSk1vw0xlHVG/IQY8Sc+sywQskPsn7YflK9eSzrk 7qD8hHETOP3gkx/t8S9wp8Lz/thBYZzRV+qEAfsFz0mrGn/6t7eitlEGT6eavYhPJENr pSFpmFBz412hAOj3dY/dBlCwGeLsuQdce/CCU/hpHyW7q4cMNxG1sz0RdZ9mC0mIoXE3 pCkh5+xo139M4dnthe8gEF516un/00qdSC5cbbI1NnwoEAFXhe+oTNmINpIIiUqndJZ4 muDXCeKSAHL8wA7xKg674tZpOvP9ZHYz7hd/phuRUSIFUL6ciqb19Xn3VvQ3TH/Nlfwz /qEQ== X-Gm-Message-State: AOAM53318qRY5ogrfaXfVnxK9Z3ypHj1yqNaIj750FYteQvHL7ZqgeXZ ca415Muu4/bTW8Id7dZVwJIc+Spy2FpiXjaY4e1jPk/hf1/xOPymWd8QiJFg9Xt366qfcsDO4R8 nez+3Dol3+LjdlDdTVqOg X-Received: by 2002:a05:6402:1d84:: with SMTP id dk4mr16107019edb.114.1629373673205; Thu, 19 Aug 2021 04:47:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHohZ5NfdmxdcGhQq+Sndo1LWlgOd7+f4Ug8TqM04qPyRrNbnp81HCpBHM9zRckngR6gaB0w== X-Received: by 2002:a05:6402:1d84:: with SMTP id dk4mr16106968edb.114.1629373672675; Thu, 19 Aug 2021 04:47:52 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id f12sm1166408ejz.99.2021.08.19.04.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 04:47:51 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D2728180471; Thu, 19 Aug 2021 13:47:50 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , Ederson de Souza Subject: Re: [[RFC xdp-hints] 13/16] libbpf: Helpers to access XDP frame metadata In-Reply-To: References: <20210803010331.39453-1-ederson.desouza@intel.com> <20210803010331.39453-14-ederson.desouza@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 19 Aug 2021 13:47:50 +0200 Message-ID: <87r1eppsex.fsf@toke.dk> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=toke@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Message-ID-Hash: HDSZD6G3PX3WQ6OTST2BUJ4DM2HMG5CT X-Message-ID-Hash: HDSZD6G3PX3WQ6OTST2BUJ4DM2HMG5CT X-MailFrom: toke@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: xdp-hints@xdp-project.net, bpf , Magnus Karlsson X-Mailman-Version: 3.3.4 Precedence: list List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Andrii Nakryiko writes: > On Mon, Aug 2, 2021 at 6:04 PM Ederson de Souza > wrote: >> >> Two new pairs of helpers: `xsk_umem__adjust_prod_data` and >> `xsk_umem__adjust_prod_data_meta` for data that is being produced by the >> application - such as data that will be sent; and >> `xsk_umem__adjust_cons_data` and `xsk_umem__adjust_cons_data_meta`, >> for data being consumed - such as data obtained from the completion >> queue. >> >> Those function should usually be used on data obtained via >> `xsk_umem__get_data`. Didn't change this function to avoid API breaks. >> >> Signed-off-by: Ederson de Souza >> --- > > AF_XDP parts of libbpf are being moved into libxdp ([0]). We shouldn't > keep adding new APIs if we are actively working on deprecating and > removing existing functionality already. CC'ing Toke and Magnus for > the state of libxsk to libxdp migration. > > [0] > https://github.com/xdp-project/xdp-tools/tree/master/lib/libxdp#using-af_xdp-sockets The AF_XDP code is merged into libxdp and is fully functional with the exception of Maciej's XDP program auto-detach feature which we need to replicate in a different way in libxdp. So as far as I'm concerned, we can just go ahead and accept patches for AF_XDP in libxdp. Does anyone have any thoughts on a preferred workflow? Having the libxdp patches completely separate in a Github PR seems like it will be an annoying workflow, so what to do instead? -Toke