Hi Maciej,

On Wed Mar 06 2024, Maciej Fijalkowski wrote:
> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
>> -	tstamp->skb = NULL;
>> +	/* Copy the tx hardware timestamp into xdp metadata or skb */
>> +	if (tstamp->buffer_type == IGC_TX_BUFFER_TYPE_XSK)
>
> I believe this should also be protected with xp_tx_metadata_enabled()
> check. We recently had following bugfix, PTAL:
>
> https://lore.kernel.org/bpf/20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de/
>
> I'll take a deeper look at patch tomorrow, might be the case that you've
> addressed that or you were aware of this issue but anyways wanted to bring
> it up. Just check that you don't break standard XDP/AF_XDP traffic :)

This one doesn't crash standard AF_XDP traffic. Don't know why, but it
seems to work.

Thanks,
Kurt