From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail.toke.dk (Postfix) with ESMTPS id B852FA7FECB for ; Fri, 09 Aug 2024 14:45:43 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=B43jrcsz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723207540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDR1PreyBYXGgczYYRhC/utTNT8xvL5WwhzEE5DaLg4=; b=B43jrcszpK6BbHxOWX7rcgHl+4uMh4DJMbSJfevfjq+sUwriDX59nPEqjOyPnvNF7drNnR cVDXGH4stz6mClkiKBROmTVT3ZQvK4tZBfsXdODAf9jN4VF3o4IbiyLslOraoazGtkIjOf o6i3HwWEQIyGefJduELBu0+MOLEQ8ok= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-u68qeAPIOV6G38zIlmXxQg-1; Fri, 09 Aug 2024 08:45:39 -0400 X-MC-Unique: u68qeAPIOV6G38zIlmXxQg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4281ca9f4dbso15546615e9.0 for ; Fri, 09 Aug 2024 05:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723207538; x=1723812338; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDR1PreyBYXGgczYYRhC/utTNT8xvL5WwhzEE5DaLg4=; b=NHlPB0BlQTO2GNvhybrsY7KHGrnleUzaQMSqD/9XF0UfzjfsVOOOWZchWGc6d1L8rD 0lwkRF3Ts+rFQbdgC40gZ3nfzEmWITu2YukVMb4hMA/qpqwSi5JgTQkBbt6rz73cGZ2l btyUaUJZMmsjkEtvEjOFQH2v/zvmrf1XmEaxcfz9PaKO4IRfcyEuNDAtrsL3Kdl3NSuP Y18cxNYmFanLn4PUP1Gcu8tNX9yyuKnT62xmM3tAfc0zdpnLfTW751X8DRdu+mwBowX3 ooRLJ0/Yf4Rq3oQO6InoqS3qgtWLAAkk6rwsBESmd5eGbiZBMH8vKfIM6jzQS7x5tK3P A8+g== X-Forwarded-Encrypted: i=1; AJvYcCWzUBQmFcFYriEnzuTkXs0lqjfCdYXW/XNdY6hNcLTj3VKf1wuQcLn1f6nS9qrmdHXa7lCn+U9gqq1NoZQDKrAzf5eFxdAyvmuN X-Gm-Message-State: AOJu0YyddIIUS4uZYogR6iNB5c2AzBtEG91C7PQM+EEfXENgBY4jSZop 5FfCrsiMB9Fry8ClRPmBpENbHPWSD5y4RUnPL0DfeMIBGa5L0XuZRmA3bMEZe1jW+C4Iw/a6s/q BAFgJW3BHgK61AxjnFOCDBB44jC+z97r+yDFhUXLa39SVR8AP3SONJKkS7Q== X-Received: by 2002:a05:600c:4e91:b0:428:1799:35e3 with SMTP id 5b1f17b1804b1-429c3a28d5dmr10716165e9.21.1723207537744; Fri, 09 Aug 2024 05:45:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiZUexO1DxZTYudFFvKsUA1By+NJF96m1YQZNLJ7cfOIryu3poJzd7dWE4i1OcJvheN6NR3g== X-Received: by 2002:a05:600c:4e91:b0:428:1799:35e3 with SMTP id 5b1f17b1804b1-429c3a28d5dmr10715775e9.21.1723207537234; Fri, 09 Aug 2024 05:45:37 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429059cd2b3sm126267855e9.44.2024.08.09.05.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 05:45:36 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 240EF14ADA65; Fri, 09 Aug 2024 14:45:33 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Alexander Lobakin , Daniel Xu In-Reply-To: <99662019-7e9b-410d-99fe-a85d04af215c@intel.com> References: <20220628194812.1453059-1-alexandr.lobakin@intel.com> <20220628194812.1453059-33-alexandr.lobakin@intel.com> <54aab7ec-80e9-44fd-8249-fe0cabda0393@intel.com> <308fd4f1-83a9-4b74-a482-216c8211a028@app.fastmail.com> <99662019-7e9b-410d-99fe-a85d04af215c@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 09 Aug 2024 14:45:33 +0200 Message-ID: <875xs9q2z6.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Message-ID-Hash: IOLUP2FAKOBWCWO5DHBJF7OU3RHTNDLD X-Message-ID-Hash: IOLUP2FAKOBWCWO5DHBJF7OU3RHTNDLD X-MailFrom: toke@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lorenzo Bianconi , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Larysa Zaremba , Michal Swiatkowski , Jesper Dangaard Brouer , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Lorenzo Bianconi , David Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , John Fastabend , Yajun Deng , Willem de Bruijn , "bpf@vger.kernel.org" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.9 Precedence: list Subject: [xdp-hints] Re: [PATCH RFC bpf-next 32/52] bpf, cpumap: switch to GRO from netif_receive_skb_list() List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Alexander Lobakin writes: > From: Daniel Xu > Date: Thu, 08 Aug 2024 16:52:51 -0400 > >> Hi, >> >> On Thu, Aug 8, 2024, at 7:57 AM, Alexander Lobakin wrote: >>> From: Lorenzo Bianconi >>> Date: Thu, 8 Aug 2024 06:54:06 +0200 >>> >>>>> Hi Alexander, >>>>> >>>>> On Tue, Jun 28, 2022, at 12:47 PM, Alexander Lobakin wrote: >>>>>> cpumap has its own BH context based on kthread. It has a sane batch >>>>>> size of 8 frames per one cycle. >>>>>> GRO can be used on its own, adjust cpumap calls to the >>>>>> upper stack to use GRO API instead of netif_receive_skb_list() which >>>>>> processes skbs by batches, but doesn't involve GRO layer at all. >>>>>> It is most beneficial when a NIC which frame come from is XDP >>>>>> generic metadata-enabled, but in plenty of tests GRO performs better >>>>>> than listed receiving even given that it has to calculate full frame >>>>>> checksums on CPU. >>>>>> As GRO passes the skbs to the upper stack in the batches of >>>>>> @gro_normal_batch, i.e. 8 by default, and @skb->dev point to the >>>>>> device where the frame comes from, it is enough to disable GRO >>>>>> netdev feature on it to completely restore the original behaviour: >>>>>> untouched frames will be being bulked and passed to the upper stack >>>>>> by 8, as it was with netif_receive_skb_list(). >>>>>> >>>>>> Signed-off-by: Alexander Lobakin >>>>>> --- >>>>>> kernel/bpf/cpumap.c | 43 ++++++++++++++++++++++++++++++++++++++----- >>>>>> 1 file changed, 38 insertions(+), 5 deletions(-) >>>>>> >>>>> >>>>> AFAICT the cpumap + GRO is a good standalone improvement. I think >>>>> cpumap is still missing this. >>> >>> The only concern for having GRO in cpumap without metadata from the NIC >>> descriptor was that when the checksum status is missing, GRO calculates >>> the checksum on CPU, which is not really fast. >>> But I remember sometimes GRO was faster despite that. >> >> Good to know, thanks. IIUC some kind of XDP hint support landed already? >> >> My use case could also use HW RSS hash to avoid a rehash in XDP prog. > > Unfortunately, for now it's impossible to get HW metadata such as RSS > hash and checksum status in cpumap. They're implemented via kfuncs > specific to a particular netdevice and this info is available only when > running XDP prog. > > But I think one solution could be: > > 1. We create some generic structure for cpumap, like > > struct cpumap_meta { > u32 magic; > u32 hash; > } > > 2. We add such check in the cpumap code > > if (xdpf->metalen == sizeof(struct cpumap_meta) && > ) > skb->hash = meta->hash; > > 3. In XDP prog, you call Rx hints kfuncs when they're available, obtain > RSS hash and then put it in the struct cpumap_meta as XDP frame metadata. Yes, except don't make this cpumap-specific, make it generic for kernel consumption of the metadata. That way it doesn't even have to be stored in the xdp metadata area, it can be anywhere we want (and hence not subject to ABI issues), and we can use it for skb creation after redirect in other places than cpumap as well (say, on veth devices). So it'll be: struct kernel_meta { u32 hash; u32 timestamp; ...etc } and a kfunc: void store_xdp_kernel_meta(struct kernel meta *meta); which the XDP program can call to populate the metadata area. -Toke