From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail.toke.dk (Postfix) with ESMTPS id BD9C09C7757 for ; Mon, 28 Nov 2022 23:10:18 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UOocgKxk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669673416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vJAfrSiLBZ1GH3+ALah4IS7MdEjQe3AC2nBRfXse76c=; b=UOocgKxkHi0mVvh7IAezz8AyZCASB7xRJyW+isE4wKdwgQdVI+o8eF7WyaTW4Qv1XlKOL1 AuF6ieHcpgtNaOCwk7d7EHVJx1tOto1YR47R1UCHl0IvwvhEP41KSnNgA+OZSzkUeVV4Mo J7bFo8b+G8EAzsXcXNOs5VH3fEvXj0g= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-422-7RdM-a1GOHiaJ6C3h59Esw-1; Mon, 28 Nov 2022 17:10:13 -0500 X-MC-Unique: 7RdM-a1GOHiaJ6C3h59Esw-1 Received: by mail-ej1-f69.google.com with SMTP id hs42-20020a1709073eaa00b007c00fb5a509so1864299ejc.17 for ; Mon, 28 Nov 2022 14:10:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJAfrSiLBZ1GH3+ALah4IS7MdEjQe3AC2nBRfXse76c=; b=LcuQvKhr+Ml4oVaCfAT1DbvKYcCyQOTar0ZJfaaABMN8dyBDtwvlWZaSgUiKHm/GQV tagYneWkDbzDO05/13XdHwXa6wWbAS3GwfU8OdGk5RQnj8ZV0sgUYJl4T435vnYtefDA U9eyJTs6/8dZZeqIuVQfGNbgN2MB2ouOavrw5GpgU62Z1Qk9fffqUc49YOiJKVaiK5dv 6KkAFqQ+cn7IrPVbq4LXo0JQaFOaaQHuHTfFfXLpkRaAlptDBVIXTbDD/RmPayd0Pgix qENPpnB9ZcN4Fpqfbg1p48I5xePJeAfrb4u698JhEUk4Y692cm8njZ7cxCZ9OYQPUBkV tu1Q== X-Gm-Message-State: ANoB5pn3G5LHrCfXo3FQ6S1g/4zeCHC9GUyu66x0tffOBJunYLRG/Fg6 sxLdoMmQDNo3dkH1HG1POwKXYUcJTPglInM/so/i585wrjJkOzdelDB5Bn3z99LhBCcebxydHvf QWBs+RMLqOPEh+SHJNzUL X-Received: by 2002:a17:906:df47:b0:7c0:747a:1e0d with SMTP id if7-20020a170906df4700b007c0747a1e0dmr4682883ejc.224.1669673411823; Mon, 28 Nov 2022 14:10:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf425gA6m8pgpUvpIT8KHNPMAzGFBEXZEVPOH9JlVG4aiPoCzI4HDFBWqcj759365DVU9Cme3w== X-Received: by 2002:a17:906:df47:b0:7c0:747a:1e0d with SMTP id if7-20020a170906df4700b007c0747a1e0dmr4682862ejc.224.1669673411347; Mon, 28 Nov 2022 14:10:11 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 11-20020a170906300b00b007aee947ce9esm5417641ejz.138.2022.11.28.14.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 14:10:10 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3B5057EBE9C; Mon, 28 Nov 2022 23:10:10 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Stanislav Fomichev In-Reply-To: References: <20221121182552.2152891-1-sdf@google.com> <20221121182552.2152891-3-sdf@google.com> <87mt8e2a69.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 28 Nov 2022 23:10:10 +0100 Message-ID: <874jui20jh.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NMZHGYAV2IOWMHMQ35GDSD4MM3RUOZVQ X-Message-ID-Hash: NMZHGYAV2IOWMHMQ35GDSD4MM3RUOZVQ X-MailFrom: toke@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v2 2/8] bpf: XDP metadata RX kfuncs List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Stanislav Fomichev writes: > s > > On Fri, Nov 25, 2022 at 9:53 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> Stanislav Fomichev writes: >> >> > There is an ndo handler per kfunc, the verifier replaces a call to the >> > generic kfunc with a call to the per-device one. >> > >> > For XDP, we define a new kfunc set (xdp_metadata_kfunc_ids) which >> > implements all possible metatada kfuncs. Not all devices have to >> > implement them. If kfunc is not supported by the target device, >> > the default implementation is called instead. >> >> BTW, this "the default implementation is called instead" bit is not >> included in this version... :) > > fixup_xdp_kfunc_call should return 0 when the device doesn't have a > kfunc defined and should fallback to the default kfunc implementation, > right? > Or am I missing something? Ohh, right. Maybe add a comment stating this (as I obviously missed it :)) -Toke