From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail.toke.dk; spf=pass (mailfrom) smtp.mailfrom=rts-flowmailer.siemens.com (client-ip=185.136.64.226; helo=mta-64-226.siemens.flowmailer.net; envelope-from=fm-68982-202312041154594398509551827f0d2c-hac9kh@rts-flowmailer.siemens.com; receiver=) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; secure) header.d=siemens.com header.i=florian.bezdeka@siemens.com header.a=rsa-sha256 header.s=fm1 header.b=ph2h0h5j Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net [185.136.64.226]) by mail.toke.dk (Postfix) with ESMTPS id E4ED6A43162 for ; Mon, 4 Dec 2023 12:55:01 +0100 (CET) Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 202312041154594398509551827f0d2c for ; Mon, 04 Dec 2023 12:55:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=florian.bezdeka@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=DeAVJVh1/dmfA7n8KCr9e65gohS5SL4YYZz1yRamMmo=; b=ph2h0h5jvGxuWKVsNS0TMd+fNjmiTxwfMkny+Ro6YD2+HKnOLi/CClvCRs5tLNpmSk0jh2 b2Xas1pUz9iB6dBJVNhJnkJ3JLnWbdX0OqFTVBA38AMksw93F1/n2DVd92g1cldYwMwE1iYt KYrV+sFm2RBFyevOjoDdSCwH2EABY=; Message-ID: <8602c88c98fd722db8e164a1520c56aebfa64db7.camel@siemens.com> From: Florian Bezdeka To: Jesper Dangaard Brouer , Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Date: Mon, 04 Dec 2023 12:54:56 +0100 In-Reply-To: <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> References: <20231203165129.1740512-1-yoong.siang.song@intel.com> <20231203165129.1740512-3-yoong.siang.song@intel.com> <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer Message-ID-Hash: 4OGG57NWOTSZX25MZ6XV6PYTUBGXF6DY X-Message-ID-Hash: 4OGG57NWOTSZX25MZ6XV6PYTUBGXF6DY X-MailFrom: fm-68982-202312041154594398509551827f0d2c-hac9kH@rts-flowmailer.siemens.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 2023-12-04 at 11:36 +0100, Jesper Dangaard Brouer wrote: > On 12/3/23 17:51, Song Yoong Siang wrote: > > This patch enables Launch Time (Time-Based Scheduling) support to XDP z= ero > > copy via XDP Tx metadata framework. > >=20 > > Signed-off-by: Song Yoong Siang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ >=20 > As requested before, I think we need to see another driver implementing= =20 > this. >=20 > I propose driver igc and chip i225. igc support would be really nice and highly appreciated. There are a lot of tests running here with that chip (i225/i226) / driver (igc) combination. Let me know if we can support somehow, testing included. >=20 > The interesting thing for me is to see how the LaunchTime max 1 second > into the future[1] is handled code wise. One suggestion is to add a=20 > section to Documentation/networking/xsk-tx-metadata.rst per driver that= =20 > mentions/documents these different hardware limitations. It is natural= =20 > that different types of hardware have limitations. This is a close-to= =20 > hardware-level abstraction/API, and IMHO as long as we document the=20 > limitations we can expose this API without too many limitations for more= =20 > capable hardware. >=20 > [1]=20 > https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_f= ollow_qdisc_TSN_offload.org#setup-code-driver-igb >=20 > This stmmac driver and Intel Tiger Lake CPU must also have some limit on= =20 > how long into the future it will/can schedule packets? >=20 >=20 > People from xdp-hints list must make their voice hear if they want i210= =20 > and igb driver support, because it have even-more hardware limitations,= =20 > see [1] (E.g. only TX queue 0 and 1 supports LaunchTime). BUT I know=20 > some have this hardware in production and might be motivated to get a=20 > functioning driver with this feature? i210 support would be nice, that would allow us to compare some test setups with different NICs. In addition it would simplify some test setups. For now, IMHO igc is more important. >=20 > --Jesper