From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by mail.toke.dk (Postfix) with ESMTPS id 17CB1A588A2 for ; Fri, 1 Mar 2024 18:24:03 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=m0+zqMcR Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6e571666804so1746763b3a.2 for ; Fri, 01 Mar 2024 09:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709313839; x=1709918639; darn=xdp-project.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RyyU1KTZ+u7IZU/ZLxa5MUX+oMEqsxDrKnYwc61Y+0Q=; b=m0+zqMcR3E4en5onj4mteHSO15VMIqjkSoZSzw/oE7yw5xQ3cPRZA5jwPRWm/IJYZh zaNNRaTc0O+WkzQ3auiH5lHup4GAeVGR7jzzBQKVhRtZAt/kZCRctWmt7RsnyFsG/pRO VtI15apHHb0nQbG3wkZuitIpRTLKJmITOwo6gVzTQU2hOP4LoEfLPQTgV0dRC54ID8gD 32z61v5PG5i0vdK6RbqRujmMsVSwwpT2XUQX6fw0cp48ctGvjyDjH81kdqV3w2NnSDsb Gc/ypJN03U/HPgtw9HZYoMyJfN5MT2befvtXDfwIdBIOofoeRgOGCJo6xygW36XJ50r/ eS/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709313839; x=1709918639; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RyyU1KTZ+u7IZU/ZLxa5MUX+oMEqsxDrKnYwc61Y+0Q=; b=Zj0JH1mc7Fg7oVtRLdqknfKmfDMEVLuziV+COwKTZqG+WpBwAGmW5HTMKjAozj9aLW rVYAXZAvQ/iyJjh1pHWSt7JSOkyCZX/bn701GfGUjfFGbhgfgGSR0K1FliDsG7ydBWQR Vvwxk6yAKEtBsq6K49SzTcVbehX8A+c7w3rPv/byfvUWKAxggzTUd9PbUGFqMtb3LP0D vsYJauhrueceQ61cp/kDjCS1jfgflb+N/78a0gjMDiPtYgLgKPFtptMnCVg3evrP7qt9 lvwwLvEGeStdDY+G4YuAdlhE57ogs+uBMHFf56BH4o/8iG7vCrFbXSfXiIcoQzoFytSB Hlwg== X-Forwarded-Encrypted: i=1; AJvYcCVTtuWfo/TF0cXtyOKZYyAwdRSxaAYWlBL5bGGsujIOYDUF+wWPwHFzSiHqM3UaazKtJvKwcEM38u4uLqqD7NIOQgeO7HiSU8S2 X-Gm-Message-State: AOJu0Yw+M1AWOvibZYpJxQpfmMViFyX64tfn73H4scjgtGt0yo4Otn3A y8CxIqO+zDkr/IzBk1BbiF6Ww5QqKyqlr/2YPFXN615UpiPDWEXx X-Google-Smtp-Source: AGHT+IERqxQxkRkE14VITG6EjQITNnYMzffw4XzcbvyQqW4Wc7ZerAs9c1302bg9Ijqngdcp3rSclw== X-Received: by 2002:a05:6a20:4283:b0:1a0:e3c6:18da with SMTP id o3-20020a056a20428300b001a0e3c618damr2372160pzj.27.1709313839390; Fri, 01 Mar 2024 09:23:59 -0800 (PST) Received: from localhost ([98.97.43.160]) by smtp.gmail.com with ESMTPSA id i37-20020a635865000000b005dc5289c4edsm3219408pgm.64.2024.03.01.09.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:23:58 -0800 (PST) Date: Fri, 01 Mar 2024 09:23:57 -0800 From: John Fastabend To: Song Yoong Siang , Jesse Brandeburg , Tony Nguyen , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Vinicius Costa Gomes , Florian Bezdeka , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan Message-ID: <65e20f2d314bd_5dcfe20857@john.notmuch> In-Reply-To: <20240301162348.898619-2-yoong.siang.song@intel.com> References: <20240301162348.898619-1-yoong.siang.song@intel.com> <20240301162348.898619-2-yoong.siang.song@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: OHUUQIHGBVLEGECV22CW66RJ5Q4RFTMH X-Message-ID-Hash: OHUUQIHGBVLEGECV22CW66RJ5Q4RFTMH X-MailFrom: john.fastabend@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.9 Precedence: list Subject: [xdp-hints] Re: [PATCH iwl-next,v2 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Song Yoong Siang wrote: > In current ping-pong design, xdp_hw_metadata will wait until the packet > transmition completely done, then only start to receive the next packet. > > The current sleep interval is 10ms, which is unnecessary large. Typically, > a NIC does not need such a long time to transmit a packet. Furthermore, > during this 10ms sleep time, the app is unable to receive incoming packets. > > Therefore, this commit reduce sleep interval to 10us, so that > xdp_hw_metadata able to support periodic packets with shorter interval. > 10us * 500 = 5ms should be enough for packet transmission and status > retrival. > > Signed-off-by: Song Yoong Siang > --- > tools/testing/selftests/bpf/xdp_hw_metadata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c > index 878d68db0325..bdf5d8180067 100644 > --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c > +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c > @@ -480,7 +480,7 @@ static int verify_metadata(struct xsk *rx_xsk, int rxq, int server_fd, clockid_t > for (int j = 0; j < 500; j++) { > if (complete_tx(xsk, clock_id)) > break; > - usleep(10*1000); > + usleep(10); > } > } > } > -- > 2.34.1 > Acked-by: John Fastabend