From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by mail.toke.dk (Postfix) with ESMTPS id 88815A439E1 for ; Tue, 5 Dec 2023 15:55:21 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=EvTZ+OOc Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-db537948ea0so4038365276.2 for ; Tue, 05 Dec 2023 06:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701788119; x=1702392919; darn=xdp-project.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Vwn3+d55WIDQqPzaUZ6Y1euKtU0awuVxdMPC2F9sWJM=; b=EvTZ+OOcdwSbfZiei0sNlCjDFNEPEpNMOwnhh8odaWxJAX1xLM/BTU5+Oy1i7cpgiU IRgRer4hmYGX8lzmmLuRc2GlpVNx9omhIqFzuKqwiwMsyidABoaehY+Sv8g9CkTIr8wb AjTZHN3fODCX+UKnt9Za8/isav81pjRFTKEAd2/knTGLwdJDSB1h4GUgkxVyC1PJDAxk yrXj20jxOsDRkr7542/OBw5NFjeXxlk7WGagxLmGEIAwC/KW4Ys+9GSbgRKqlmpID0At BJZosu9rJHQR/+bOtsc9Z5cK2c7MmgqUe2VZ59ET1Jw2P7Sz7OJmvwodus8XZ93C1tm0 cY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701788119; x=1702392919; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Vwn3+d55WIDQqPzaUZ6Y1euKtU0awuVxdMPC2F9sWJM=; b=BQL08ZZp4sFb/MDKtJaAEhHm1P+JcziCAw37sHsDxg/33EFoyk3Pd06u4VSU297EnE oXQ2LwxgrzByff88Z9WeOu9RfWgB/UzAr3hnH8Hc5r+fZH+baAVbv62rPw+MuRiina61 B28Si6wd6BlKJf4/WAh/cYWeGrB5bY7tI/5/NVrrCAp1STj58Ti0eXzkBwdwy/MoKlnR hWwqJO6oV1s8QIjf0EGJkNU9yflsqMa6e1SH6oasysqeP9YgPFDS5Mbq4j/d4yjLMIxr 8b/zkYAD0jHqJunYrjSDIhzt1NWtFlhyEftG8nseTDeVJBRPgAHgJQE9fGIeUg3tTz9F AxaQ== X-Gm-Message-State: AOJu0YxcXD72KWjz0SNO48X8VUqrrMBD97SF5leK/P75P0HXBsHocN8x k5DXDYDU/qsKsTLCiV4IaNw= X-Google-Smtp-Source: AGHT+IEnh/AUcJ58dEYlv0mOXPOLlM3dnoDwAL/EwYEQJJaHDHgJRu8pTV3oURCvpfonLhzgIUIT/Q== X-Received: by 2002:a25:c50a:0:b0:db5:4d4b:d8a7 with SMTP id v10-20020a25c50a000000b00db54d4bd8a7mr4619822ybe.50.1701788119064; Tue, 05 Dec 2023 06:55:19 -0800 (PST) Received: from localhost (114.66.194.35.bc.googleusercontent.com. [35.194.66.114]) by smtp.gmail.com with ESMTPSA id ez16-20020ad45910000000b0067aa25438fdsm3832891qvb.40.2023.12.05.06.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 06:55:18 -0800 (PST) Date: Tue, 05 Dec 2023 09:55:18 -0500 From: Willem de Bruijn To: "Song, Yoong Siang" , Willem de Bruijn , Jesper Dangaard Brouer , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Message-ID: <656f39d668439_3dd6422949e@willemb.c.googlers.com.notmuch> In-Reply-To: References: <20231201062421.1074768-1-yoong.siang.song@intel.com> <20231201062421.1074768-3-yoong.siang.song@intel.com> <5a660c0f-d3ed-47a2-b9be-098a224b8a12@kernel.org> <656de8eb14c24_2e983e29435@willemb.c.googlers.com.notmuch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: BPTBIFYEEMT4KDUPIR5ONF5DFQYQJQ3H X-Message-ID-Hash: BPTBIFYEEMT4KDUPIR5ONF5DFQYQJQ3H X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bpf@vger.kernel.org" , "xdp-hints@xdp-project.net" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Song, Yoong Siang wrote: > On Monday, December 4, 2023 10:58 PM, Willem de Bruijn wrote: > >Song, Yoong Siang wrote: > >> On Friday, December 1, 2023 11:02 PM, Jesper Dangaard Brouer wrote: > >> >On 12/1/23 07:24, Song Yoong Siang wrote: > >> >> This patch enables txtime support to XDP zero copy via XDP Tx > >> >> metadata framework. > >> >> > >> >> Signed-off-by: Song Yoong Siang > >> >> --- > >> >> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +++++++++++++ > >> >> 2 files changed, 15 insertions(+) > >> > > >> >I think we need to see other drivers using this new feature to evaluate > >> >if API is sane. > >> > > >> >I suggest implementing this for igc driver (chip i225) and also for igb > >> >(i210 chip) that both support this kind of LaunchTime feature in HW. > >> > > >> >The API and stmmac driver takes a u64 as time. > >> >I'm wondering how this applies to i210 that[1] have 25-bit for > >> >LaunchTime (with 32 nanosec granularity) limiting LaunchTime max 0.5 > >> >second into the future. > >> >And i225 that [1] have 30-bit max 1 second into the future. > >> > > >> > > >> >[1] > >> >https://github.com/xdp-project/xdp- > >> >project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org > >> > >> I am using u64 for launch time because existing EDT framework is using it. > >> Refer to struct sk_buff below. Both u64 and ktime_t can be used as launch time. > >> I choose u64 because ktime_t often requires additional type conversion and > >> we didn't expect negative value of time. > >> > >> include/linux/skbuff.h-744- * @tstamp: Time we arrived/left > >> include/linux/skbuff.h:745- * @skb_mstamp_ns: (aka @tstamp) earliest departure > >time; start point > >> include/linux/skbuff.h-746- * for retransmit timer > >> -- > >> include/linux/skbuff.h-880- union { > >> include/linux/skbuff.h-881- ktime_t tstamp; > >> include/linux/skbuff.h:882- u64 skb_mstamp_ns; /* earliest departure > >time */ > >> include/linux/skbuff.h-883- }; > >> > >> tstamp/skb_mstamp_ns are used by various drivers for launch time support > >> on normal packet, so I think u64 should be "friendly" to all the drivers. For an > >> example, igc driver will take launch time from tstamp and recalculate it > >> accordingly (i225 expect user to program "delta time" instead of "time" into > >> HW register). > >> > >> drivers/net/ethernet/intel/igc/igc_main.c-1602- txtime = skb->tstamp; > >> drivers/net/ethernet/intel/igc/igc_main.c-1603- skb->tstamp = ktime_set(0, 0); > >> drivers/net/ethernet/intel/igc/igc_main.c:1604- launch_time = > >igc_tx_launchtime(tx_ring, txtime, &first_flag, &insert_empty); > >> > >> Do you think this is enough to say the API is sane? > > > >u64 nsec sounds sane to be. It must be made explicit with clock source > >it is against. > > > > The u64 launch time should base on NIC PTP hardware clock (PHC). > I will add documentation saying which clock source it is against It's not that obvious to me that that is the right and only choice. See below. > >Some applications could want to do the conversion from a clock source > >to raw NIC cycle counter in userspace or BPF and program the raw > >value. So it may be worthwhile to add an clock source argument -- even > >if initially only CLOCK_MONOTONIC is supported. > > Sorry, not so understand your suggestion on adding clock source argument. > Are you suggesting to add clock source for the selftest xdp_hw_metadata apps? > IMHO, no need to add clock source as the clock source for launch time > should always base on NIC PHC. This is not how FQ and ETF qdiscs pass timestamps to drivers today. Those are in CLOCK_MONOTONIC or CLOCK_TAI. The driver is expected to convert from that to its descriptor format, both to the reduced bit width and the NIC PHC. See also for instance how sch_etf has an explicit q->clock_id match, and SO_TXTIME added an sk_clock_id for the same purpose: to agree on which clock source is being used.