From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by mail.toke.dk (Postfix) with ESMTPS id 27CD4A43273 for ; Mon, 4 Dec 2023 15:54:47 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nrSmh8Ad Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-4255d068a1eso2851101cf.0 for ; Mon, 04 Dec 2023 06:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701701682; x=1702306482; darn=xdp-project.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Bg3OAjxlhkHVroLExkyXrSp7hB9PGqxL9CSH3f9aKos=; b=nrSmh8Ad/ixw0RDiQ4XW6MZi/Wr4ndqV1HaFtcStSXuW1VOusoCj7398PYMxUkQq7W fYeJbxLlzEcKfH6Qv+KrXK4mbLJ+JYH9XVx9YXukcuuzZV0JiA/dZMk2mROL7RzG3TVG Xs9vFULuj368n06UxWaXhvyWxWIS+5EaMfZkBJbG3pQu9cJX4nYmPKm5SnK0jDKPbbGb C6jZvlFZ7Zb3noORVo0csrjJ+BJZhGSkSajxb++1IWbRc5hBJhaJdYdgy8PXfG2V6olL k+fQHKnIDfbyjOAxLD0ArMffQuO3kduzZel18m7PB+Ccc/kNFFbOgnsFaT0MMn+vTTWP el5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701701682; x=1702306482; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Bg3OAjxlhkHVroLExkyXrSp7hB9PGqxL9CSH3f9aKos=; b=H2lTpDIlN4/+AeULzsZdLcBtLWPYu6YJFOE+CFtq/B5/tQ/mVbsATwg0t8jHXuzDxM yLkxTQjYof3mk8LKkkQuo5kRUdTINkuJIB1yQVU0mjcV9KNaUS3FJ8Ws2HBPLGuqiQAB deiu8uVedTEKpAMGRUz1HUU5zGzJ66C86Rh28cIjruVR9TMzkfNJ9G4tVWEkxQEclX4g KeP0XDL/aMIRs0Tt1o1GBO7WqcdLbrGlPlWG8BpDWt15JpucOA/tGDSalakDMCQCNF33 3PSaSDB7jgUKXmHAQqtjoJGbcrPC+MYas26B/P7Z8Vcoig7uLluuq/j8JECTN3fYR6po ezUg== X-Gm-Message-State: AOJu0YxpFnVpTSRT0JOZYUTEU09xuhHChOC4UD1ZyTOSiySKmhJVCBLJ Lf3FJz3DZXdWuFQ20+bqlbw= X-Google-Smtp-Source: AGHT+IHmGk8EW1nYxUJzot/wHNOP9alDTyqyX08Vu4COc7aS8T/1IoLrhxMpc+DSC3CEsmazSLPpyg== X-Received: by 2002:a05:6214:11a4:b0:67a:ad71:ce63 with SMTP id u4-20020a05621411a400b0067aad71ce63mr4980388qvv.90.1701701681739; Mon, 04 Dec 2023 06:54:41 -0800 (PST) Received: from localhost (114.66.194.35.bc.googleusercontent.com. [35.194.66.114]) by smtp.gmail.com with ESMTPSA id l4-20020ac84584000000b00421b14f7e7csm4356420qtn.48.2023.12.04.06.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:54:41 -0800 (PST) Date: Mon, 04 Dec 2023 09:54:40 -0500 From: Willem de Bruijn To: Jesper Dangaard Brouer , Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Message-ID: <656de830e8d70_2e983e294ca@willemb.c.googlers.com.notmuch> In-Reply-To: <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> References: <20231203165129.1740512-1-yoong.siang.song@intel.com> <20231203165129.1740512-3-yoong.siang.song@intel.com> <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: ZGSQTNOOBA7OTDZXIQHC5JR5JICIBQ2E X-Message-ID-Hash: ZGSQTNOOBA7OTDZXIQHC5JR5JICIBQ2E X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Jesper Dangaard Brouer wrote: > > > On 12/3/23 17:51, Song Yoong Siang wrote: > > This patch enables Launch Time (Time-Based Scheduling) support to XDP zero > > copy via XDP Tx metadata framework. > > > > Signed-off-by: Song Yoong Siang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > > As requested before, I think we need to see another driver implementing > this. > > I propose driver igc and chip i225. > > The interesting thing for me is to see how the LaunchTime max 1 second > into the future[1] is handled code wise. One suggestion is to add a > section to Documentation/networking/xsk-tx-metadata.rst per driver that > mentions/documents these different hardware limitations. It is natural > that different types of hardware have limitations. This is a close-to > hardware-level abstraction/API, and IMHO as long as we document the > limitations we can expose this API without too many limitations for more > capable hardware. I would assume that the kfunc will fail when a value is passed that cannot be programmed. What is being implemented here already exists for qdiscs. The FQ qdisc takes a horizon attribute and " when a packet is beyond the horizon at enqueue() time: - either drop the packet (default policy) - or cap its delivery time to the horizon. " commit 39d010504e6b ("net_sched: sch_fq: add horizon attribute") Having the admin manually configure this on the qdisc based on off-line knowledge of the device is more fragile than if the device would somehow signal its limit to the stack. But I don't think we should add enforcement of that as a requirement for this xdp extension of pacing.