From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by mail.toke.dk (Postfix) with ESMTPS id 57396A41E94 for ; Fri, 1 Dec 2023 16:27:54 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LPDhRmPe Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-423f2d0c8baso13722561cf.2 for ; Fri, 01 Dec 2023 07:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701444412; x=1702049212; darn=xdp-project.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+Y5uUpKThH5AlPxwZK/+8ce/JS/o6enGufFaGhxrFrA=; b=LPDhRmPeNkeyHXXmONsaktcpGZXbyDgQVZkymqz9NbmlfvEGGo/FxtxbhYCpWUI1o0 UCvA1gV/q809ZkIMAtd6tgb+uanCLcTWKKR3+tG0Tl26rnFR67uRGr151A2rJedgdHtt il554TqDyGbDLQb1BYp/Vtuqid2VTgBDIMtH7U5uL6sWGelrrVuyLhWD7vTkO29TFIB2 snwgppvpBrdYMtuMZV8GviFyr6PyUzbRSk9TtVsE7VyjGiAUGi5tflmWZ3wI1GzydiBg IC/zdPPwvZS1YZw9V2hzi9xtr1yWYWNWJBBtGeIN9n67AHFYPEb5PThaZFEaDnNLJPxn yavw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701444412; x=1702049212; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+Y5uUpKThH5AlPxwZK/+8ce/JS/o6enGufFaGhxrFrA=; b=HYabibX2sOpKQox6AXM34rY2spbFfE1718oY6w79Dwq0LgIncaVi3UXJu6+29PVW+I dQD+fSLHps4x4WIDZOT3omX2erp8x3RFXx3RlYxNQHerCxnL4c6BejcETkj0nir/1g2T dFldpipMzoUCzBfY79oGbUiD8xkcqtONiYtKlP0MTXWNNkhDsq3RLrazjDIt7SPr+1qx 53F5SJOiFvFLgFUiuL6I7Ex9AVjwr4eMF9hmEHihnPjAh1sKUxx9G/n+toLTsTB2eEvh /loiJO9AO2EBT5jRkpoGr3X3TkQrDVrQCEcl0hX5eTCNfJLTLq/4W8O69ttAzT/0xxFp k8QQ== X-Gm-Message-State: AOJu0YyX1R3vfxVfWerIcTs80WUkXKrMze18w/LZQx7xmG/QiWuU6ajz wXSCVhaW6V2dxgp7t7JNUfo= X-Google-Smtp-Source: AGHT+IE7pPHWo5O6L0cGSE4Vt8ZBvbgF4ZpSTi5qSKV/OfAW0SLGDPjTMnoWDJPMCufOEPTxcgQJbA== X-Received: by 2002:a05:622a:1a89:b0:423:6e29:c149 with SMTP id s9-20020a05622a1a8900b004236e29c149mr30091182qtc.1.1701444412484; Fri, 01 Dec 2023 07:26:52 -0800 (PST) Received: from localhost (114.66.194.35.bc.googleusercontent.com. [35.194.66.114]) by smtp.gmail.com with ESMTPSA id w2-20020ac87182000000b00423de58d3d8sm1567519qto.40.2023.12.01.07.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:26:51 -0800 (PST) Date: Fri, 01 Dec 2023 10:26:51 -0500 From: Willem de Bruijn To: Jesper Dangaard Brouer , Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Message-ID: <6569fb3b31fb6_1396ec2948@willemb.c.googlers.com.notmuch> In-Reply-To: <5a660c0f-d3ed-47a2-b9be-098a224b8a12@kernel.org> References: <20231201062421.1074768-1-yoong.siang.song@intel.com> <20231201062421.1074768-3-yoong.siang.song@intel.com> <5a660c0f-d3ed-47a2-b9be-098a224b8a12@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: Q4CBCPDLMC73FUF2I3QE7CPSMESHRIHI X-Message-ID-Hash: Q4CBCPDLMC73FUF2I3QE7CPSMESHRIHI X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Jesper Dangaard Brouer wrote: > > > On 12/1/23 07:24, Song Yoong Siang wrote: > > This patch enables txtime support to XDP zero copy via XDP Tx > > metadata framework. > > > > Signed-off-by: Song Yoong Siang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +++++++++++++ > > 2 files changed, 15 insertions(+) > > I think we need to see other drivers using this new feature to evaluate > if API is sane. > > I suggest implementing this for igc driver (chip i225) and also for igb > (i210 chip) that both support this kind of LaunchTime feature in HW. > > The API and stmmac driver takes a u64 as time. > I'm wondering how this applies to i210 that[1] have 25-bit for > LaunchTime (with 32 nanosec granularity) limiting LaunchTime max 0.5 > second into the future. > And i225 that [1] have 30-bit max 1 second into the future. > > > [1] > https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org Good point Jesper. Can we also explicitly document what the type of the field is? Nanoseconds against the NIC hardware clock, it sounds like. We have some experience with this, too. Something needs to do the conversion from host clock to NIC clock. It is not sufficent to just assume that the host clock is synced against the NIC clock by PTP.